Re: [PATCH v4 1/3] iommu/arm-smmu-v3: Introduce struct arm_smmu_event

[Pranjal Shrivastava <praan@google.com>]

On Wed, Nov 06, 2024 at 04:10:01PM -0800, Daniel Mentz wrote:
> On Mon, Nov 4, 2024 at 12:31 AM Pranjal Shrivastava <praan@google.com> wrote:
> >
> > On Sun, Nov 03, 2024 at 09:25:52PM -0800, Daniel Mentz wrote:
> > > > > >   #define EVT_ID_TRANSLATION_FAULT  0x10
> > > > > >   #define EVT_ID_ADDR_SIZE_FAULT            0x11
> > > > > >   #define EVT_ID_ACCESS_FAULT               0x12
> > > > > > @@ -452,6 +453,7 @@ static inline unsigned int arm_smmu_cdtab_l2_idx(unsigned int ssid)
> > > > > >   #define EVTQ_1_RnW                        (1UL << 35)
> > > > > >   #define EVTQ_1_S2                 (1UL << 39)
> > > > > >   #define EVTQ_1_CLASS                      GENMASK_ULL(41, 40)
> > > > > > +#define EVTQ_1_CLASS_TT                    0x1
> > >
> > > Remove this if it's not used anywhere.
> > >
> >
> > We're using it in `arm_smmu_get_event_from_raw` function for TTRnW:
> >
> > +       if (event->id == EVT_ID_PERMISSION_FAULT)
> > +               event->ttrnw_valid = (event->class == EVTQ_1_CLASS_TT);
> >
> 
> The #define for EVTQ_1_CLASS_TT should be added in your second patch
> with title "iommu/arm-smmu-v3: Log better event records" where it's
> used for the first time.

Ahh, yes! Apologies. Will move it to the right patch.

Thanks,
Praan