From: Nicolin Chen <nicolinc@nvidia.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: <jgg@nvidia.com>, <jgg@ziepe.ca>, <kevin.tian@intel.com>,
<will@kernel.org>, <aneesh.kumar@kernel.org>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<joro@8bytes.org>, <robin.murphy@arm.com>, <shuah@kernel.org>,
<aik@amd.com>, <dan.j.williams@intel.com>,
<baolu.lu@linux.intel.com>, <yilun.xu@intel.com>
Subject: Re: [PATCH v5 8/8] iommufd: Rename some shortterm-related identifiers
Date: Tue, 15 Jul 2025 12:13:55 -0700 [thread overview]
Message-ID: <aHaoczqqBIhZ7k1Z@Asurada-Nvidia> (raw)
In-Reply-To: <20250715063245.1799534-9-yilun.xu@linux.intel.com>
On Tue, Jul 15, 2025 at 02:32:45PM +0800, Xu Yilun wrote:
> Rename the shortterm-related identifiers to wait-related.
>
> The usage of shortterm_users refcount is now beyond its name. It is
> also used for references which live longer than an ioctl execution.
> E.g. vdev holds idev's shortterm_users refcount on vdev allocation,
> releases it during idev's pre_destroy(). Rename the refcount as
> wait_cnt, since it is always used to sync the referencing & the
> destruction of the object by waiting for it to go to zero.
>
> List all changed identifiers:
>
> iommufd_object::shortterm_users -> iommufd_object::wait_cnt
> REMOVE_WAIT_SHORTTERM -> REMOVE_WAIT
> iommufd_object_dec_wait_shortterm() -> iommufd_object_dec_wait()
> zerod_shortterm -> zerod_wait_cnt
>
> No functional change intended.
>
> Suggested-by: Kevin Tian <kevin.tian@intel.com>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
next prev parent reply other threads:[~2025-07-15 19:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 6:32 [PATCH v5 0/8] iommufd: Destroy vdevice on device unbind Xu Yilun
2025-07-15 6:32 ` [PATCH v5 1/8] iommufd/viommu: Roll back to use iommufd_object_alloc() for vdevice Xu Yilun
2025-07-15 6:32 ` [PATCH v5 2/8] iommufd: Add iommufd_object_tombstone_user() helper Xu Yilun
2025-07-15 6:32 ` [PATCH v5 3/8] iommufd: Add a pre_destroy() op for objects Xu Yilun
2025-07-15 13:19 ` Jason Gunthorpe
2025-07-15 6:32 ` [PATCH v5 4/8] iommufd: Destroy vdevice on idevice destroy Xu Yilun
2025-07-15 13:37 ` Jason Gunthorpe
2025-07-15 6:32 ` [PATCH v5 5/8] iommufd/vdevice: Remove struct device reference from struct vdevice Xu Yilun
2025-07-15 13:38 ` Jason Gunthorpe
2025-07-15 18:56 ` Nicolin Chen
2025-07-16 6:09 ` Xu Yilun
2025-07-15 20:44 ` kernel test robot
2025-07-15 6:32 ` [PATCH v5 6/8] iommufd/selftest: Explicitly skip tests for inapplicable variant Xu Yilun
2025-07-15 19:13 ` Nicolin Chen
2025-07-16 6:23 ` Xu Yilun
2025-07-15 6:32 ` [PATCH v5 7/8] iommufd/selftest: Add coverage for vdevice tombstone Xu Yilun
2025-07-15 19:03 ` Nicolin Chen
2025-07-15 6:32 ` [PATCH v5 8/8] iommufd: Rename some shortterm-related identifiers Xu Yilun
2025-07-15 13:39 ` Jason Gunthorpe
2025-07-15 19:13 ` Nicolin Chen [this message]
2025-07-15 19:33 ` [PATCH v5 0/8] iommufd: Destroy vdevice on device unbind Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHaoczqqBIhZ7k1Z@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=aik@amd.com \
--cc=aneesh.kumar@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=yilun.xu@intel.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox