* [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro
@ 2024-10-13 14:25 Abhishek Tamboli
2024-10-14 9:43 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Abhishek Tamboli @ 2024-10-13 14:25 UTC (permalink / raw)
To: gregkh
Cc: Frank.Li, m.grzeschik, dan.scally, andrzej.p, quic_jjohnson,
shuzhenwang, arakesh, skhan, rbmarliere, linux-kernel-mentees,
linux-usb, linux-kernel
Remove the extra semicolon after the
do {} while (0) in UVC_COPY_DESCRIPTOR macro.
Fix the following checkpatch.pl warning
WARNING: do {} while (0) macros should not be semicolon terminated
+#define UVC_COPY_DESCRIPTOR(mem, dst, desc) \
+ do { \
+ memcpy(mem, desc, (desc)->bLength); \
+ *(dst)++ = mem; \
+ mem += (desc)->bLength; \
+ } while (0);
Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
drivers/usb/gadget/function/f_uvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
index 40187b7112e7..edf0355d712c 100644
--- a/drivers/usb/gadget/function/f_uvc.c
+++ b/drivers/usb/gadget/function/f_uvc.c
@@ -465,7 +465,7 @@ uvc_register_video(struct uvc_device *uvc)
memcpy(mem, desc, (desc)->bLength); \
*(dst)++ = mem; \
mem += (desc)->bLength; \
- } while (0);
+ } while (0)
#define UVC_COPY_DESCRIPTORS(mem, dst, src) \
do { \
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro
2024-10-13 14:25 [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro Abhishek Tamboli
@ 2024-10-14 9:43 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2024-10-14 9:43 UTC (permalink / raw)
To: Abhishek Tamboli, gregkh
Cc: Frank.Li, m.grzeschik, dan.scally, andrzej.p, quic_jjohnson,
shuzhenwang, arakesh, skhan, rbmarliere, linux-kernel-mentees,
linux-usb, linux-kernel
Quoting Abhishek Tamboli (2024-10-13 15:25:11)
> Remove the extra semicolon after the
> do {} while (0) in UVC_COPY_DESCRIPTOR macro.
>
> Fix the following checkpatch.pl warning
>
> WARNING: do {} while (0) macros should not be semicolon terminated
> +#define UVC_COPY_DESCRIPTOR(mem, dst, desc) \
> + do { \
> + memcpy(mem, desc, (desc)->bLength); \
> + *(dst)++ = mem; \
> + mem += (desc)->bLength; \
> + } while (0);
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> drivers/usb/gadget/function/f_uvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
> index 40187b7112e7..edf0355d712c 100644
> --- a/drivers/usb/gadget/function/f_uvc.c
> +++ b/drivers/usb/gadget/function/f_uvc.c
> @@ -465,7 +465,7 @@ uvc_register_video(struct uvc_device *uvc)
> memcpy(mem, desc, (desc)->bLength); \
> *(dst)++ = mem; \
> mem += (desc)->bLength; \
> - } while (0);
> + } while (0)
>
> #define UVC_COPY_DESCRIPTORS(mem, dst, src) \
> do { \
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-14 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-13 14:25 [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro Abhishek Tamboli
2024-10-14 9:43 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox