* [PATCH v2] kselftest: x86: Improve MOV SS test result message
@ 2025-05-23 7:32 Brigham Campbell
2025-05-23 18:46 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Brigham Campbell @ 2025-05-23 7:32 UTC (permalink / raw)
To: skhan, linux-kernel-mentees, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT), H. Peter Anvin,
Shuah Khan, open list:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:KERNEL SELFTEST FRAMEWORK
Cc: Brigham Campbell
Apparently, this test completes successfully when it completes execution
without either causing a kernel panic or being killed by the kernel.
This new test result message is more descriptive and grammatically
correct.
There are no changes in v2. I'm resending this patch because I addressed
it to the wrong email for Shuah.
Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
---
tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/mov_ss_trap.c b/tools/testing/selftests/x86/mov_ss_trap.c
index f22cb6b382f9..d80033c0d7eb 100644
--- a/tools/testing/selftests/x86/mov_ss_trap.c
+++ b/tools/testing/selftests/x86/mov_ss_trap.c
@@ -269,6 +269,6 @@ int main()
);
}
- printf("[OK]\tI aten't dead\n");
+ printf("[OK]\tkernel handled MOV SS without crashing test\n");
return 0;
}
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message
2025-05-23 7:32 [PATCH v2] kselftest: x86: Improve MOV SS test result message Brigham Campbell
@ 2025-05-23 18:46 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2025-05-23 18:46 UTC (permalink / raw)
To: Brigham Campbell, linux-kernel-mentees, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT), H. Peter Anvin,
Shuah Khan, open list:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:KERNEL SELFTEST FRAMEWORK, Shuah Khan
On 5/23/25 01:32, Brigham Campbell wrote:
> Apparently, this test completes successfully when it completes execution
> without either causing a kernel panic or being killed by the kernel.
> This new test result message is more descriptive and grammatically
> correct.
>
The change log description usually is in imperative - e.g:
"Change test result message to be more descriptive and grammatically
correct.."
> There are no changes in v2. I'm resending this patch because I addressed
> it to the wrong email for Shuah.
Version change information goes under the --- after the Signed-off-by
>
> Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
> ---
> tools/testing/selftests/x86/mov_ss_trap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/mov_ss_trap.c b/tools/testing/selftests/x86/mov_ss_trap.c
> index f22cb6b382f9..d80033c0d7eb 100644
> --- a/tools/testing/selftests/x86/mov_ss_trap.c
> +++ b/tools/testing/selftests/x86/mov_ss_trap.c
> @@ -269,6 +269,6 @@ int main()
> );
> }
>
> - printf("[OK]\tI aten't dead\n");
> + printf("[OK]\tkernel handled MOV SS without crashing test\n");
> return 0;
> }
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-23 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-23 7:32 [PATCH v2] kselftest: x86: Improve MOV SS test result message Brigham Campbell
2025-05-23 18:46 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox