* [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()
@ 2025-05-03 21:18 James Flowers
2025-05-05 16:02 ` Alex Hung
0 siblings, 1 reply; 4+ messages in thread
From: James Flowers @ 2025-05-03 21:18 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, siqueira, alexander.deucher,
christian.koenig, airlied, simona, alvin.lee2, zaeem.mohamed,
alex.hung, skhan
Cc: James Flowers, amd-gfx, dri-devel, linux-kernel,
linux-kernel-mentees
Adds kernel-doc for externally linked dc_stream_remove_writeback function.
Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
---
V1 -> V2: Corrected checkpatch warnings and errors
drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
index e6e41678525f..b883fb24fa12 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
@@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
return true;
}
+/**
+ * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
+ * @dc: Display core control structure.
+ * @stream: Display core stream state.
+ * @dwb_pipe_inst: Display writeback pipe.
+ *
+ * Return: returns true on success, false otherwise.
+ */
bool dc_stream_remove_writeback(struct dc *dc,
struct dc_stream_state *stream,
uint32_t dwb_pipe_inst)
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()
2025-05-03 21:18 [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback() James Flowers
@ 2025-05-05 16:02 ` Alex Hung
2025-05-20 2:06 ` James
0 siblings, 1 reply; 4+ messages in thread
From: Alex Hung @ 2025-05-05 16:02 UTC (permalink / raw)
To: James Flowers, harry.wentland, sunpeng.li, siqueira,
alexander.deucher, christian.koenig, airlied, simona, alvin.lee2,
zaeem.mohamed, skhan
Cc: amd-gfx, dri-devel, linux-kernel, linux-kernel-mentees
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 5/3/25 15:18, James Flowers wrote:
> Adds kernel-doc for externally linked dc_stream_remove_writeback function.
>
> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
> ---
> V1 -> V2: Corrected checkpatch warnings and errors
>
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index e6e41678525f..b883fb24fa12 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
> return true;
> }
>
> +/**
> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
> + * @dc: Display core control structure.
> + * @stream: Display core stream state.
> + * @dwb_pipe_inst: Display writeback pipe.
> + *
> + * Return: returns true on success, false otherwise.
> + */
> bool dc_stream_remove_writeback(struct dc *dc,
> struct dc_stream_state *stream,
> uint32_t dwb_pipe_inst)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()
2025-05-05 16:02 ` Alex Hung
@ 2025-05-20 2:06 ` James
2025-05-20 15:28 ` Alex Hung
0 siblings, 1 reply; 4+ messages in thread
From: James @ 2025-05-20 2:06 UTC (permalink / raw)
To: Alex Hung, Harry Wentland, sunpeng.li, Rodrigo Siqueira,
Alex Deucher, Christian König, airlied, simona, alvin.lee2,
zaeem.mohamed, Shuah Khan
Cc: amd-gfx, dri-devel, linux-kernel, linux-kernel-mentees
On Mon, May 5, 2025, at 9:02 AM, Alex Hung wrote:
> Reviewed-by: Alex Hung <alex.hung@amd.com>
>
> On 5/3/25 15:18, James Flowers wrote:
>> Adds kernel-doc for externally linked dc_stream_remove_writeback function.
>>
>> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
>> ---
>> V1 -> V2: Corrected checkpatch warnings and errors
>>
>> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>> index e6e41678525f..b883fb24fa12 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>> @@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
>> return true;
>> }
>>
>> +/**
>> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
>> + * @dc: Display core control structure.
>> + * @stream: Display core stream state.
>> + * @dwb_pipe_inst: Display writeback pipe.
>> + *
>> + * Return: returns true on success, false otherwise.
>> + */
>> bool dc_stream_remove_writeback(struct dc *dc,
>> struct dc_stream_state *stream,
>> uint32_t dwb_pipe_inst)
Hi,
I am just following up on this to see if it’s been applied, or if any adjustments are still needed.
Best regards,
James Flowers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()
2025-05-20 2:06 ` James
@ 2025-05-20 15:28 ` Alex Hung
0 siblings, 0 replies; 4+ messages in thread
From: Alex Hung @ 2025-05-20 15:28 UTC (permalink / raw)
To: James, Harry Wentland, sunpeng.li, Rodrigo Siqueira, Alex Deucher,
Christian König, airlied, simona, alvin.lee2, zaeem.mohamed,
Shuah Khan
Cc: amd-gfx, dri-devel, linux-kernel, linux-kernel-mentees
On 5/19/25 20:06, James wrote:
>
>
> On Mon, May 5, 2025, at 9:02 AM, Alex Hung wrote:
>> Reviewed-by: Alex Hung <alex.hung@amd.com>
>>
>> On 5/3/25 15:18, James Flowers wrote:
>>> Adds kernel-doc for externally linked dc_stream_remove_writeback function.
>>>
>>> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
>>> ---
>>> V1 -> V2: Corrected checkpatch warnings and errors
>>>
>>> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> index e6e41678525f..b883fb24fa12 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
>>> @@ -569,6 +569,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
>>> return true;
>>> }
>>>
>>> +/**
>>> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
>>> + * @dc: Display core control structure.
>>> + * @stream: Display core stream state.
>>> + * @dwb_pipe_inst: Display writeback pipe.
>>> + *
>>> + * Return: returns true on success, false otherwise.
>>> + */
>>> bool dc_stream_remove_writeback(struct dc *dc,
>>> struct dc_stream_state *stream,
>>> uint32_t dwb_pipe_inst)
>
> Hi,
>
> I am just following up on this to see if it’s been applied, or if any adjustments are still needed.
It's in amd-staging-drm-next:
https://gitlab.freedesktop.org/agd5f/linux/-/commit/04abe7201d51a094d0edd3e00399a8afa2cd2d4f
>
> Best regards,
> James Flowers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-20 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-03 21:18 [PATCH v2] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback() James Flowers
2025-05-05 16:02 ` Alex Hung
2025-05-20 2:06 ` James
2025-05-20 15:28 ` Alex Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox