public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: "Hanne-Lotta Mäenpää" <hannelotta@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	mchehab@kernel.org, ribalda@chromium.org, hverkuil@xs4all.nl,
	hljunggr@cisco.com, dave.jiang@intel.com, jgg@ziepe.ca,
	saeedm@nvidia.com, Jonathan.Cameron@huawei.com,
	ilpo.jarvinen@linux.intel.com, mario.limonciello@amd.com,
	W_Armin@gmx.de, mpearson-lenovo@squebb.ca
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH 2/4] docs: Improve grammar, formatting in Video4Linux
Date: Wed, 21 May 2025 18:17:37 +0300	[thread overview]
Message-ID: <b6954169-63d9-4cac-aabd-2df1642f98af@gmail.com> (raw)
In-Reply-To: <aCqIAkoVr2yvDJbN@archie.me>

Hello,

On 5/19/25 04:23, Bagas Sanjaya wrote:
> On Sun, May 18, 2025 at 02:08:04AM -0600, Jonathan Corbet wrote:
>>>       description of the correct character encoding for Programme Service
>>>       name strings. Also from RDS specification, PS is usually a single
>>>       eight character text. However, it is also possible to find receivers
>>> -    which can scroll strings sized as 8 x N characters. So, this control
>>> +    which can scroll strings sized as 8 x N characters. Therefore this control
>>
>> This kind of change just seems like churn that isn't really improving
>> the content?
> 
> I prefer the original as both so and therefore have the same meaning.>
>>>   ``V4L2_CID_RDS_TX_ALT_FREQS (__u32 array)``
>>>       The alternate frequencies in kHz units. The RDS standard allows for
>>> -    up to 25 frequencies to be defined. Drivers may support fewer
>>> -    frequencies so check the array size.
>>> +    up to 25 frequencies to be defined. Because drivers may support fewer
>>> +    frequencies, check the array size.
>>
>> Here too, I'm not sure I see the value in this kind of change.
> 
> Again I'm agree.
> 
> Thanks.
> 

Alright, that is two opinions in favor of not changing this. I can send 
a version 2 of this patch series without these.

Thank you for reviewing!

Best regards,

Hanne-Lotta Mäenpää

  reply	other threads:[~2025-05-21 15:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-17 13:27 [PATCH 1/4] docs: Improve grammar in Userspace API/DVB API Hanne-Lotta Mäenpää
2025-05-17 13:27 ` [PATCH 2/4] docs: Improve grammar, formatting in Video4Linux Hanne-Lotta Mäenpää
2025-05-18  8:08   ` Jonathan Corbet
2025-05-19  1:23     ` Bagas Sanjaya
2025-05-21 15:17       ` Hanne-Lotta Mäenpää [this message]
2025-05-21 15:12     ` Hanne-Lotta Mäenpää
2025-05-17 13:27 ` [PATCH 3/4] docs: Improve grammar in Userspace API/fwctl Hanne-Lotta Mäenpää
2025-05-19  1:32   ` Bagas Sanjaya
2025-05-19 13:01     ` Ilpo Järvinen
2025-05-21  2:48       ` Bagas Sanjaya
2025-05-21 15:38     ` Hanne-Lotta Mäenpää
2025-05-17 13:27 ` [PATCH 4/4] docs: Fix typos, improve grammar in Userspace API Hanne-Lotta Mäenpää
2025-05-19  1:24   ` Bagas Sanjaya
2025-05-19  1:49   ` Mark Pearson
2025-05-19  1:34 ` [PATCH 1/4] docs: Improve grammar in Userspace API/DVB API Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6954169-63d9-4cac-aabd-2df1642f98af@gmail.com \
    --to=hannelotta@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=W_Armin@gmx.de \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dave.jiang@intel.com \
    --cc=hljunggr@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mchehab@kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=ribalda@chromium.org \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox