Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: mhiramat at kernel.org (Masami Hiramatsu)
Subject: [PATCH v5 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Thu,  8 Mar 2018 17:46:59 +0900	[thread overview]
Message-ID: <152049881961.7289.7652284231051413170.stgit@devbox> (raw)
In-Reply-To: <152049860385.7289.14079393589900496424.stgit@devbox>

Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.

Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
 kernel/trace/trace_probe.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 049e8531fdf8..51ca8f751332 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
 	trace_seq_printf(s, fmt, *(type *)data);			\
 	return !trace_seq_has_overflowed(s);				\
 }									\
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;				\
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
 
 DEFINE_BASIC_PRINT_TYPE_FUNC(u8,  u8,  "%u")
 DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
 				 (const char *)get_loc_data(data, ent));
 	return !trace_seq_has_overflowed(s);
 }
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
 
 const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH v5 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions
Date: Thu,  8 Mar 2018 17:46:59 +0900	[thread overview]
Message-ID: <152049881961.7289.7652284231051413170.stgit@devbox> (raw)
Message-ID: <20180308084659.DchkTgLe4PKiK3P9ouKs-egBQb2_YIv-h82fhdD7tHk@z> (raw)
In-Reply-To: <152049860385.7289.14079393589900496424.stgit@devbox>

Remove unneeded NOKPROBE_SYMBOL from print functions since
the print functions are only used when printing out the
trace data, and not from kprobe handler.

Signed-off-by: Masami Hiramatsu <mhiramat at kernel.org>
---
 kernel/trace/trace_probe.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
index 049e8531fdf8..51ca8f751332 100644
--- a/kernel/trace/trace_probe.c
+++ b/kernel/trace/trace_probe.c
@@ -43,8 +43,7 @@ int PRINT_TYPE_FUNC_NAME(tname)(struct trace_seq *s, void *data, void *ent)\
 	trace_seq_printf(s, fmt, *(type *)data);			\
 	return !trace_seq_has_overflowed(s);				\
 }									\
-const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;				\
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(tname));
+const char PRINT_TYPE_FMT_NAME(tname)[] = fmt;
 
 DEFINE_BASIC_PRINT_TYPE_FUNC(u8,  u8,  "%u")
 DEFINE_BASIC_PRINT_TYPE_FUNC(u16, u16, "%u")
@@ -71,7 +70,6 @@ int PRINT_TYPE_FUNC_NAME(string)(struct trace_seq *s, void *data, void *ent)
 				 (const char *)get_loc_data(data, ent));
 	return !trace_seq_has_overflowed(s);
 }
-NOKPROBE_SYMBOL(PRINT_TYPE_FUNC_NAME(string));
 
 const char PRINT_TYPE_FMT_NAME(string)[] = "\\\"%s\\\"";
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-03-08  8:46 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  8:43 [PATCH v5 00/19] tracing: probeevent: Improve fetcharg features mhiramat
2018-03-08  8:43 ` Masami Hiramatsu
2018-03-08  8:44 ` [PATCH v5 01/19] [BUGFIX] tracing: probeevent: Fix to support minus offset from symbol mhiramat
2018-03-08  8:44   ` Masami Hiramatsu
2018-03-08  8:44 ` [PATCH v5 02/19] selftests: ftrace: Add probe event argument syntax testcase mhiramat
2018-03-08  8:44   ` Masami Hiramatsu
2018-03-08  8:45 ` [PATCH v5 03/19] selftests: ftrace: Add a testcase for string type with kprobe_event mhiramat
2018-03-08  8:45   ` Masami Hiramatsu
2018-03-08  8:45 ` [PATCH v5 04/19] selftests: ftrace: Add a testcase for probepoint mhiramat
2018-03-08  8:45   ` Masami Hiramatsu
2018-03-08  8:46 ` [PATCH v5 05/19] tracing: probeevent: Cleanup print argument functions mhiramat
2018-03-08  8:46   ` Masami Hiramatsu
2018-03-08  8:46 ` [PATCH v5 06/19] tracing: probeevent: Cleanup argument field definition mhiramat
2018-03-08  8:46   ` Masami Hiramatsu
2018-03-08  8:46 ` mhiramat [this message]
2018-03-08  8:46   ` [PATCH v5 07/19] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions Masami Hiramatsu
2018-03-08  8:47 ` [PATCH v5 08/19] tracing: probeevent: Introduce new argument fetching code mhiramat
2018-03-08  8:47   ` Masami Hiramatsu
2018-03-08  8:47 ` [PATCH v5 09/19] tracing: probeevent: Unify fetch type tables mhiramat
2018-03-08  8:47   ` Masami Hiramatsu
2018-03-08  8:47 ` [PATCH v5 10/19] tracing: probeevent: Return consumed bytes of dynamic area mhiramat
2018-03-08  8:47   ` Masami Hiramatsu
2018-03-08  8:48 ` [PATCH v5 11/19] tracing: probeevent: Append traceprobe_ for exported function mhiramat
2018-03-08  8:48   ` Masami Hiramatsu
2018-03-08  8:48 ` [PATCH v5 12/19] tracing: probeevent: Unify fetch_insn processing common part mhiramat
2018-03-08  8:48   ` Masami Hiramatsu
2018-03-08  8:49 ` [PATCH v5 13/19] tracing: probeevent: Add symbol type mhiramat
2018-03-08  8:49   ` Masami Hiramatsu
2018-03-08  8:49 ` [PATCH v5 14/19] x86: ptrace: Add function argument access API mhiramat
2018-03-08  8:49   ` Masami Hiramatsu
2018-03-08  8:50 ` [PATCH v5 15/19] tracing: probeevent: Add $argN for accessing function args mhiramat
2018-03-08  8:50   ` Masami Hiramatsu
2018-03-08  8:50 ` [PATCH v5 16/19] tracing: probeevent: Add array type support mhiramat
2018-03-08  8:50   ` Masami Hiramatsu
2018-03-15  5:48   ` ravi.bangoria
2018-03-15  5:48     ` Ravi Bangoria
2018-03-15  7:18     ` mhiramat
2018-03-15  7:18       ` Masami Hiramatsu
2018-03-15  7:23       ` mhiramat
2018-03-15  7:23         ` Masami Hiramatsu
2018-03-15  8:01         ` ravi.bangoria
2018-03-15  8:01           ` Ravi Bangoria
2018-03-16 14:48   ` mhiramat
2018-03-16 14:48     ` Masami Hiramatsu
2018-03-08  8:51 ` [PATCH v5 17/19] selftests: ftrace: Add a testcase for symbol type mhiramat
2018-03-08  8:51   ` Masami Hiramatsu
2018-03-08  8:51 ` [PATCH v5 18/19] selftests: ftrace: Add a testcase for $argN with kprobe_event mhiramat
2018-03-08  8:51   ` Masami Hiramatsu
2018-03-08  8:52 ` [PATCH v5 19/19] selftests: ftrace: Add a testcase for array type " mhiramat
2018-03-08  8:52   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152049881961.7289.7652284231051413170.stgit@devbox \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox