From: rostedt at goodmis.org (Steven Rostedt)
Subject: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations
Date: Fri, 10 May 2019 10:54:00 -0400 [thread overview]
Message-ID: <20190510105400.0d267e9f@gandalf.local.home> (raw)
In-Reply-To: <20190510121720.GT2589@hirez.programming.kicks-ass.net>
On Fri, 10 May 2019 14:17:20 +0200
Peter Zijlstra <peterz at infradead.org> wrote:
> But both ftrace and retprobes are at C function call boundaries.
> Preserving flags doesn't make sense.
I agree, but I did it just because of my OCD and being complete in
"emulating an int3" for ftrace_regs_caller ;-)
Yeah, we can remove the popfl from the ftrace trampoline.
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: rostedt@goodmis.org (Steven Rostedt)
Subject: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations
Date: Fri, 10 May 2019 10:54:00 -0400 [thread overview]
Message-ID: <20190510105400.0d267e9f@gandalf.local.home> (raw)
Message-ID: <20190510145400.s1yN3qbzzfE3tgJ4Vm39_Ajcl_QQjdwt-EKuLFk3924@z> (raw)
In-Reply-To: <20190510121720.GT2589@hirez.programming.kicks-ass.net>
On Fri, 10 May 2019 14:17:20 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> But both ftrace and retprobes are at C function call boundaries.
> Preserving flags doesn't make sense.
I agree, but I did it just because of my OCD and being complete in
"emulating an int3" for ftrace_regs_caller ;-)
Yeah, we can remove the popfl from the ftrace trampoline.
-- Steve
next prev parent reply other threads:[~2019-05-10 14:54 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 7:49 [PATCH 0/4] x86: int3 fallout peterz
2019-05-08 7:49 ` Peter Zijlstra
2019-05-08 7:49 ` [PATCH 1/4] x86/entry/32: Clean up return from interrupt preemption path peterz
2019-05-08 7:49 ` Peter Zijlstra
2019-05-08 7:49 ` [PATCH 2/4] x86/kprobes: Fix frame pointer annotations peterz
2019-05-08 7:49 ` Peter Zijlstra
2019-05-08 11:54 ` jpoimboe
2019-05-08 11:54 ` Josh Poimboeuf
2019-05-08 12:04 ` peterz
2019-05-08 12:04 ` Peter Zijlstra
[not found] ` <20190508124248.u5ukpbhnh4wpiccq@treble>
[not found] ` <20190508153907.GM2589@hirez.programming.kicks-ass.net>
2019-05-08 18:48 ` jpoimboe
2019-05-08 18:48 ` Josh Poimboeuf
2019-05-09 1:20 ` mhiramat
2019-05-09 1:20 ` Masami Hiramatsu
2019-05-09 8:14 ` peterz
2019-05-09 8:14 ` Peter Zijlstra
2019-05-09 9:27 ` peterz
2019-05-09 9:27 ` Peter Zijlstra
2019-05-09 14:00 ` jpoimboe
2019-05-09 14:00 ` Josh Poimboeuf
2019-05-09 14:01 ` mhiramat
2019-05-09 14:01 ` Masami Hiramatsu
2019-05-09 17:14 ` peterz
2019-05-09 17:14 ` Peter Zijlstra
2019-05-10 4:58 ` mhiramat
2019-05-10 4:58 ` Masami Hiramatsu
2019-05-10 12:31 ` peterz
2019-05-10 12:31 ` Peter Zijlstra
2019-05-11 0:52 ` mhiramat
2019-05-11 0:52 ` Masami Hiramatsu
2019-05-10 12:40 ` peterz
2019-05-10 12:40 ` Peter Zijlstra
2019-05-11 0:56 ` mhiramat
2019-05-11 0:56 ` Masami Hiramatsu
2019-05-13 8:15 ` peterz
2019-05-13 8:15 ` Peter Zijlstra
2019-05-09 16:20 ` luto
2019-05-09 16:20 ` Andy Lutomirski
2019-05-09 17:18 ` peterz
2019-05-09 17:18 ` Peter Zijlstra
2019-05-09 17:43 ` rostedt
2019-05-09 17:43 ` Steven Rostedt
2019-05-10 3:21 ` mhiramat
2019-05-10 3:21 ` Masami Hiramatsu
2019-05-10 12:14 ` peterz
2019-05-10 12:14 ` Peter Zijlstra
2019-05-10 12:17 ` peterz
2019-05-10 12:17 ` Peter Zijlstra
2019-05-10 14:54 ` rostedt [this message]
2019-05-10 14:54 ` Steven Rostedt
2019-05-09 17:37 ` rostedt
2019-05-09 17:37 ` Steven Rostedt
2019-05-09 18:26 ` peterz
2019-05-09 18:26 ` Peter Zijlstra
2019-05-09 18:36 ` rostedt
2019-05-09 18:36 ` Steven Rostedt
2019-05-08 7:49 ` [PATCH 3/4] x86/ftrace: Add pt_regs frame annotations peterz
2019-05-08 7:49 ` Peter Zijlstra
2019-05-08 7:49 ` [RFC][PATCH 4/4] x86_32: Provide consistent pt_regs peterz
2019-05-08 7:49 ` Peter Zijlstra
2019-05-08 11:57 ` jpoimboe
2019-05-08 11:57 ` Josh Poimboeuf
2019-05-08 20:58 ` torvalds
2019-05-08 20:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510105400.0d267e9f@gandalf.local.home \
--to=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox