From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org,
"Reinette Chatre" <reinette.chatre@intel.com>,
"Shuah Khan" <shuah@kernel.org>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
"Fenghua Yu" <fenghua.yu@intel.com>
Cc: linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 26/26] selftests/resctrl: Add test groups and name L3 CAT test L3_CAT
Date: Mon, 20 Nov 2023 13:13:40 +0200 [thread overview]
Message-ID: <20231120111340.7805-27-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20231120111340.7805-1-ilpo.jarvinen@linux.intel.com>
To select test to run -t parameter can be used. However, -t cat
currently maps to L3 CAT test which is confusing after more CAT related
tests are added.
Allow selecting tests as groups and call L3 CAT test "L3_CAT", "CAT"
group will enable all CAT related tests.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
tools/testing/selftests/resctrl/cat_test.c | 3 ++-
tools/testing/selftests/resctrl/resctrl.h | 2 ++
tools/testing/selftests/resctrl/resctrl_tests.c | 16 +++++++++++-----
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
index 293b42ccd39f..869fd280c993 100644
--- a/tools/testing/selftests/resctrl/cat_test.c
+++ b/tools/testing/selftests/resctrl/cat_test.c
@@ -289,7 +289,8 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
}
struct resctrl_test l3_cat_test = {
- .name = "CAT",
+ .name = "L3_CAT",
+ .group = "CAT",
.resource = "L3",
.feature_check = test_resource_feature_check,
.run_test = cat_run_test,
diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
index 9b49065cc6da..2f0fa8a604e6 100644
--- a/tools/testing/selftests/resctrl/resctrl.h
+++ b/tools/testing/selftests/resctrl/resctrl.h
@@ -60,6 +60,7 @@ struct user_params {
/*
* resctrl_test: resctrl test definition
* @name: Test name
+ * @group: Test group (e.g., L2 and L3 CAT test belong to CAT group), can be NULL
* @resource: Resource to test (e.g., MB, L3, L2, etc.)
* @vendor_specific: Bitmask for vendor-specific tests (can be 0 for universal tests)
* @disabled: Test is disabled
@@ -68,6 +69,7 @@ struct user_params {
*/
struct resctrl_test {
const char *name;
+ const char *group;
const char *resource;
unsigned int vendor_specific;
bool disabled;
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index fec677d41cf4..3d8fd1d3ca43 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -65,11 +65,15 @@ static void cmd_help(void)
printf("usage: resctrl_tests [-h] [-t test list] [-n no_of_bits] [-b benchmark_cmd [option]...]\n");
printf("\t-b benchmark_cmd [option]...: run specified benchmark for MBM, MBA and CMT\n");
printf("\t default benchmark is builtin fill_buf\n");
- printf("\t-t test list: run tests specified in the test list, ");
+ printf("\t-t test list: run tests/groups specified by the list, ");
printf("e.g. -t mbm,mba,cmt,cat\n");
- printf("\t\tSupported tests:\n");
- for (i = 0; i < ARRAY_SIZE(resctrl_tests); i++)
- printf("\t\t\t%s\n", resctrl_tests[i]->name);
+ printf("\t\tSupported tests (group):\n");
+ for (i = 0; i < ARRAY_SIZE(resctrl_tests); i++) {
+ if (resctrl_tests[i]->group)
+ printf("\t\t\t%s (%s)\n", resctrl_tests[i]->name, resctrl_tests[i]->group);
+ else
+ printf("\t\t\t%s\n", resctrl_tests[i]->name);
+ }
printf("\t-n no_of_bits: run cache tests using specified no of bits in cache bit mask\n");
printf("\t-p cpu_no: specify CPU number to run the test. 1 is default\n");
printf("\t-h: help\n");
@@ -197,7 +201,9 @@ int main(int argc, char **argv)
bool found = false;
for (i = 0; i < ARRAY_SIZE(resctrl_tests); i++) {
- if (!strcasecmp(token, resctrl_tests[i]->name)) {
+ if (!strcasecmp(token, resctrl_tests[i]->name) ||
+ (resctrl_tests[i]->group &&
+ !strcasecmp(token, resctrl_tests[i]->group))) {
if (resctrl_tests[i]->disabled)
tests++;
resctrl_tests[i]->disabled = false;
--
2.30.2
next prev parent reply other threads:[~2023-11-20 11:17 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 11:13 [PATCH v2 00/26] selftests/resctrl: CAT test improvements & generalized test framework Ilpo Järvinen
2023-11-20 11:13 ` [PATCH v2 01/26] selftests/resctrl: Don't use ctrlc_handler() outside signal handling Ilpo Järvinen
2023-11-28 22:09 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 02/26] selftests/resctrl: Split fill_buf to allow tests finer-grained control Ilpo Järvinen
2023-11-28 22:10 ` Reinette Chatre
2023-12-07 14:04 ` Ilpo Järvinen
2023-11-20 11:13 ` [PATCH v2 03/26] selftests/resctrl: Refactor fill_buf functions Ilpo Järvinen
2023-11-28 22:10 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 04/26] selftests/resctrl: Refactor get_cbm_mask() and rename to get_full_cbm() Ilpo Järvinen
2023-11-28 22:11 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 05/26] selftests/resctrl: Mark get_cache_size() cache_type const Ilpo Järvinen
2023-11-28 22:11 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 06/26] selftests/resctrl: Create cache_portion_size() helper Ilpo Järvinen
2023-11-28 22:11 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 07/26] selftests/resctrl: Exclude shareable bits from schemata in CAT test Ilpo Järvinen
2023-11-28 22:12 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 08/26] selftests/resctrl: Split measure_cache_vals() Ilpo Järvinen
2023-11-28 22:13 ` Reinette Chatre
2023-12-07 14:32 ` Ilpo Järvinen
2023-12-07 18:02 ` Reinette Chatre
2023-12-07 18:33 ` Ilpo Järvinen
2023-12-07 18:35 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 09/26] selftests/resctrl: Split show_cache_info() to test specific and generic parts Ilpo Järvinen
2023-11-28 22:13 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 10/26] selftests/resctrl: Remove unnecessary __u64 -> unsigned long conversion Ilpo Järvinen
2023-11-28 22:14 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 11/26] selftests/resctrl: Remove nested calls in perf event handling Ilpo Järvinen
2023-11-28 22:15 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 12/26] selftests/resctrl: Consolidate naming of perf event related things Ilpo Järvinen
2023-11-28 22:15 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 13/26] selftests/resctrl: Improve perf init Ilpo Järvinen
2023-11-28 22:15 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 14/26] selftests/resctrl: Convert perf related globals to locals Ilpo Järvinen
2023-11-28 22:15 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 15/26] selftests/resctrl: Move cat_val() to cat_test.c and rename to cat_test() Ilpo Järvinen
2023-11-28 22:15 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 16/26] selftests/resctrl: Open perf fd before start & add error handling Ilpo Järvinen
2023-11-28 22:16 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 17/26] selftests/resctrl: Replace file write with volatile variable Ilpo Järvinen
2023-11-28 22:16 ` Reinette Chatre
2023-12-07 15:03 ` Ilpo Järvinen
2023-11-20 11:13 ` [PATCH v2 18/26] selftests/resctrl: Read in less obvious order to defeat prefetch optimizations Ilpo Järvinen
2023-11-28 22:17 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 19/26] selftests/resctrl: Rewrite Cache Allocation Technology (CAT) test Ilpo Järvinen
2023-11-28 22:17 ` Reinette Chatre
2023-12-07 15:18 ` Ilpo Järvinen
2023-11-20 11:13 ` [PATCH v2 20/26] selftests/resctrl: Create struct for input parameters Ilpo Järvinen
2023-11-28 22:18 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 21/26] selftests/resctrl: Introduce generalized test framework Ilpo Järvinen
2023-11-28 22:19 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 22/26] selftests/resctrl: Pass write_schemata() resource instead of test name Ilpo Järvinen
2023-11-28 22:19 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 23/26] selftests/resctrl: Add helper to convert L2/3 to integer Ilpo Järvinen
2023-11-28 22:22 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 24/26] selftests/resctrl: Rename resource ID to domain ID Ilpo Järvinen
2023-11-28 22:22 ` Reinette Chatre
2023-11-20 11:13 ` [PATCH v2 25/26] selftests/resctrl: Get domain id from cache id Ilpo Järvinen
2023-11-28 22:22 ` Reinette Chatre
2023-11-20 11:13 ` Ilpo Järvinen [this message]
2023-11-28 22:22 ` [PATCH v2 26/26] selftests/resctrl: Add test groups and name L3 CAT test L3_CAT Reinette Chatre
2023-11-29 11:11 ` Ilpo Järvinen
2023-11-30 7:36 ` Maciej Wieczór-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120111340.7805-27-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox