Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Amit Daniel Kachhap <amit.kachhap@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: [PATCH 3/8] kselftest/arm64: mte: use proper SKIP syntax
Date: Fri, 16 Aug 2024 16:32:46 +0100	[thread overview]
Message-ID: <20240816153251.2833702-4-andre.przywara@arm.com> (raw)
In-Reply-To: <20240816153251.2833702-1-andre.przywara@arm.com>

If MTE is not available on a system, we detect this early and skip all
the MTE selftests. However this happens before we print the TAP plan, so
tools parsing the TAP output get confused and report an error.

Use the existing ksft_exit_skip() function to handle this, which uses a
dummy plan to work with tools expecting proper TAP syntax, as described
in the TAP specification.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 tools/testing/selftests/arm64/mte/mte_common_util.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b/tools/testing/selftests/arm64/mte/mte_common_util.c
index 00ffd34c66d30..69e4a67853c40 100644
--- a/tools/testing/selftests/arm64/mte/mte_common_util.c
+++ b/tools/testing/selftests/arm64/mte/mte_common_util.c
@@ -319,10 +319,9 @@ int mte_default_setup(void)
 	unsigned long en = 0;
 	int ret;
 
-	if (!(hwcaps2 & HWCAP2_MTE)) {
-		ksft_print_msg("SKIP: MTE features unavailable\n");
-		return KSFT_SKIP;
-	}
+	if (!(hwcaps2 & HWCAP2_MTE))
+		ksft_exit_skip("MTE features unavailable\n");
+
 	/* Get current mte mode */
 	ret = prctl(PR_GET_TAGGED_ADDR_CTRL, en, 0, 0, 0);
 	if (ret < 0) {
-- 
2.25.1


  parent reply	other threads:[~2024-08-16 15:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 15:32 [PATCH 0/8] kselftest/arm64: various compilation fixes Andre Przywara
2024-08-16 15:32 ` [PATCH 1/8] kselftest/arm64: signal: drop now redundant GNU_SOURCE definition Andre Przywara
2024-08-16 16:24   ` Mark Brown
2024-08-16 15:32 ` [PATCH 2/8] kselftest/arm64: hwcap: fix f8dp2 cpuinfo name Andre Przywara
2024-08-16 16:24   ` Mark Brown
2024-08-16 15:32 ` Andre Przywara [this message]
2024-08-16 16:25   ` [PATCH 3/8] kselftest/arm64: mte: use proper SKIP syntax Mark Brown
2024-08-16 15:32 ` [PATCH 4/8] kselftest/arm64: mte: use string literal for printf-style functions Andre Przywara
2024-08-16 16:26   ` Mark Brown
2024-08-16 15:32 ` [PATCH 5/8] kselftest/arm64: mte: fix printf type warning about mask Andre Przywara
2024-08-16 16:30   ` Mark Brown
2024-08-16 16:55     ` Andre Przywara
2024-08-16 17:07       ` Mark Brown
2024-08-16 15:32 ` [PATCH 6/8] kselftest/arm64: mte: fix printf type warnings about __u64 Andre Przywara
2024-08-16 16:31   ` Mark Brown
2024-08-16 15:32 ` [PATCH 7/8] kselftest/arm64: mte: fix printf type warnings about pointers Andre Przywara
2024-08-16 16:32   ` Mark Brown
2024-08-16 16:59     ` Andre Przywara
2024-08-16 17:12       ` Mark Brown
2024-08-16 15:32 ` [PATCH 8/8] kselftest/arm64: mte: fix printf type warnings about longs Andre Przywara
2024-08-16 16:33   ` Mark Brown
2024-10-17 17:59 ` (subset) [PATCH 0/8] kselftest/arm64: various compilation fixes Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240816153251.2833702-4-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=amit.kachhap@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox