From: Andre Przywara <andre.przywara@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 7/8] kselftest/arm64: mte: fix printf type warnings about pointers
Date: Fri, 16 Aug 2024 17:59:08 +0100 [thread overview]
Message-ID: <20240816175908.5f4721eb@donnerap.manchester.arm.com> (raw)
In-Reply-To: <f7d77597-cba6-42ee-9b50-ac4b7984aff8@sirena.org.uk>
On Fri, 16 Aug 2024 17:32:39 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Fri, Aug 16, 2024 at 04:32:50PM +0100, Andre Przywara wrote:
> > When printing the value of a pointer, we should not use an integer
> > format specifier, but the dedicated "%p" instead.
> >
> > Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory")
>
> This is another one where calling it a fix seems like it's pushing it,
> it's a modernisation rather than a correctness thing.
Well, I get compiler warnings, so I thought "fix" would be adequate. But
in general this confusion between pointers and integers sounds not good,
and not using %p looks like a genuine bug to me (though it's admittedly
working fine (TM) for now).
> Otherwise
>
> Reviewed-by: Mark Brown <broonie@kernel.org>
Thanks for that!
Cheers,
Andre
next prev parent reply other threads:[~2024-08-16 16:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 15:32 [PATCH 0/8] kselftest/arm64: various compilation fixes Andre Przywara
2024-08-16 15:32 ` [PATCH 1/8] kselftest/arm64: signal: drop now redundant GNU_SOURCE definition Andre Przywara
2024-08-16 16:24 ` Mark Brown
2024-08-16 15:32 ` [PATCH 2/8] kselftest/arm64: hwcap: fix f8dp2 cpuinfo name Andre Przywara
2024-08-16 16:24 ` Mark Brown
2024-08-16 15:32 ` [PATCH 3/8] kselftest/arm64: mte: use proper SKIP syntax Andre Przywara
2024-08-16 16:25 ` Mark Brown
2024-08-16 15:32 ` [PATCH 4/8] kselftest/arm64: mte: use string literal for printf-style functions Andre Przywara
2024-08-16 16:26 ` Mark Brown
2024-08-16 15:32 ` [PATCH 5/8] kselftest/arm64: mte: fix printf type warning about mask Andre Przywara
2024-08-16 16:30 ` Mark Brown
2024-08-16 16:55 ` Andre Przywara
2024-08-16 17:07 ` Mark Brown
2024-08-16 15:32 ` [PATCH 6/8] kselftest/arm64: mte: fix printf type warnings about __u64 Andre Przywara
2024-08-16 16:31 ` Mark Brown
2024-08-16 15:32 ` [PATCH 7/8] kselftest/arm64: mte: fix printf type warnings about pointers Andre Przywara
2024-08-16 16:32 ` Mark Brown
2024-08-16 16:59 ` Andre Przywara [this message]
2024-08-16 17:12 ` Mark Brown
2024-08-16 15:32 ` [PATCH 8/8] kselftest/arm64: mte: fix printf type warnings about longs Andre Przywara
2024-08-16 16:33 ` Mark Brown
2024-10-17 17:59 ` (subset) [PATCH 0/8] kselftest/arm64: various compilation fixes Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816175908.5f4721eb@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=amit.kachhap@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox