From: Andre Przywara <andre.przywara@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Amit Daniel Kachhap <amit.kachhap@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: [PATCH 5/8] kselftest/arm64: mte: fix printf type warning about mask
Date: Fri, 16 Aug 2024 16:32:48 +0100 [thread overview]
Message-ID: <20240816153251.2833702-6-andre.przywara@arm.com> (raw)
In-Reply-To: <20240816153251.2833702-1-andre.przywara@arm.com>
When masking the return value of a prctl, which is clearly an "int", we
use a uapi header provided mask, which is defined using an "UL" modifier,
so the whole expression is promoted to a long. This upsets the compiler's
printf type checker, because we use "%x" in the format string.
While we could simply upgrade this to a "%lx", it sounds wrong to
promote the "ret" variable, that is clearly an int.
Downcast the mask instead, to keep the type correct.
Fixes: e2d9642a5a51 ("kselftest/arm64: Add simple test for MTE prctl")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
tools/testing/selftests/arm64/mte/check_prctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/arm64/mte/check_prctl.c b/tools/testing/selftests/arm64/mte/check_prctl.c
index f139a33a43ef4..a16d7005affdf 100644
--- a/tools/testing/selftests/arm64/mte/check_prctl.c
+++ b/tools/testing/selftests/arm64/mte/check_prctl.c
@@ -81,11 +81,11 @@ void set_mode_test(const char *name, int hwcap2, int mask)
return;
}
- if ((ret & PR_MTE_TCF_MASK) == mask) {
+ if ((ret & (int)PR_MTE_TCF_MASK) == mask) {
ksft_test_result_pass("%s\n", name);
} else {
ksft_print_msg("Got %x, expected %x\n",
- (ret & PR_MTE_TCF_MASK), mask);
+ (ret & (int)PR_MTE_TCF_MASK), mask);
ksft_test_result_fail("%s\n", name);
}
}
--
2.25.1
next prev parent reply other threads:[~2024-08-16 15:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 15:32 [PATCH 0/8] kselftest/arm64: various compilation fixes Andre Przywara
2024-08-16 15:32 ` [PATCH 1/8] kselftest/arm64: signal: drop now redundant GNU_SOURCE definition Andre Przywara
2024-08-16 16:24 ` Mark Brown
2024-08-16 15:32 ` [PATCH 2/8] kselftest/arm64: hwcap: fix f8dp2 cpuinfo name Andre Przywara
2024-08-16 16:24 ` Mark Brown
2024-08-16 15:32 ` [PATCH 3/8] kselftest/arm64: mte: use proper SKIP syntax Andre Przywara
2024-08-16 16:25 ` Mark Brown
2024-08-16 15:32 ` [PATCH 4/8] kselftest/arm64: mte: use string literal for printf-style functions Andre Przywara
2024-08-16 16:26 ` Mark Brown
2024-08-16 15:32 ` Andre Przywara [this message]
2024-08-16 16:30 ` [PATCH 5/8] kselftest/arm64: mte: fix printf type warning about mask Mark Brown
2024-08-16 16:55 ` Andre Przywara
2024-08-16 17:07 ` Mark Brown
2024-08-16 15:32 ` [PATCH 6/8] kselftest/arm64: mte: fix printf type warnings about __u64 Andre Przywara
2024-08-16 16:31 ` Mark Brown
2024-08-16 15:32 ` [PATCH 7/8] kselftest/arm64: mte: fix printf type warnings about pointers Andre Przywara
2024-08-16 16:32 ` Mark Brown
2024-08-16 16:59 ` Andre Przywara
2024-08-16 17:12 ` Mark Brown
2024-08-16 15:32 ` [PATCH 8/8] kselftest/arm64: mte: fix printf type warnings about longs Andre Przywara
2024-08-16 16:33 ` Mark Brown
2024-10-17 17:59 ` (subset) [PATCH 0/8] kselftest/arm64: various compilation fixes Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816153251.2833702-6-andre.przywara@arm.com \
--to=andre.przywara@arm.com \
--cc=amit.kachhap@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox