* [PATCH] kselftest/arm64: Fix build warnings for ptrace
@ 2024-08-30 5:29 Dev Jain
2024-08-30 11:29 ` Mark Brown
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dev Jain @ 2024-08-30 5:29 UTC (permalink / raw)
To: shuah, linux-arm-kernel, linux-kselftest, Catalin.Marinas, will
Cc: broonie, ryan.roberts, Anshuman.Khandual, aneesh.kumar,
linux-kernel, Dev Jain
A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
introduced ksft_exit_fail_perror().
Signed-off-by: Dev Jain <dev.jain@arm.com>
---
tools/testing/selftests/arm64/abi/ptrace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
index e4fa507cbdd0..b51d21f78cf9 100644
--- a/tools/testing/selftests/arm64/abi/ptrace.c
+++ b/tools/testing/selftests/arm64/abi/ptrace.c
@@ -163,10 +163,10 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
static int do_child(void)
{
if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
- ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
+ ksft_exit_fail_perror("PTRACE_TRACEME");
if (raise(SIGSTOP))
- ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
+ ksft_exit_fail_perror("raise(SIGSTOP)");
return EXIT_SUCCESS;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kselftest/arm64: Fix build warnings for ptrace
2024-08-30 5:29 [PATCH] kselftest/arm64: Fix build warnings for ptrace Dev Jain
@ 2024-08-30 11:29 ` Mark Brown
2024-08-30 13:27 ` Shuah Khan
2024-08-30 16:12 ` Will Deacon
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-08-30 11:29 UTC (permalink / raw)
To: Dev Jain
Cc: shuah, linux-arm-kernel, linux-kselftest, Catalin.Marinas, will,
ryan.roberts, Anshuman.Khandual, aneesh.kumar, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
On Fri, Aug 30, 2024 at 10:59:11AM +0530, Dev Jain wrote:
> A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
> introduced ksft_exit_fail_perror().
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kselftest/arm64: Fix build warnings for ptrace
2024-08-30 5:29 [PATCH] kselftest/arm64: Fix build warnings for ptrace Dev Jain
2024-08-30 11:29 ` Mark Brown
@ 2024-08-30 13:27 ` Shuah Khan
2024-08-30 16:12 ` Will Deacon
2 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2024-08-30 13:27 UTC (permalink / raw)
To: Dev Jain, shuah, linux-arm-kernel, linux-kselftest,
Catalin.Marinas, will
Cc: broonie, ryan.roberts, Anshuman.Khandual, aneesh.kumar,
linux-kernel, Shuah Khan
On 8/29/24 23:29, Dev Jain wrote:
> A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
> introduced ksft_exit_fail_perror().
>
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---
> tools/testing/selftests/arm64/abi/ptrace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index e4fa507cbdd0..b51d21f78cf9 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -163,10 +163,10 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> static int do_child(void)
> {
> if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
> - ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
> + ksft_exit_fail_perror("PTRACE_TRACEME");
>
> if (raise(SIGSTOP))
> - ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
> + ksft_exit_fail_perror("raise(SIGSTOP)");
>
> return EXIT_SUCCESS;
> }
Thanks for doing this.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kselftest/arm64: Fix build warnings for ptrace
2024-08-30 5:29 [PATCH] kselftest/arm64: Fix build warnings for ptrace Dev Jain
2024-08-30 11:29 ` Mark Brown
2024-08-30 13:27 ` Shuah Khan
@ 2024-08-30 16:12 ` Will Deacon
2 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2024-08-30 16:12 UTC (permalink / raw)
To: shuah, linux-arm-kernel, linux-kselftest, Catalin.Marinas,
Dev Jain
Cc: catalin.marinas, kernel-team, Will Deacon, broonie, ryan.roberts,
Anshuman.Khandual, aneesh.kumar, linux-kernel
On Fri, 30 Aug 2024 10:59:11 +0530, Dev Jain wrote:
> A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
> introduced ksft_exit_fail_perror().
>
>
Applied to arm64 (for-next/selftests), thanks!
[1/1] kselftest/arm64: Fix build warnings for ptrace
https://git.kernel.org/arm64/c/d736d4fc7630
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-30 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 5:29 [PATCH] kselftest/arm64: Fix build warnings for ptrace Dev Jain
2024-08-30 11:29 ` Mark Brown
2024-08-30 13:27 ` Shuah Khan
2024-08-30 16:12 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox