From: Vipin Sharma <vipinsh@google.com>
To: bhelgaas@google.com, alex.williamson@redhat.com,
pasha.tatashin@soleen.com, dmatlack@google.com, jgg@ziepe.ca,
graf@amazon.com
Cc: pratyush@kernel.org, gregkh@linuxfoundation.org,
chrisl@kernel.org, rppt@kernel.org, skhawaja@google.com,
parav@nvidia.com, saeedm@nvidia.com, kevin.tian@intel.com,
jrhilke@google.com, david@redhat.com, jgowans@amazon.com,
dwmw2@infradead.org, epetron@amazon.de, junaids@google.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
Vipin Sharma <vipinsh@google.com>
Subject: [RFC PATCH 21/21] vfio: selftests: Validate vconfig preservation of VFIO PCI device during live update
Date: Fri, 17 Oct 2025 17:07:13 -0700 [thread overview]
Message-ID: <20251018000713.677779-22-vipinsh@google.com> (raw)
In-Reply-To: <20251018000713.677779-1-vipinsh@google.com>
Test preservation of a VFIO PCI device virtual config (vconfig in struct
vfio_pci_core_device{}) during the live update. Write some random data
to PCI_INTERRUPT_LINE register which is virtualized by VFIO and verify
that the same data is read after kexec.
Certain bits in the config space are virtualized by VFIO, so write to
them don't go to the device PCI config instead they are stored in
memory. After live update, vconfig should have the value same as prior
to kexec, which means vconfig should be saved in KHO and later retrieved
to restore the device.
Signed-off-by: Vipin Sharma <vipinsh@google.com>
---
.../testing/selftests/vfio/vfio_pci_liveupdate_test.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c b/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c
index 9fd0061348e0..2d80fdcb1ef7 100644
--- a/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c
+++ b/tools/testing/selftests/vfio/vfio_pci_liveupdate_test.c
@@ -15,12 +15,14 @@
#define SESSION_NAME "multi_file_session"
#define TOKEN 1234
+#define RANDOM_DATA 0x12
static void run_pre_kexec(int luo_fd, const char *bdf)
{
struct vfio_pci_device *device;
int session_fd;
u16 command;
+ u8 data;
device = vfio_pci_device_init(bdf, "iommufd");
@@ -30,6 +32,10 @@ static void run_pre_kexec(int luo_fd, const char *bdf)
vfio_pci_config_writew(device, PCI_COMMAND,
command | PCI_COMMAND_MASTER);
+ vfio_pci_config_writeb(device, PCI_INTERRUPT_LINE, RANDOM_DATA);
+ data = vfio_pci_config_readb(device, PCI_INTERRUPT_LINE);
+ VFIO_ASSERT_EQ(data, RANDOM_DATA);
+
session_fd = luo_create_session(luo_fd, SESSION_NAME);
VFIO_ASSERT_GE(session_fd, 0, "Failed to create session %s",
SESSION_NAME);
@@ -51,6 +57,7 @@ static void run_post_kexec(int luo_fd, const char *bdf)
int vfio_fd;
struct vfio_pci_device *device;
u16 command;
+ u8 data;
session_fd = luo_retrieve_session(luo_fd, SESSION_NAME);
@@ -74,6 +81,9 @@ static void run_post_kexec(int luo_fd, const char *bdf)
command = vfio_pci_config_readw(device, PCI_COMMAND);
VFIO_ASSERT_TRUE(command & PCI_COMMAND_MASTER);
+
+ data = vfio_pci_config_readb(device, PCI_INTERRUPT_LINE);
+ VFIO_ASSERT_EQ(data, RANDOM_DATA);
vfio_pci_device_cleanup(device);
}
--
2.51.0.858.gf9c4a03a3a-goog
next prev parent reply other threads:[~2025-10-18 0:08 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 0:06 [RFC PATCH 00/21] VFIO live update support Vipin Sharma
2025-10-18 0:06 ` [RFC PATCH 01/21] selftests/liveupdate: Build tests from the selftests/liveupdate directory Vipin Sharma
2025-10-18 0:06 ` [RFC PATCH 02/21] selftests/liveupdate: Create library of core live update ioctls Vipin Sharma
2025-10-18 0:06 ` [RFC PATCH 03/21] selftests/liveupdate: Move do_kexec.sh script to liveupdate/lib Vipin Sharma
2025-10-18 0:06 ` [RFC PATCH 04/21] selftests/liveupdate: Move LUO ioctls calls to liveupdate library Vipin Sharma
2025-10-18 0:06 ` [RFC PATCH 05/21] vfio/pci: Register VFIO live update file handler to Live Update Orchestrator Vipin Sharma
2025-10-31 21:24 ` David Matlack
2025-10-31 22:28 ` David Matlack
2025-10-18 0:06 ` [RFC PATCH 06/21] vfio/pci: Accept live update preservation request for VFIO cdev Vipin Sharma
2025-10-27 20:44 ` Jacob Pan
2025-10-28 13:28 ` Jason Gunthorpe
2025-10-28 17:39 ` Jacob Pan
2025-10-29 16:21 ` Jason Gunthorpe
2025-10-30 23:10 ` David Matlack
2025-10-31 0:18 ` Pasha Tatashin
2025-10-31 21:41 ` David Matlack
2025-10-18 0:06 ` [RFC PATCH 07/21] vfio/pci: Store VFIO PCI device preservation data in KHO for live update Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 08/21] vfio/pci: Retrieve preserved VFIO device for Live Update Orechestrator Vipin Sharma
2025-10-31 23:12 ` David Matlack
2025-10-18 0:07 ` [RFC PATCH 09/21] vfio/pci: Add Live Update finish callback implementation Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 10/21] PCI: Add option to skip Bus Master Enable reset during kexec Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 11/21] vfio/pci: Skip clearing bus master on live update device " Vipin Sharma
2025-10-18 7:09 ` Lukas Wunner
2025-10-18 22:19 ` Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 12/21] vfio/pci: Skip clearing bus master on live update restored device Vipin Sharma
2025-10-20 21:29 ` David Matlack
2025-10-20 22:39 ` Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 13/21] vfio/pci: Preserve VFIO PCI config space through live update Vipin Sharma
2025-10-18 14:59 ` Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 14/21] vfio/pci: Skip device reset on live update restored device Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 15/21] PCI: Make PCI saved state and capability structs public Vipin Sharma
2025-10-18 7:17 ` Lukas Wunner
2025-10-18 22:36 ` Vipin Sharma
2025-10-18 23:11 ` Jason Gunthorpe
2025-10-20 23:49 ` Vipin Sharma
2025-10-22 17:45 ` David Matlack
2025-10-22 17:51 ` Jason Gunthorpe
2025-10-22 17:53 ` Jason Gunthorpe
2025-10-19 8:15 ` Lukas Wunner
2025-10-20 23:54 ` Vipin Sharma
2025-10-30 23:55 ` David Matlack
2025-10-31 0:06 ` David Matlack
2025-10-18 0:07 ` [RFC PATCH 16/21] vfio/pci: Save and restore the PCI state of the VFIO device Vipin Sharma
2025-10-18 7:25 ` Lukas Wunner
2025-10-18 22:44 ` Vipin Sharma
2025-10-18 15:02 ` Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 17/21] vfio/pci: Disable interrupts before going live update kexec Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 18/21] vfio: selftests: Build liveupdate library in VFIO selftests Vipin Sharma
2025-10-20 20:50 ` David Matlack
2025-10-20 23:55 ` Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 19/21] vfio: selftests: Initialize vfio_pci_device using a VFIO cdev FD Vipin Sharma
2025-10-18 0:07 ` [RFC PATCH 20/21] vfio: selftests: Add VFIO live update test Vipin Sharma
2025-10-18 0:07 ` Vipin Sharma [this message]
2025-10-18 17:21 ` [RFC PATCH 00/21] VFIO live update support Jason Gunthorpe
2025-10-18 22:53 ` Vipin Sharma
2025-10-18 23:06 ` Jason Gunthorpe
2025-10-20 23:30 ` Vipin Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251018000713.677779-22-vipinsh@google.com \
--to=vipinsh@google.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=dmatlack@google.com \
--cc=dwmw2@infradead.org \
--cc=epetron@amazon.de \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=jgowans@amazon.com \
--cc=jrhilke@google.com \
--cc=junaids@google.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=saeedm@nvidia.com \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox