Linux Kernel Selftest development
 help / color / mirror / Atom feed
* [PATCH nfc] selftests/nci: increase t4t_tag_read timeout for debug kernels
@ 2026-08-07 22:16 Jakub Kicinski
  0 siblings, 0 replies; only message in thread
From: Jakub Kicinski @ 2026-08-07 22:16 UTC (permalink / raw)
  To: david; +Cc: Jakub Kicinski, bongsu.jeon, shuah, oe-linux-nfc, linux-kselftest

The t4t_tag_read test occasionally exceeds the default 30-second
TEST_TIMEOUT_DEFAULT, triggering flaky "Test terminated by timeout"
failures (~4% rate on slow CI systems with debug configs).

TBH this is potentially papering over a real issue. The test usually
takes 7sec to finish, with this fix it sometimes takes 37s. What
happens when it needs extra time I do not know. But the upshot is
that it used to flake 4% of the time in NIPA and now it passes
(200 clean runs). So unless someone has time to really dig into this,
let's silence it?

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: bongsu.jeon@samsung.com
CC: david@ixit.cz
CC: shuah@kernel.org
CC: oe-linux-nfc@lists.linux.dev
CC: linux-kselftest@vger.kernel.org
---
 tools/testing/selftests/nci/nci_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
index 312f84ee0444..77344227dd7f 100644
--- a/tools/testing/selftests/nci/nci_dev.c
+++ b/tools/testing/selftests/nci/nci_dev.c
@@ -836,7 +836,7 @@ int disconnect_tag(int nfc_sock, int virtual_fd)
 	return status;
 }
 
-TEST_F(NCI, t4t_tag_read)
+TEST_F_TIMEOUT(NCI, t4t_tag_read, 120)
 {
 	int nfc_sock;
 	int status;
-- 
2.55.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-08-07 22:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-07 22:16 [PATCH nfc] selftests/nci: increase t4t_tag_read timeout for debug kernels Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox