Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

[Shuah Khan <skhan@linuxfoundation.org>]

On 9/19/24 05:18, Yu Liao wrote:
> When building selftests/vDSO:
> $ make -C tools/testing/selftests TARGETS=vDSO
> I hit the following compilation error:
> 
>    vdso_test_getrandom.c:260:17: error: 'CLONE_NEWTIME' undeclared
>    (first use in this function); did you mean 'CLONE_NEWIPC'?
>      260 |  assert(unshare(CLONE_NEWTIME) == 0);
>          |                 ^~~~~~~~~~~~~
> 
> CLONE_NEWTIME is defined in linux/sched.h, so fix this by including
> <linux/sched.h>.
> 
> Fixes: 2aec90036dcd ("selftests: vDSO: ensure vgetrandom works in a time namespace")
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> ---
>   tools/testing/selftests/vDSO/vdso_test_getrandom.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> index 72a1d9b43a84..84f2bbb2d5e0 100644
> --- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> +++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
> @@ -19,6 +19,7 @@
>   #include <sys/ptrace.h>
>   #include <sys/wait.h>
>   #include <sys/types.h>
> +#include <linux/sched.h>
>   #include <linux/random.h>
>   #include <linux/compiler.h>
>   #include <linux/ptrace.h>

Do you see this error after installing headers? Installing headers is
a dependency to be able to compile selftests.

thanks,
-- Shuah