From: Yu Liao <liaoyu15@huawei.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: <shuah@kernel.org>, <liwei391@huawei.com>, <broonie@kernel.org>,
<linux-kselftest@vger.kernel.org>,
Xie XiuQi <xiexiuqi@huawei.com>
Subject: Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom
Date: Tue, 24 Sep 2024 10:57:46 +0800 [thread overview]
Message-ID: <702f6d09-5216-eef5-299d-6445cfca8233@huawei.com> (raw)
In-Reply-To: <87684869-4565-4a4a-845f-4301242be52a@linuxfoundation.org>
Hi,
On 2024/9/23 23:30, Shuah Khan wrote:
> On 9/20/24 09:31, Jason A. Donenfeld wrote:
>> Indeed probably <sched.h> is what's wanted here.
>>
>
> Yu Liao, Please send v2 as per the review comments.
>
CLONE_NEWTIME was introduced in glibc-2.36, which was released in August 2022.
As Christophe mentioned, <sched.h> is already indirectly included by
<phread.h>, so this issue does not exist if glibc version higher than 2.36.
Additionally, CLONE_NEWTIME was introduced in Linux 5.6 in March 2020, the
CLONE_ macros are also defined in <linux/sched.h>, which is part of the
kernel-header package.
My environment is Ubuntu 22.04 (Linux 5.15 + glibc 2.35), after upgrading to a
newer version of glibc, the issue appears to be resolved.
It seems to me that including <sched.h> might be unnecessary. I would greatly
appreciate your guidance on how best to handle this situation.
Best regards,
Yu
next prev parent reply other threads:[~2024-09-24 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 11:18 [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom Yu Liao
2024-09-19 16:51 ` Shuah Khan
2024-09-20 1:54 ` Yu Liao
2024-09-20 9:33 ` Christophe Leroy
2024-09-20 15:31 ` Jason A. Donenfeld
2024-09-23 15:30 ` Shuah Khan
2024-09-24 2:57 ` Yu Liao [this message]
2024-10-03 22:21 ` Shuah Khan
2024-10-08 2:50 ` Yu Liao
-- strict thread matches above, loose matches on Subject: below --
2024-10-02 15:28 [PATCH] selftests/vdso: Add linux/sched.h to fix CLONE_NEWTIME build error SurajSonawane2415
2024-10-03 11:52 ` [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom SurajSonawane2415
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=702f6d09-5216-eef5-299d-6445cfca8233@huawei.com \
--to=liaoyu15@huawei.com \
--cc=Jason@zx2c4.com \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kselftest@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox