Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

[Shuah Khan <skhan@linuxfoundation.org>]

On 9/23/24 20:57, Yu Liao wrote:
> Hi,
> On 2024/9/23 23:30, Shuah Khan wrote:
>> On 9/20/24 09:31, Jason A. Donenfeld wrote:
>>> Indeed probably <sched.h> is what's wanted here.
>>>
>>
>> Yu Liao, Please send v2 as per the review comments.
>>
> 
> CLONE_NEWTIME was introduced in glibc-2.36, which was released in August 2022.
> As Christophe mentioned, <sched.h> is already indirectly included by
> <phread.h>, so this issue does not exist if glibc version higher than 2.36.
> 
> Additionally, CLONE_NEWTIME was introduced in Linux 5.6 in March 2020, the
> CLONE_ macros are also defined in <linux/sched.h>, which is part of the
> kernel-header package.
> 
> My environment is Ubuntu 22.04 (Linux 5.15 + glibc 2.35), after upgrading to a
> newer version of glibc, the issue appears to be resolved.
> It seems to me that including <sched.h> might be unnecessary. I would greatly
> appreciate your guidance on how best to handle this situation.
> 

Please send me v2 with sched.h included explicitly. It is better do do so
than having it come from <phread.h> indirectly.

thanks,
-- SHuah