* [PATCH] selftests/futex: futex_waitv wouldblock test should fail
@ 2025-04-04 22:12 Edward Liaw
2025-04-08 9:00 ` Thomas Gleixner
2025-04-08 14:21 ` André Almeida
0 siblings, 2 replies; 4+ messages in thread
From: Edward Liaw @ 2025-04-04 22:12 UTC (permalink / raw)
To: linux-kselftest, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
Darren Hart, Davidlohr Bueso, André Almeida, Shuah Khan
Cc: linux-kernel, kernel-team, Edward Liaw
Testcase should fail if -EWOULDBLOCK is not returned when expected value
differs from actual value from the waiter.
Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
Signed-off-by: Edward Liaw <edliaw@google.com>
---
.../testing/selftests/futex/functional/futex_wait_wouldblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c b/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c
index 7d7a6a06cdb7..2d8230da9064 100644
--- a/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c
+++ b/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c
@@ -98,7 +98,7 @@ int main(int argc, char *argv[])
info("Calling futex_waitv on f1: %u @ %p with val=%u\n", f1, &f1, f1+1);
res = futex_waitv(&waitv, 1, 0, &to, CLOCK_MONOTONIC);
if (!res || errno != EWOULDBLOCK) {
- ksft_test_result_pass("futex_waitv returned: %d %s\n",
+ ksft_test_result_fail("futex_waitv returned: %d %s\n",
res ? errno : res,
res ? strerror(errno) : "");
ret = RET_FAIL;
--
2.49.0.504.g3bcea36a83-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail
2025-04-04 22:12 [PATCH] selftests/futex: futex_waitv wouldblock test should fail Edward Liaw
@ 2025-04-08 9:00 ` Thomas Gleixner
2025-04-08 14:21 ` André Almeida
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2025-04-08 9:00 UTC (permalink / raw)
To: Edward Liaw, linux-kselftest, Ingo Molnar, Peter Zijlstra,
Darren Hart, Davidlohr Bueso, André Almeida, Shuah Khan
Cc: linux-kernel, kernel-team, Edward Liaw
On Fri, Apr 04 2025 at 22:12, Edward Liaw wrote:
> Testcase should fail if -EWOULDBLOCK is not returned when expected value
> differs from actual value from the waiter.
>
> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
> Signed-off-by: Edward Liaw <edliaw@google.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail
2025-04-04 22:12 [PATCH] selftests/futex: futex_waitv wouldblock test should fail Edward Liaw
2025-04-08 9:00 ` Thomas Gleixner
@ 2025-04-08 14:21 ` André Almeida
2025-04-08 22:52 ` Shuah Khan
1 sibling, 1 reply; 4+ messages in thread
From: André Almeida @ 2025-04-08 14:21 UTC (permalink / raw)
To: Edward Liaw
Cc: linux-kernel, Ingo Molnar, Darren Hart, linux-kselftest,
Shuah Khan, Peter Zijlstra, kernel-team, Davidlohr Bueso,
Thomas Gleixner
Thank you Edward,
Em 04/04/2025 19:12, Edward Liaw escreveu:
> Testcase should fail if -EWOULDBLOCK is not returned when expected value
> differs from actual value from the waiter.
>
> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
> Signed-off-by: Edward Liaw <edliaw@google.com>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail
2025-04-08 14:21 ` André Almeida
@ 2025-04-08 22:52 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2025-04-08 22:52 UTC (permalink / raw)
To: André Almeida, Edward Liaw
Cc: linux-kernel, Ingo Molnar, Darren Hart, linux-kselftest,
Shuah Khan, Peter Zijlstra, kernel-team, Davidlohr Bueso,
Thomas Gleixner, Shuah Khan
On 4/8/25 08:21, André Almeida wrote:
> Thank you Edward,
>
> Em 04/04/2025 19:12, Edward Liaw escreveu:
>> Testcase should fail if -EWOULDBLOCK is not returned when expected value
>> differs from actual value from the waiter.
>>
>> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
>> Signed-off-by: Edward Liaw <edliaw@google.com>
>
> Reviewed-by: André Almeida <andrealmeid@igalia.com>
>
Thank you. Applied for Linux 6.15-rc2
https://web.git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-08 22:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-04 22:12 [PATCH] selftests/futex: futex_waitv wouldblock test should fail Edward Liaw
2025-04-08 9:00 ` Thomas Gleixner
2025-04-08 14:21 ` André Almeida
2025-04-08 22:52 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox