Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: khalid.aziz at oracle.com (Khalid Aziz)
Subject: [PATCH v16 01/16] uaccess: add untagged_addr definition for other arches
Date: Mon, 3 Jun 2019 11:02:33 -0600	[thread overview]
Message-ID: <8ff5b0ff-849a-1e0b-18da-ccb5be85dd2b@oracle.com> (raw)
In-Reply-To: <097bc300a5c6554ca6fd1886421bb2e0adb03420.1559580831.git.andreyknvl@google.com>

On 6/3/19 10:55 AM, Andrey Konovalov wrote:
> To allow arm64 syscalls to accept tagged pointers from userspace, we must
> untag them when they are passed to the kernel. Since untagging is done in
> generic parts of the kernel, the untagged_addr macro needs to be defined
> for all architectures.
> 
> Define it as a noop for architectures other than arm64.
> 
> Acked-by: Catalin Marinas <catalin.marinas at arm.com>
> Reviewed-by: Khalid Aziz <khalid.aziz at oracle.com>
> Signed-off-by: Andrey Konovalov <andreyknvl at google.com>
> ---
>  include/linux/mm.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 0e8834ac32b7..949d43e9c0b6 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -99,6 +99,10 @@ extern int mmap_rnd_compat_bits __read_mostly;
>  #include <asm/pgtable.h>
>  #include <asm/processor.h>
>  
> +#ifndef untagged_addr
> +#define untagged_addr(addr) (addr)
> +#endif
> +
>  #ifndef __pa_symbol
>  #define __pa_symbol(x)  __pa(RELOC_HIDE((unsigned long)(x), 0))
>  #endif
> 

Andrey,

This patch has now become part of the other patch series Chris Hellwig
has sent out -
<https://lore.kernel.org/lkml/20190601074959.14036-1-hch at lst.de/>. Can
you coordinate with that patch series?

--
Khalid

WARNING: multiple messages have this Message-ID (diff)
From: khalid.aziz@oracle.com (Khalid Aziz)
Subject: [PATCH v16 01/16] uaccess: add untagged_addr definition for other arches
Date: Mon, 3 Jun 2019 11:02:33 -0600	[thread overview]
Message-ID: <8ff5b0ff-849a-1e0b-18da-ccb5be85dd2b@oracle.com> (raw)
Message-ID: <20190603170233.HxeUkPgzTvUQhJ3WfMWFP5xO6ElsnG-76J9Faa2JyNU@z> (raw)
In-Reply-To: <097bc300a5c6554ca6fd1886421bb2e0adb03420.1559580831.git.andreyknvl@google.com>

On 6/3/19 10:55 AM, Andrey Konovalov wrote:
> To allow arm64 syscalls to accept tagged pointers from userspace, we must
> untag them when they are passed to the kernel. Since untagging is done in
> generic parts of the kernel, the untagged_addr macro needs to be defined
> for all architectures.
> 
> Define it as a noop for architectures other than arm64.
> 
> Acked-by: Catalin Marinas <catalin.marinas at arm.com>
> Reviewed-by: Khalid Aziz <khalid.aziz at oracle.com>
> Signed-off-by: Andrey Konovalov <andreyknvl at google.com>
> ---
>  include/linux/mm.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 0e8834ac32b7..949d43e9c0b6 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -99,6 +99,10 @@ extern int mmap_rnd_compat_bits __read_mostly;
>  #include <asm/pgtable.h>
>  #include <asm/processor.h>
>  
> +#ifndef untagged_addr
> +#define untagged_addr(addr) (addr)
> +#endif
> +
>  #ifndef __pa_symbol
>  #define __pa_symbol(x)  __pa(RELOC_HIDE((unsigned long)(x), 0))
>  #endif
> 

Andrey,

This patch has now become part of the other patch series Chris Hellwig
has sent out -
<https://lore.kernel.org/lkml/20190601074959.14036-1-hch at lst.de/>. Can
you coordinate with that patch series?

--
Khalid

  parent reply	other threads:[~2019-06-03 17:02 UTC|newest]

Thread overview: 141+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 16:55 [PATCH v16 00/16] arm64: untag user pointers passed to the kernel andreyknvl
2019-06-03 16:55 ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 01/16] uaccess: add untagged_addr definition for other arches andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-03 17:02   ` khalid.aziz [this message]
2019-06-03 17:02     ` Khalid Aziz
2019-06-03 17:06     ` andreyknvl
2019-06-03 17:06       ` Andrey Konovalov
2019-06-03 17:24       ` khalid.aziz
2019-06-03 17:24         ` Khalid Aziz
2019-06-03 17:29         ` hch
2019-06-03 17:29           ` Christoph Hellwig
2019-06-03 18:17           ` khalid.aziz
2019-06-03 18:17             ` Khalid Aziz
2019-06-04 11:45             ` andreyknvl
2019-06-04 11:45               ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:51   ` keescook
2019-06-08  3:51     ` Kees Cook
2019-06-08  3:51     ` Kees Cook
2019-06-10 17:53   ` catalin.marinas
2019-06-10 17:53     ` Catalin Marinas
2019-06-10 17:53     ` Catalin Marinas
2019-06-10 18:07     ` keescook
2019-06-10 18:07       ` Kees Cook
2019-06-10 18:07       ` Kees Cook
2019-06-10 18:53       ` catalin.marinas
2019-06-10 18:53         ` Catalin Marinas
2019-06-10 18:53         ` Catalin Marinas
2019-06-10 20:36         ` keescook
2019-06-10 20:36           ` Kees Cook
2019-06-10 20:36           ` Kees Cook
2019-06-11 14:57     ` Catalin Marinas
2019-06-11 17:09       ` Vincenzo Frascino
2019-06-12  9:32         ` Catalin Marinas
2019-06-12 11:52           ` Vincenzo Frascino
2019-06-11 17:09       ` Andrey Konovalov
2019-06-11 17:39         ` Catalin Marinas
2019-06-12 11:03           ` Andrey Konovalov
2019-06-12 11:04             ` Catalin Marinas
2019-06-03 16:55 ` [PATCH v16 03/16] lib, arm64: untag user pointers in strn*_user andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:48   ` keescook
2019-06-08  3:48     ` Kees Cook
2019-06-08  3:48     ` Kees Cook
2019-06-11 20:06   ` Khalid Aziz
2019-06-03 16:55 ` [PATCH v16 04/16] mm: untag user pointers in do_pages_move andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:49   ` keescook
2019-06-08  3:49     ` Kees Cook
2019-06-08  3:49     ` Kees Cook
2019-06-11 20:18   ` Khalid Aziz
2019-06-12 11:08     ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 05/16] arm64: untag user pointers passed to memory syscalls andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:51   ` keescook
2019-06-08  3:51     ` Kees Cook
2019-06-08  3:51     ` Kees Cook
2019-06-10 14:28   ` catalin.marinas
2019-06-10 14:28     ` Catalin Marinas
2019-06-10 14:28     ` Catalin Marinas
2019-06-11 15:35     ` Andrey Konovalov
2019-06-11 17:44       ` Catalin Marinas
2019-06-12 11:13         ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 06/16] mm, arm64: untag user pointers in mm/gup.c andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:59   ` keescook
2019-06-08  3:59     ` Kees Cook
2019-06-08  3:59     ` Kees Cook
2019-06-03 16:55 ` [PATCH v16 07/16] mm, arm64: untag user pointers in get_vaddr_frames andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  4:00   ` keescook
2019-06-08  4:00     ` Kees Cook
2019-06-08  4:00     ` Kees Cook
2019-06-10 14:29   ` catalin.marinas
2019-06-10 14:29     ` Catalin Marinas
2019-06-10 14:29     ` Catalin Marinas
2019-06-03 16:55 ` [PATCH v16 08/16] fs, arm64: untag user pointers in copy_mount_options andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  4:02   ` keescook
2019-06-08  4:02     ` Kees Cook
2019-06-08  4:02     ` Kees Cook
2019-06-11 14:38     ` Andrey Konovalov
2019-06-12 11:36       ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 09/16] fs, arm64: untag user pointers in fs/userfaultfd.c andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  4:03   ` keescook
2019-06-08  4:03     ` Kees Cook
2019-06-08  4:03     ` Kees Cook
2019-06-12 10:45   ` Catalin Marinas
2019-06-03 16:55 ` [PATCH v16 10/16] drm/amdgpu, arm64: untag user pointers andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 11/16] drm/radeon, arm64: untag user pointers in radeon_gem_userptr_ioctl andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-03 16:55 ` [PATCH v16 12/16] IB, arm64: untag user pointers in ib_uverbs_(re)reg_mr() andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-03 17:46   ` jgg
2019-06-03 17:46     ` Jason Gunthorpe
2019-06-04 12:18     ` andreyknvl
2019-06-04 12:18       ` Andrey Konovalov
2019-06-04 12:27       ` jgg
2019-06-04 12:27         ` Jason Gunthorpe
2019-06-04 12:45         ` andreyknvl
2019-06-04 12:45           ` Andrey Konovalov
2019-06-04 13:02           ` jgg
2019-06-04 13:02             ` Jason Gunthorpe
2019-06-04 13:09             ` andreyknvl
2019-06-04 13:09               ` Andrey Konovalov
2019-06-12 11:01               ` Catalin Marinas
2019-06-03 16:55 ` [PATCH v16 13/16] media/v4l2-core, arm64: untag user pointers in videobuf_dma_contig_user_get andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:52   ` keescook
2019-06-08  3:52     ` Kees Cook
2019-06-08  3:52     ` Kees Cook
2019-06-03 16:55 ` [PATCH v16 14/16] tee, arm64: untag user pointers in tee_shm_register andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-07  5:33   ` jens.wiklander
2019-06-07  5:33     ` Jens Wiklander
2019-06-07  5:33     ` Jens Wiklander
2019-06-08  4:05   ` keescook
2019-06-08  4:05     ` Kees Cook
2019-06-08  4:05     ` Kees Cook
2019-06-03 16:55 ` [PATCH v16 15/16] vfio/type1, arm64: untag user pointers in vaddr_get_pfn andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:58   ` keescook
2019-06-08  3:58     ` Kees Cook
2019-06-08  3:58     ` Kees Cook
2019-06-12 10:38   ` Catalin Marinas
2019-06-03 16:55 ` [PATCH v16 16/16] selftests, arm64: add a selftest for passing tagged pointers to kernel andreyknvl
2019-06-03 16:55   ` Andrey Konovalov
2019-06-08  3:56   ` keescook
2019-06-08  3:56     ` Kees Cook
2019-06-08  3:56     ` Kees Cook
2019-06-10 22:08     ` shuah
2019-06-10 22:08       ` shuah
2019-06-10 22:08       ` shuah
2019-06-11 15:01   ` Catalin Marinas
2019-06-11 17:18     ` Andrey Konovalov
2019-06-11 17:50       ` Catalin Marinas
2019-06-12 11:14         ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ff5b0ff-849a-1e0b-18da-ccb5be85dd2b@oracle.com \
    --to=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox