From: Randy Dunlap <rdunlap@infradead.org>
To: Dan Murphy <dmurphy@ti.com>, jacek.anaszewski@gmail.com, pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 0/9] Multicolor FW v8 update
Date: Fri, 20 Sep 2019 10:44:19 -0700 [thread overview]
Message-ID: <01ff2638-8952-e8a3-0c59-ac87f63d24c0@infradead.org> (raw)
In-Reply-To: <20190920174139.30079-1-dmurphy@ti.com>
On 9/20/19 10:41 AM, Dan Murphy wrote:
> Hello
>
> Per request I removed the ops structure. But there is a potential need for some
> device drivers to have a call back that sets the intesity of the LED color
> without modifying the hardware register. The hardware registers are only updated
> when the brightness_set<op> is called. The need arises with the LP50xx chip
> series where the chip has 2 control knobs to modify the output current to the
> LED. In most cases drivers only have a single brightness register for a given
> iOUT pin. But the LP50xx has a brightness register that controls cluster
> brightness and individual registers to control the monochrome LED intensity.
>
> The set_color_brightness call back has been simplified in the LP50xx device
> driver so that it can cache the LED intensity in it's stack for a specific color
> as opposed to having to call back into the MC FW for the current intensity which
> made the driver complex.
"FW" historically means either firmware or firewire.
Please spell out framework in the future.
> Once the set_brightness<op> is called the driver can set the brightness and then
> set the LED intensity registers if the driver has that ability.
>
> Dan
>
> Dan Murphy (9):
> leds: multicolor: Add sysfs interface definition
> documention: leds: Add multicolor class documentation
> dt: bindings: Add multicolor class dt bindings documention
> dt-bindings: leds: Add multicolor ID to the color ID list
> leds: Add multicolor ID to the color ID list
> leds: multicolor: Introduce a multicolor class definition
> dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers
> leds: lp50xx: Add the LP50XX family of the RGB LED driver
> leds: Update the lp55xx to use the multi color framework
Thanks.
--
~Randy
prev parent reply other threads:[~2019-09-20 17:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 17:41 [PATCH v8 0/9] Multicolor FW v8 update Dan Murphy
2019-09-20 17:41 ` [PATCH v8 1/9] leds: multicolor: Add sysfs interface definition Dan Murphy
2019-09-21 10:55 ` Jacek Anaszewski
2019-09-23 14:23 ` Dan Murphy
2019-09-20 17:41 ` [PATCH v8 2/9] documention: leds: Add multicolor class documentation Dan Murphy
2019-09-21 12:28 ` Jacek Anaszewski
2019-09-23 14:50 ` Dan Murphy
2019-09-23 21:21 ` Jacek Anaszewski
2019-09-20 17:41 ` [PATCH v8 3/9] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-09-21 12:57 ` Jacek Anaszewski
2019-09-23 14:52 ` Dan Murphy
2019-09-20 17:41 ` [PATCH v8 4/9] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-09-21 12:58 ` Jacek Anaszewski
2019-09-20 17:41 ` [PATCH v8 5/9] " Dan Murphy
2019-09-21 12:59 ` Jacek Anaszewski
2019-09-20 17:41 ` [PATCH v8 6/9] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-09-21 13:30 ` Jacek Anaszewski
2019-09-23 15:14 ` Dan Murphy
2019-09-23 21:36 ` Jacek Anaszewski
2019-09-21 18:08 ` Jacek Anaszewski
2019-09-23 15:11 ` Dan Murphy
2019-09-20 17:41 ` [PATCH v8 7/9] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-09-21 15:13 ` Jacek Anaszewski
2019-09-23 15:28 ` Dan Murphy
2019-09-23 21:42 ` Jacek Anaszewski
2019-09-24 14:52 ` Dan Murphy
2019-09-20 17:41 ` [PATCH v8 8/9] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-09-21 15:11 ` Jacek Anaszewski
2019-09-23 17:56 ` Dan Murphy
2019-09-23 21:59 ` Jacek Anaszewski
2019-09-20 17:41 ` [PATCH v8 9/9] leds: Update the lp55xx to use the multi color framework Dan Murphy
2019-09-21 18:06 ` Jacek Anaszewski
[not found] ` <b3ba9d9f-5267-8184-e858-e09b4debcdb6@ti.com>
2019-09-23 22:13 ` Jacek Anaszewski
2019-09-22 8:29 ` kbuild test robot
2019-09-20 17:44 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ff2638-8952-e8a3-0c59-ac87f63d24c0@infradead.org \
--to=rdunlap@infradead.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox