Re: [PATCH v8 2/9] documention: leds: Add multicolor class documentation

[Jacek Anaszewski <jacek.anaszewski@gmail.com>]

Dan,

On 9/23/19 4:50 PM, Dan Murphy wrote:
> Jacek
> 
> Thanks for the review
> 
> On 9/21/19 7:28 AM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 9/20/19 7:41 PM, Dan Murphy wrote:
>>> Add the support documentation on the multicolor LED framework.
>>> This document defines the directores and file generated by the
>> Now there will be one directory created.
>>
>> Apart from that - all documentation should go in the same patch
>> as the feature being added. So patches 1,2 and 3 should be melded
>> together.
> 
> I think only patches 1 & 2 should be squashed into a single patch.
> 
> Patch 3 are the dt-bindings which should be separated

Right.

>>> multicolor framework.  It also documents usage.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> ---
>>>   Documentation/leds/index.rst                 |  1 +
>>>   Documentation/leds/leds-class-multicolor.rst | 91 ++++++++++++++++++++
>>>   2 files changed, 92 insertions(+)
>>>   create mode 100644 Documentation/leds/leds-class-multicolor.rst
>>>
>>> diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst
>>> index 060f4e485897..bc70c6aa7138 100644
>>> --- a/Documentation/leds/index.rst
>>> +++ b/Documentation/leds/index.rst
>>> @@ -9,6 +9,7 @@ LEDs
>>>        leds-class
>>>      leds-class-flash
>>> +   leds-class-multicolor
>>>      ledtrig-oneshot
>>>      ledtrig-transient
>>>      ledtrig-usbport
>>> diff --git a/Documentation/leds/leds-class-multicolor.rst
>>> b/Documentation/leds/leds-class-multicolor.rst
>>> new file mode 100644
>>> index 000000000000..063c9a411a1d
>>> --- /dev/null
>>> +++ b/Documentation/leds/leds-class-multicolor.rst
>>> @@ -0,0 +1,91 @@
>>> +====================================
>>> +Multi Color LED handling under Linux
>>> +====================================
>>> +
>>> +Description
>>> +===========
>>> +There are varying monochrome LED colors available for application. 
>>> These
>>> +LEDs can be used as a single use case LED or can be mixed with other
>>> color
>>> +LEDs to produce the full spectrum of color.
>> I'd say it won't be the most frequent use case. We can expect rather
>> compound RGB, RGBA[UV] etc. LED elements being connected to iouts of
>> multi color LED controllers like LP50xx. TI mentions RGB LEDs in its
>> application notes for instance. I'd mention that in the first place
>> and leave what you have above as another use case.
> 
> Which application notes are you referring to?

I don't remember if it was titled exactly AN, but I do remember a sample
PCB design using RGB LEDs mounted circle-wise to achieve the demo
sample shown in the TI LP50xx presentation videos we were discussing
somewhere in last Jan/Feb/March.

-- 
Best regards,
Jacek Anaszewski