Linux LED subsystem development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bryan Wu <cooloney@gmail.com>, Simon Guinot <simon.guinot@sequanux.org>
Cc: Richard Purdie <rpurdie@rpsys.net>,
	linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 2/2] leds: netxbig: clean up a data type issue
Date: Thu, 9 Apr 2015 12:07:12 +0300	[thread overview]
Message-ID: <20150409090712.GF17605@mwanda> (raw)

This driver is pretty hardware specific so it's unlikely that we're
going to be using it on 64 big endian systems.  Still, the current code
causes a static checker warning so we may as well change the type from
"unsigned long" to "u32" and remove the casting.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/include/linux/platform_data/leds-kirkwood-netxbig.h b/include/linux/platform_data/leds-kirkwood-netxbig.h
index d2be19a..bbd1d99 100644
--- a/include/linux/platform_data/leds-kirkwood-netxbig.h
+++ b/include/linux/platform_data/leds-kirkwood-netxbig.h
@@ -29,9 +29,9 @@ enum netxbig_led_mode {
 #define NETXBIG_LED_INVALID_MODE NETXBIG_LED_MODE_NUM
 
 struct netxbig_led_timer {
-	unsigned long		delay_on;
-	unsigned long		delay_off;
-	enum netxbig_led_mode	mode;
+	u32 delay_on;
+	u32 delay_off;
+	enum netxbig_led_mode mode;
 };
 
 struct netxbig_led {
diff --git a/drivers/leds/leds-netxbig.c b/drivers/leds/leds-netxbig.c
index d0b743c..3da87be 100644
--- a/drivers/leds/leds-netxbig.c
+++ b/drivers/leds/leds-netxbig.c
@@ -447,9 +447,9 @@ static int netxbig_leds_get_of_pdata(struct device *dev,
 			of_property_read_u32_index(np, "timers", 3 * i,
 						&timers[i].mode);
 			of_property_read_u32_index(np, "timers", 3 * i + 1,
-						(u32 *) &timers[i].delay_on);
+						   &timers[i].delay_on);
 			of_property_read_u32_index(np, "timers", 3 * i + 2,
-						(u32 *) &timers[i].delay_off);
+						   &timers[i].delay_off);
 		}
 		pdata->timer = timers;
 		pdata->num_timer = num_timers;

             reply	other threads:[~2015-04-09  9:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  9:07 Dan Carpenter [this message]
2015-04-09 19:25 ` [patch 2/2] leds: netxbig: clean up a data type issue Simon Guinot
2015-04-09 19:54   ` Dan Carpenter
2015-04-10  0:25     ` Simon Guinot
2015-04-10  8:30       ` [patch 2/2 v2] leds: netxbig: silence a static checker warning Dan Carpenter
2015-04-10 14:18         ` Jacek Anaszewski
2015-04-10 14:30           ` Dan Carpenter
2015-04-10 14:41             ` Simon Guinot
2015-04-10 15:50               ` Dan Carpenter
2015-04-10 19:52                 ` Simon Guinot
2015-04-13  7:35                   ` Jacek Anaszewski
2015-04-13 10:16                     ` Simon Guinot
2015-04-13 10:54                       ` Jacek Anaszewski
2015-04-13 10:16                   ` Dan Carpenter
2015-04-10 14:30         ` Simon Guinot
2015-04-13  8:25           ` Gregory CLEMENT
2015-04-13  9:20             ` Simon Guinot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409090712.GF17605@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=cooloney@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=simon.guinot@sequanux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox