From: Dan Carpenter <dan.carpenter@oracle.com>
To: Simon Guinot <simon.guinot@sequanux.org>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2 v2] leds: netxbig: silence a static checker warning
Date: Fri, 10 Apr 2015 18:50:34 +0300 [thread overview]
Message-ID: <20150410155034.GK16501@mwanda> (raw)
In-Reply-To: <20150410144123.GI1509@kw.sim.vm.gnt>
I've looked at this some more. Most of the places which call
of_property_read_u32_index() check the return code. The ones that don't
mostly initialize their values going in. The remainder introduce static
checker warnings like:
drivers/clk/ti/divider.c:472 ti_clk_get_div_table()
error: potentially using uninitialized 'val'.
These warnings cause me pain. It calls of_get_property() earlier so
it won't return -EINVAL. I don't know if it can return -ENODATA or
-EOVERFLOW?
I guess not.
Honestly, I hate ambigous code like this. If it were just a clear bug
then I could fix it but I invest more time in ambiguous code and end
up not writing a patch.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-10 15:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 9:07 [patch 2/2] leds: netxbig: clean up a data type issue Dan Carpenter
2015-04-09 19:25 ` Simon Guinot
2015-04-09 19:54 ` Dan Carpenter
2015-04-10 0:25 ` Simon Guinot
2015-04-10 8:30 ` [patch 2/2 v2] leds: netxbig: silence a static checker warning Dan Carpenter
2015-04-10 14:18 ` Jacek Anaszewski
2015-04-10 14:30 ` Dan Carpenter
2015-04-10 14:41 ` Simon Guinot
2015-04-10 15:50 ` Dan Carpenter [this message]
2015-04-10 19:52 ` Simon Guinot
2015-04-13 7:35 ` Jacek Anaszewski
2015-04-13 10:16 ` Simon Guinot
2015-04-13 10:54 ` Jacek Anaszewski
2015-04-13 10:16 ` Dan Carpenter
2015-04-10 14:30 ` Simon Guinot
2015-04-13 8:25 ` Gregory CLEMENT
2015-04-13 9:20 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410155034.GK16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cooloney@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=simon.guinot@sequanux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox