Re: [patch 2/2 v2] leds: netxbig: silence a static checker warning

[Simon Guinot <simon.guinot@sequanux.org>]

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Mon, Apr 13, 2015 at 10:25:45AM +0200, Gregory CLEMENT wrote:
> Hi Simon, Dan,
> 
> On 10/04/2015 16:30, Simon Guinot wrote:
> > On Fri, Apr 10, 2015 at 11:30:41AM +0300, Dan Carpenter wrote:
> >> Static checkers complain that "timers[i].delay_on" is an unsigned long
> >> but we're writing to only 32 bits of it.  The code works on 32 bit
> >> systems and little endian 64 bit systems so it doesn't cause a problem
> >> in practise but it's still better to silence the warning.
> >>
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > Acked-by: Simon Guinot <simon.guinot@sequanux.org>
> > 
> > Note that your patch applies on the top of a patch "leds: netxbig: add 
> > device tree binding" which has not been merged yet by Bryan. For now,
> > this patch only sits in the mvebu/for-next branch for testing purpose.
> > And it is still not clear to me in which tree the patch will go. That's
> > why I think you should resend your patch to the mvebu maintainers (added
> > in Cc) on the LAKML. Probably they will be interested in merging your
> > clean-up patch in the mvebu/for-next branch as well.
> 
> Actually the reason to get all the series in mvebu/for-next was to be
> confident enough to make a pull request as soon as the driver part was
> acked by the maintainer. Unfortunately it didn't occur until now and
> the merge windows for arm-soc is now closed so it won't be part of
> v4.1 (at least the mvebu related part).

Hi Gregory,

Thanks for your efforts. I'll try again with v4.2 ...

Simon

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]