[PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency

[PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Without the device handler support, the driver fails to link:

ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!

Add a Kconfig dependency to only show the symbol if it can
be enabled.

Fixes: 6173959c7d4d ("leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/leds/rgb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index 983f50b7ed2d..3f6786616a7d 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -4,7 +4,7 @@ if LEDS_CLASS_MULTICOLOR
 
 config LEDS_ASUS_AURA_SCSI
 	tristate "ASUS Aura RGB LEDs on ROG external NVMe enclosures"
-	depends on SCSI
+	depends on SCSI && SCSI_DH
 	help
 	  Say Y here if you want to control the RGB LEDs of ASUS ROG
 	  external NVMe enclosures such as the ROG STRIX Arion. The LEDs
-- 
2.53.0

Re: [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: asus-aura-scsi: commit subject description is not capitalized
--

commit e05e6430efbaa79461253555061a0b258c6afe65
Author: Arnd Bergmann <arnd@arndb.de>

leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency

This commit adds a Kconfig dependency on SCSI_DH to LEDS_ASUS_AURA_SCSI in
drivers/leds/rgb/Kconfig so the driver does not fail to link when
scsi_register_device_handler is unavailable.

>     leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency
>     
>     Without the device handler support, the driver fails to link:
>     
>     ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!
>     
>     Add a Kconfig dependency to only show the symbol if it can
>     be enabled.
>     
>     Fixes: 6173959c7d4d ("leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures")
>     Signed-off-by: Arnd Bergmann <arnd@arndb.de>

[Severity: Low]
This isn't a bug, but in the commit subject for this LEDS_ASUS_AURA_SCSI
change in drivers/leds/rgb/Kconfig, should the description after the
"leds: asus-aura-scsi: " prefix start with a capital letter to match the LED
subsystem convention (i.e., "leds: asus-aura-scsi: Add CONFIG_SCSI_DH
dependency")?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104142415.676757-1-arnd@kernel.org?part=1

Re: [PATCH] leds: asus-aura-scsi: add CONFIG_SCSI_DH dependency

[Liang Haowen]

On Wed, 4 Nov 2026, Arnd Bergmann wrote:

> Without the device handler support, the driver fails to link:
>
> ERROR: modpost: drivers/leds/rgb/leds-asus-aura-scsi.ko: symbol 'scsi_register_device_handler' undefined!
>
> Add a Kconfig dependency to only show the symbol if it can
> be enabled.

Correct, the handler registration lives under SCSI_DH, so the driver
cannot link without it. My Kconfig entry missed the dependency.

Acked-by: Liang Haowen <nbg2974@gmail.com>