* [PATCH] leds: as3668: correct name of config option to match Makefile
@ 2026-06-10 22:42 Ethan Nelson-Moore
2026-06-12 20:16 ` Lukas Timmermann
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-10 22:42 UTC (permalink / raw)
To: Lee Jones, Lukas Timmermann, linux-leds
Cc: Ethan Nelson-Moore, stable, Pavel Machek
The Makefile for the AS3668 LED driver refers to CONFIG_LEDS_AS3668,
whereas the config file defines CONFIG_LEDS_OSRAM_AMS_AS3668. This
causes the driver to never be compiled. Correct the name in the Kconfig
file to match the Makefile. Doing the opposite would also have worked,
but the name in the Makefile better matches the format of other
drivers' options.
Fixes: c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver")
Cc: stable@vger.kernel.org # 7.0+
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/leds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index f4a0a3c8c870..5ac63cb59469 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -107,7 +107,7 @@ config LEDS_ARIEL
Say Y to if your machine is a Dell Wyse 3020 thin client.
-config LEDS_OSRAM_AMS_AS3668
+config LEDS_AS3668
tristate "LED support for Osram AMS AS3668"
depends on LEDS_CLASS
depends on I2C
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: as3668: correct name of config option to match Makefile
2026-06-10 22:42 [PATCH] leds: as3668: correct name of config option to match Makefile Ethan Nelson-Moore
@ 2026-06-12 20:16 ` Lukas Timmermann
0 siblings, 0 replies; 2+ messages in thread
From: Lukas Timmermann @ 2026-06-12 20:16 UTC (permalink / raw)
To: Ethan Nelson-Moore, Lee Jones, linux-leds; +Cc: stable, Pavel Machek
On Wed, Jun 10, 2026 at 03:42:43PM -0700, Ethan Nelson-Moore wrote:
> The Makefile for the AS3668 LED driver refers to CONFIG_LEDS_AS3668,
> whereas the config file defines CONFIG_LEDS_OSRAM_AMS_AS3668. This
> causes the driver to never be compiled. Correct the name in the Kconfig
> file to match the Makefile. Doing the opposite would also have worked,
> but the name in the Makefile better matches the format of other
> drivers' options.
>
> Fixes: c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver")
> Cc: stable@vger.kernel.org # 7.0+
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
> drivers/leds/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index f4a0a3c8c870..5ac63cb59469 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -107,7 +107,7 @@ config LEDS_ARIEL
>
> Say Y to if your machine is a Dell Wyse 3020 thin client.
>
> -config LEDS_OSRAM_AMS_AS3668
> +config LEDS_AS3668
> tristate "LED support for Osram AMS AS3668"
> depends on LEDS_CLASS
> depends on I2C
> --
> 2.43.0
>
>
Hi Ethan,
thank you for noticing that issue.
This was already fixed here:
https://lore.kernel.org/all/177815964265.1857555.230971455145782585.b4-ty@b4/
Best regards
Lukas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-12 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 22:42 [PATCH] leds: as3668: correct name of config option to match Makefile Ethan Nelson-Moore
2026-06-12 20:16 ` Lukas Timmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox