[PATCH] m68k: Atari EtherNAT - use NETDEV_TX_OK instead of 0 in ndo_start_xmit()

[PATCH] m68k: Atari EtherNAT - use NETDEV_TX_OK instead of 0 in ndo_start_xmit()

[Geert Uytterhoeven]

Cfr. commit 6ed106549d17474ca17a16057f4c0ed4eba5a7ca ("net: use NETDEV_TX_OK
instead of 0 in ndo_start_xmit() functions")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/atari_91C111.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
index 87e2327..3b53ff9 100644
--- a/drivers/net/atari_91C111.c
+++ b/drivers/net/atari_91C111.c
@@ -711,7 +711,7 @@ static int smc_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		dev->stats.tx_errors++;
 		dev->stats.tx_dropped++;
 		dev_kfree_skb(skb);
-		return 0;
+		return NETDEV_TX_OK;
 	}
 
 	smc_special_lock(&lp->lock);
@@ -748,7 +748,7 @@ static int smc_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		smc_hardware_send_pkt((unsigned long)dev);
 	}
 
-	return 0;
+	return NETDEV_TX_OK;
 }
 
 /*
-- 
1.6.0.4

[PATCH] m68k: Atari EtherNAT - restore MTU change operation

[Geert Uytterhoeven]

Cfr. commit 635ecaa70e862f85f652581305fe0074810893be ("netdev: restore MTU
change operation")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/atari_91C111.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
index 3b53ff9..86dbe19 100644
--- a/drivers/net/atari_91C111.c
+++ b/drivers/net/atari_91C111.c
@@ -1718,6 +1718,7 @@ static const struct net_device_ops smc_netdev_ops = {
 	.ndo_start_xmit		= smc_hard_start_xmit,
 	.ndo_tx_timeout		= smc_timeout,
 	.ndo_set_multicast_list	= smc_set_multicast_list,
+	.ndo_change_mtu		= eth_change_mtu,
 	.ndo_validate_addr	= eth_validate_addr,
 	.ndo_set_mac_address 	= eth_mac_addr,
 #ifdef CONFIG_NET_POLL_CONTROLLER
-- 
1.6.0.4

[PATCH] m68k: Atari EtherNAT - let smc91x work well under netpoll

[Geert Uytterhoeven]

Cfr. commit 8ff499e43c537648399fca8ba39d24c0768b3fab ("smc91x: let smc91x work
well under netpoll")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/atari_91C111.c |   40 ++++++++++++++++++++++------------------
 1 files changed, 22 insertions(+), 18 deletions(-)

diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
index 86dbe19..1da485f 100644
--- a/drivers/net/atari_91C111.c
+++ b/drivers/net/atari_91C111.c
@@ -228,21 +228,23 @@ static void PRINT_PKT(u_char *buf, int length)
 /* this enables an interrupt in the interrupt mask register */
 #define SMC_ENABLE_INT(lp, x) do {					\
 	unsigned char mask;						\
-	spin_lock_irq(&lp->lock);					\
+	unsigned long smc_enable_flags;					\
+	spin_lock_irqsave(&lp->lock, smc_enable_flags);			\
 	mask = SMC_GET_INT_MASK(lp);					\
 	mask |= (x);							\
 	SMC_SET_INT_MASK(lp, mask);					\
-	spin_unlock_irq(&lp->lock);					\
+	spin_unlock_irqrestore(&lp->lock, smc_enable_flags);		\
 } while (0)
 
 /* this disables an interrupt from the interrupt mask register */
 #define SMC_DISABLE_INT(lp, x) do {					\
 	unsigned char mask;						\
-	spin_lock_irq(&lp->lock);					\
+	unsigned long smc_disable_flags;				\
+	spin_lock_irqsave(&lp->lock, smc_disable_flags);		\
 	mask = SMC_GET_INT_MASK(lp);					\
 	mask &= ~(x);							\
 	SMC_SET_INT_MASK(lp, mask);					\
-	spin_unlock_irq(&lp->lock);					\
+	spin_unlock_irqrestore(&lp->lock, smc_disable_flags);		\
 } while (0)
 
 /*
@@ -572,21 +574,21 @@ static inline void  smc_rcv(struct net_device *dev)
  * any other concurrent access and C would always interrupt B. But life
  * isn't that easy in a SMP world...
  */
-#define smc_special_trylock(lock)					\
+#define smc_special_trylock(lock, flags)				\
 ({									\
 	int __ret;							\
-	local_irq_disable();						\
+	local_irq_save(flags);						\
 	__ret = spin_trylock(lock);					\
 	if (!__ret)							\
-		local_irq_enable();					\
+		local_irq_restore(flags);				\
 	__ret;								\
 })
-#define smc_special_lock(lock)		spin_lock_irq(lock)
-#define smc_special_unlock(lock)	spin_unlock_irq(lock)
+#define smc_special_lock(lock, flags)		spin_lock_irq(lock, flags)
+#define smc_special_unlock(lock, flags) 	spin_unlock_irqrestore(lock, flags)
 #else
-#define smc_special_trylock(lock)	(1)
-#define smc_special_lock(lock)		do { } while (0)
-#define smc_special_unlock(lock)	do { } while (0)
+#define smc_special_trylock(lock, flags)	(1)
+#define smc_special_lock(lock, flags)   	do { } while (0)
+#define smc_special_unlock(lock, flags)	do { } while (0)
 #endif
 
 /*
@@ -604,10 +606,11 @@ static void smc_hardware_send_pkt(unsigned long data)
 	struct sk_buff *skb;
 	unsigned int packet_no, len;
 	unsigned char *buf;
+	unsigned long flags;
 
 	DBG(3, "%s: %s\n", dev->name, __func__);
 
-	if (!smc_special_trylock(&lp->lock)) {
+	if (!smc_special_trylock(&lp->lock, flags)) {
 		netif_stop_queue(dev);
 		tasklet_schedule(&lp->tx_task);
 		return;
@@ -615,7 +618,7 @@ static void smc_hardware_send_pkt(unsigned long data)
 
 	skb = lp->pending_tx_skb;
 	if (unlikely(!skb)) {
-		smc_special_unlock(&lp->lock);
+		smc_special_unlock(&lp->lock, flags);
 		return;
 	}
 	lp->pending_tx_skb = NULL;
@@ -625,7 +628,7 @@ static void smc_hardware_send_pkt(unsigned long data)
 		printk("%s: Memory allocation failed.\n", dev->name);
 		dev->stats.tx_errors++;
 		dev->stats.tx_fifo_errors++;
-		smc_special_unlock(&lp->lock);
+		smc_special_unlock(&lp->lock, flags);
 		goto done;
 	}
 
@@ -664,7 +667,7 @@ static void smc_hardware_send_pkt(unsigned long data)
 
 	/* queue the packet for TX */
 	SMC_SET_MMU_CMD(lp, MC_ENQUEUE);
-	smc_special_unlock(&lp->lock);
+	smc_special_unlock(&lp->lock, flags);
 
 	dev->trans_start = jiffies;
 	dev->stats.tx_packets++;
@@ -689,6 +692,7 @@ static int smc_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	struct smc_local *lp = netdev_priv(dev);
 	void __iomem *ioaddr = lp->base;
 	unsigned int numPages, poll_count, status;
+	unsigned long flags;
 
 	DBG(3, "%s: %s\n", dev->name, __func__);
 
@@ -714,7 +718,7 @@ static int smc_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		return NETDEV_TX_OK;
 	}
 
-	smc_special_lock(&lp->lock);
+	smc_special_lock(&lp->lock, flags);
 
 	/* now, try to allocate the memory */
 	SMC_SET_MMU_CMD(lp, MC_ALLOC | numPages);
@@ -732,7 +736,7 @@ static int smc_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		}
    	} while (--poll_count);
 
-	smc_special_unlock(&lp->lock);
+	smc_special_unlock(&lp->lock, flags);
 
 	lp->pending_tx_skb = skb;
    	if (!poll_count) {
-- 
1.6.0.4

[PATCH] m68k: Atari EtherNAT - fix compilation on SMP

[Geert Uytterhoeven]

Cfr. commit 0b4f2928f14c4a9770b0866923fc81beb7f4aa57 ("smc91x: fix compilation
on SMP")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/atari_91C111.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
index 1da485f..b71367d 100644
--- a/drivers/net/atari_91C111.c
+++ b/drivers/net/atari_91C111.c
@@ -583,7 +583,7 @@ static inline void  smc_rcv(struct net_device *dev)
 		local_irq_restore(flags);				\
 	__ret;								\
 })
-#define smc_special_lock(lock, flags)		spin_lock_irq(lock, flags)
+#define smc_special_lock(lock, flags)		spin_lock_irqsave(lock, flags)
 #define smc_special_unlock(lock, flags) 	spin_unlock_irqrestore(lock, flags)
 #else
 #define smc_special_trylock(lock, flags)	(1)
-- 
1.6.0.4

[PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Geert Uytterhoeven]

Cfr. commit 2f82af08fcc7dc01a7e98a49a5995a77e32a2925 ("Nicolas Pitre has a new
email address")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/atari_91C111.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
index b71367d..b579ead 100644
--- a/drivers/net/atari_91C111.c
+++ b/drivers/net/atari_91C111.c
@@ -35,7 +35,7 @@
  *
  * contributors:
  * 	Daris A Nevil <dnevil@snmc.com>
- *      Nicolas Pitre <nico@cam.org>
+ *      Nicolas Pitre <nico@fluxnic.net>
  *	Russell King <rmk@arm.linux.org.uk>
  *
  * History:
-- 
1.6.0.4

[PATCH] m68k: Atari EtherNAT - convert print_mac to %pM

[Geert Uytterhoeven]

Cfr. commit e174961ca1a0b28f7abf0be47973ad57cb74e5f0 ("net: convert print_mac
to %pM")

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/atari_91C111.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/atari_91C111.c b/drivers/net/atari_91C111.c
index b579ead..0b92b94 100644
--- a/drivers/net/atari_91C111.c
+++ b/drivers/net/atari_91C111.c
@@ -1824,7 +1824,6 @@ static int __devinit smc_probe(struct net_device *dev, void __iomem *ioaddr,
 	int retval;
 	unsigned int val, revision_register;
 	const char *version_string;
-	DECLARE_MAC_BUF(mac);
 
 	DBG(2, "%s: %s\n", CARDNAME, __func__);
 
@@ -2016,12 +2015,12 @@ static int __devinit smc_probe(struct net_device *dev, void __iomem *ioaddr,
 			printk("%s: Invalid ethernet MAC address.  Please "
 			       "set using ifconfig\n", dev->name);
 			random_ether_addr(dev->dev_addr);
-			printk(KERN_INFO "%s: Ethernet addr set (random): %s\n",
-			       dev->name, print_mac(mac, dev->dev_addr));
+			printk(KERN_INFO "%s: Ethernet addr set (random): %pM\n",
+			       dev->name, dev->dev_addr);
 		} else {
 			/* Print the Ethernet address */
-			printk("%s: Ethernet addr: %s\n",
-			       dev->name, print_mac(mac, dev->dev_addr));
+			printk("%s: Ethernet addr: %pM\n",
+			       dev->name, dev->dev_addr);
 		}
 
 		if (lp->phy_type == 0) {
-- 
1.6.0.4

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Michael Schmitz]

Hi Geert,

> Cfr. commit 2f82af08fcc7dc01a7e98a49a5995a77e32a2925 ("Nicolas Pitre has a new
> email address")

Thanks - I've started a fresh attempt to get the Atari kernel built and tested 
but I only get 'double bus fault' from ARAnyM regardless of cross compiler used. 
No console output, seems to happen before console init. 

You still test kernels on ARAnyM, do you? What kernel version was the last Atari 
defconfig based on? 

Cheers,

	Michael

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Geert Uytterhoeven]

On Mon, Jan 4, 2010 at 04:49, Michael Schmitz
<schmitz@biophys.uni-duesseldorf.de> wrote:
> Thanks - I've started a fresh attempt to get the Atari kernel built and tested
> but I only get 'double bus fault' from ARAnyM regardless of cross compiler used.
> No console output, seems to happen before console init.

I remember seeing this as well a long time ago, due to some
bug/misconfiguration. But that
got fixed.

> You still test kernels on ARAnyM, do you? What kernel version was the last Atari

Sure!

> defconfig based on?

According to its header:
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.30-rc3
# Wed Apr 22 20:47:56 2009

The actual config I'm using is slightly different as we're at 2.6.33-rc2 now.
I'll build `atari_defconfig' on current linux-m68k/master and will
give it a try.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Geert Uytterhoeven]

On Mon, Jan 4, 2010 at 08:27, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Jan 4, 2010 at 04:49, Michael Schmitz
> <schmitz@biophys.uni-duesseldorf.de> wrote:
>> Thanks - I've started a fresh attempt to get the Atari kernel built and tested
>> but I only get 'double bus fault' from ARAnyM regardless of cross compiler used.
>> No console output, seems to happen before console init.
>
> I remember seeing this as well a long time ago, due to some
> bug/misconfiguration. But that
> got fixed.
>
>> You still test kernels on ARAnyM, do you? What kernel version was the last Atari
>
> Sure!
>
>> defconfig based on?
>
> According to its header:
> # Automatically generated make config: don't edit
> # Linux kernel version: 2.6.30-rc3
> # Wed Apr 22 20:47:56 2009
>
> The actual config I'm using is slightly different as we're at 2.6.33-rc2 now.
> I'll build `atari_defconfig' on current linux-m68k/master and will
> give it a try.

Runs fine:

Linux version 2.6.33-rc2-atari-00203-gdd8abd9 (geert@ayla) (gcc
version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)) #1 Mon Jan 4
08:27:54 CET 2010

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Michael Schmitz]

Hi Geert,

> >> Thanks - I've started a fresh attempt to get the Atari kernel built and tested
> >> but I only get 'double bus fault' from ARAnyM regardless of cross compiler used.
> >> No console output, seems to happen before console init.
> >
> > I remember seeing this as well a long time ago, due to some
> > bug/misconfiguration. But that
> > got fixed.

I'll dig through the mailbox ... 

> > The actual config I'm using is slightly different as we're at 2.6.33-rc2 now.
> > I'll build `atari_defconfig' on current linux-m68k/master and will
> > give it a try.
> 
> Runs fine:
> 
> Linux version 2.6.33-rc2-atari-00203-gdd8abd9 (geert@ayla) (gcc
> version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)) #1 Mon Jan 4
> 08:27:54 CET 2010

Can you send that kernel and the defconfig by PM please? 

I tested one of the failing kernels on the real Falcon and it did spontaenously 
reboot there (with no output) as well. 

Thanks,

  Michael

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Geert Uytterhoeven]

On Thu, Jan 7, 2010 at 03:08, Michael Schmitz
<schmitz@biophys.uni-duesseldorf.de> wrote:
>> >> Thanks - I've started a fresh attempt to get the Atari kernel built and tested
>> >> but I only get 'double bus fault' from ARAnyM regardless of cross compiler used.
>> >> No console output, seems to happen before console init.
>> >
>> > I remember seeing this as well a long time ago, due to some
>> > bug/misconfiguration. But that
>> > got fixed.
>
> I'll dig through the mailbox ...

BTW, IIRC there were also some issues with some version of binutils,
but I never saw that problem.

gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)
GNU assembler (GNU Binutils) 2.18.0.20080103

My binutils is 2.18.1~cvs20080103-7 according to dpkg.

>> > The actual config I'm using is slightly different as we're at 2.6.33-rc2 now.
>> > I'll build `atari_defconfig' on current linux-m68k/master and will
>> > give it a try.
>>
>> Runs fine:
>>
>> Linux version 2.6.33-rc2-atari-00203-gdd8abd9 (geert@ayla) (gcc
>> version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)) #1 Mon Jan 4
>> 08:27:54 CET 2010
>
> Can you send that kernel and the defconfig by PM please?

Done.

> I tested one of the failing kernels on the real Falcon and it did spontaenously
> reboot there (with no output) as well.

Strange.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Michael Schmitz]

Hi Geert,

> >> > I remember seeing this as well a long time ago, due to some
> >> > bug/misconfiguration. But that
> >> > got fixed.
> >
> > I'll dig through the mailbox ...
> 
> BTW, IIRC there were also some issues with some version of binutils,
> but I never saw that problem.
> 
> gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)
> GNU assembler (GNU Binutils) 2.18.0.20080103

The 4.1.0 I built does not get past the compiler test now (miscompiles __weak).

My copy of crosstool (0.43) combines 4.1.0 and 4.1.1 (the latest supported) with 
binutils 2.16.1 ... I'll give 2.18 a try. 

3.3.6 is built with 2.15 - the m68k crosstool 0.38 build script of Christian did 
use 2.16. 

Probably no matter though - building 2.6.33 with my old cross compiler once I 
had revived that from the failing disk (3.3.6/2.16) results in the same double 
fault.
 
> My binutils is 2.18.1~cvs20080103-7 according to dpkg.

2.18.1~cvs20080103-0ubuntu1 ... what is the host binutils even used for? 
 
> > Can you send that kernel and the defconfig by PM please?
> 
> Done.

Thanks, testing ... yours does in fact boot on my ARAnyM setup. Compiling with 
your .config results in the same error. 
 
> > I tested one of the failing kernels on the real Falcon and it did spontaenously
> > reboot there (with no output) as well.
> 
> Strange.

Yep - I'll try to compile the last kernel version that worked for me to see what
the various cross compilers generate for that. 2.6.30-rc6 (botched git pull so 
I'm not too positive it isn't 2.6.29-something) does in fact compile fine with 
my old 3.3.6 cross-gcc as well as my newly built one. 

I'll verify that on the new tree, and start bisecting. Sigh. 

Cheers,

	Michael

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Geert Uytterhoeven]

On Fri, Jan 8, 2010 at 02:15, Michael Schmitz
<schmitz@biophys.uni-duesseldorf.de> wrote:
>> >> > I remember seeing this as well a long time ago, due to some
>> >> > bug/misconfiguration. But that
>> >> > got fixed.
>> >
>> > I'll dig through the mailbox ...
>>
>> BTW, IIRC there were also some issues with some version of binutils,
>> but I never saw that problem.
>>
>> gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)
>> GNU assembler (GNU Binutils) 2.18.0.20080103
>
> The 4.1.0 I built does not get past the compiler test now (miscompiles __weak).

Indeed.

> My copy of crosstool (0.43) combines 4.1.0 and 4.1.1 (the latest supported) with
> binutils 2.16.1 ... I'll give 2.18 a try.
>
> 3.3.6 is built with 2.15 - the m68k crosstool 0.38 build script of Christian did
> use 2.16.
>
> Probably no matter though - building 2.6.33 with my old cross compiler once I
> had revived that from the failing disk (3.3.6/2.16) results in the same double
> fault.
>
>> My binutils is 2.18.1~cvs20080103-7 according to dpkg.
>
> 2.18.1~cvs20080103-0ubuntu1 ... what is the host binutils even used for?

That's actually binutils-m68k-linux-gnu, built per instructions from RomanZ.

>> > Can you send that kernel and the defconfig by PM please?
>>
>> Done.
>
> Thanks, testing ... yours does in fact boot on my ARAnyM setup. Compiling with
> your .config results in the same error.

OK, so it's your toolchain.

>> > I tested one of the failing kernels on the real Falcon and it did spontaenously
>> > reboot there (with no output) as well.
>>
>> Strange.
>
> Yep - I'll try to compile the last kernel version that worked for me to see what
> the various cross compilers generate for that. 2.6.30-rc6 (botched git pull so
> I'm not too positive it isn't 2.6.29-something) does in fact compile fine with
> my old 3.3.6 cross-gcc as well as my newly built one.
>
> I'll verify that on the new tree, and start bisecting. Sigh.

Good luck!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Michael Schmitz]

Hi Geert,

> > 2.18.1~cvs20080103-0ubuntu1 ... what is the host binutils even used for?
> 
> That's actually binutils-m68k-linux-gnu, built per instructions from RomanZ.

OK; I'll try and use that.

> > your .config results in the same error.
> 
> OK, so it's your toolchain.

3.3.6 and its binutils most likely. See below.
 
> > I'll verify that on the new tree, and start bisecting. Sigh.
> 
> Good luck!

7c5fd5619dc89fb52d2c2cf144fc6e4365427b86 is first bad commit
commit 7c5fd5619dc89fb52d2c2cf144fc6e4365427b86
Author: Tim Abbott <tabbott@ksplice.com>
Date:   Sun Sep 27 13:57:55 2009 -0400

    m68k: Cleanup linker scripts using new linker script macros.
    
    Signed-off-by: Tim Abbott <tabbott@ksplice.com>
    Tested-by: Andreas Schwab <schwab@linux-m68k.org>
    Cc: Roman Zippel <zippel@linux-m68k.org>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

:040000 040000 5bdbf7ce5dd4ea2f23669c6a6ec11192865b5bfa 
d3b7397533b0af6261747ccef3cff9cd40f6baf9 M	arch

Seems the linker script is not 3.3.6 safe?

	Michael

Re: [PATCH] m68k: Atari EtherNAT - Nicolas Pitre has a new email address

[Michael Schmitz]

Hi Geert,

> > > I'll verify that on the new tree, and start bisecting. Sigh.
> > 
> > Good luck!
> 
> 7c5fd5619dc89fb52d2c2cf144fc6e4365427b86 is first bad commit
> commit 7c5fd5619dc89fb52d2c2cf144fc6e4365427b86
> Author: Tim Abbott <tabbott@ksplice.com>
> Date:   Sun Sep 27 13:57:55 2009 -0400
> 
>     m68k: Cleanup linker scripts using new linker script macros.
>     
>     Signed-off-by: Tim Abbott <tabbott@ksplice.com>
>     Tested-by: Andreas Schwab <schwab@linux-m68k.org>
>     Cc: Roman Zippel <zippel@linux-m68k.org>
>     Cc: Sam Ravnborg <sam@ravnborg.org>
>     Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> :040000 040000 5bdbf7ce5dd4ea2f23669c6a6ec11192865b5bfa 
> d3b7397533b0af6261747ccef3cff9cd40f6baf9 M	arch

Backing out that commit on the top of the tree results in a bootable 
2.6.33-rc2 for me

The order of symbols in the system map is different (as you would expect)
but I don't see what implicit assumption woule be violated.

	Michael