From: Ezequiel Garcia <elezegarcia@gmail.com>
To: geert@linux-m68k.org
Cc: linux-m68k@lists.linux-m68k.org, Ezequiel Garcia <elezegarcia@gmail.com>
Subject: [RFC/PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent()
Date: Mon, 23 Apr 2012 11:11:58 -0300 [thread overview]
Message-ID: <1335190318-9155-1-git-send-email-elezegarcia@gmail.com> (raw)
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
---
To define or to inline that is the question:
The current definition of flat_set_persistent produces a compiler
warning; arch/sh/ does it in a different way defining it to
a macro that uses persistent var. IMHO, an inline is easier to read.
---
arch/m68k/include/asm/flat.h | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/include/asm/flat.h b/arch/m68k/include/asm/flat.h
index a0e2907..f9454b8 100644
--- a/arch/m68k/include/asm/flat.h
+++ b/arch/m68k/include/asm/flat.h
@@ -11,6 +11,11 @@
#define flat_get_addr_from_rp(rp, relval, flags, p) get_unaligned(rp)
#define flat_put_addr_at_rp(rp, val, relval) put_unaligned(val,rp)
#define flat_get_relocate_addr(rel) (rel)
-#define flat_set_persistent(relval, p) 0
+
+static inline int flat_set_persistent(unsigned long relval,
+ unsigned long *persistent)
+{
+ return 0;
+}
#endif /* __M68KNOMMU_FLAT_H__ */
--
1.7.3.4
next reply other threads:[~2012-04-23 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 14:11 Ezequiel Garcia [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-23 13:50 [RFC/PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent() Ezequiel Garcia
2012-04-23 21:07 ` Geert Uytterhoeven
2012-04-23 22:43 ` Ezequiel García
2012-04-24 2:13 ` Greg Ungerer
2012-04-24 2:35 ` Ezequiel García
2012-04-24 3:10 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335190318-9155-1-git-send-email-elezegarcia@gmail.com \
--to=elezegarcia@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox