From: Greg Ungerer <gerg@snapgear.com>
To: "Ezequiel García" <elezegarcia@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org,
uClinux development list <uclinux-dev@uclinux.org>
Subject: Re: [RFC/PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent()
Date: Tue, 24 Apr 2012 13:10:57 +1000 [thread overview]
Message-ID: <4F9619C1.4050802@snapgear.com> (raw)
In-Reply-To: <CALF0-+UKvv+cebcH8s1oBpUEPguMQspV3PmjjGt6NYH-4PqS6A@mail.gmail.com>
Hi Ezequiel,
On 24/04/12 12:35, Ezequiel García wrote:
> 2012/4/23 Greg Ungerer<gerg@snapgear.com>:
>>
>> Normally this signed-off-by goes after your patch description
>> (Documentation/SubmittingPatches section 12).
>
> I know. That text wasn't intended to be part of the commit message, it was
> to trigger the discussion. I'll resend the patch with a proper commit message,
> including the warning.
Ok, sorry, I thought that was supposed to be the commit message.
> Same warning will appear on every other arch, since the only one using
> flat_set_persistent() is arch/blackfin...
> do you think it would be nice to submit that also (to the proper
> lists, of course)?
Yes, I think that is a good idea.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-04-24 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 13:50 [RFC/PATCH] m68k: fix compiler warning by properly inlining flat_set_persistent() Ezequiel Garcia
2012-04-23 21:07 ` Geert Uytterhoeven
2012-04-23 22:43 ` Ezequiel García
2012-04-24 2:13 ` Greg Ungerer
2012-04-24 2:35 ` Ezequiel García
2012-04-24 3:10 ` Greg Ungerer [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-23 14:11 Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9619C1.4050802@snapgear.com \
--to=gerg@snapgear.com \
--cc=elezegarcia@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox