From: <gerg@snapgear.com>
To: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org, sfking@fdwdc.com
Cc: Greg Ungerer <gerg@uclinux.org>
Subject: [PATCH 03/22] m68knommu: switch to GPIO init macros in ColdFire 520x init code
Date: Thu, 26 Apr 2012 10:25:43 +1000 [thread overview]
Message-ID: <1335399962-10308-4-git-send-email-gerg@snapgear.com> (raw)
In-Reply-To: <1335399962-10308-1-git-send-email-gerg@snapgear.com>
From: Greg Ungerer <gerg@uclinux.org>
Modify the GPIO setup table to use the mcfgpio.h macros for table init.
Simplifies code and reduces line count significantly.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
arch/m68k/platform/520x/gpio.c | 149 ++-------------------------------------
1 files changed, 8 insertions(+), 141 deletions(-)
diff --git a/arch/m68k/platform/520x/gpio.c b/arch/m68k/platform/520x/gpio.c
index 9bcc3e4..96b3685 100644
--- a/arch/m68k/platform/520x/gpio.c
+++ b/arch/m68k/platform/520x/gpio.c
@@ -21,147 +21,14 @@
#include <asm/mcfgpio.h>
static struct mcf_gpio_chip mcf_gpio_chips[] = {
- {
- .gpio_chip = {
- .label = "PIRQ",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value,
- .ngpio = 8,
- },
- .pddr = (void __iomem *) MCFEPORT_EPDDR,
- .podr = (void __iomem *) MCFEPORT_EPDR,
- .ppdr = (void __iomem *) MCFEPORT_EPPDR,
- },
- {
- .gpio_chip = {
- .label = "CS",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 9,
- .ngpio = 3,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_CS,
- .podr = (void __iomem *) MCFGPIO_PODR_CS,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_CS,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_CS,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_CS,
- },
- {
- .gpio_chip = {
- .label = "FECI2C",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 16,
- .ngpio = 4,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_FECI2C,
- .podr = (void __iomem *) MCFGPIO_PODR_FECI2C,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_FECI2C,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_FECI2C,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_FECI2C,
- },
- {
- .gpio_chip = {
- .label = "QSPI",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 24,
- .ngpio = 4,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_QSPI,
- .podr = (void __iomem *) MCFGPIO_PODR_QSPI,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_QSPI,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_QSPI,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_QSPI,
- },
- {
- .gpio_chip = {
- .label = "TIMER",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 32,
- .ngpio = 4,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_TIMER,
- .podr = (void __iomem *) MCFGPIO_PODR_TIMER,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_TIMER,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_TIMER,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_TIMER,
- },
- {
- .gpio_chip = {
- .label = "UART",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 40,
- .ngpio = 8,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_UART,
- .podr = (void __iomem *) MCFGPIO_PODR_UART,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_UART,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_UART,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_UART,
- },
- {
- .gpio_chip = {
- .label = "FECH",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 48,
- .ngpio = 8,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_FECH,
- .podr = (void __iomem *) MCFGPIO_PODR_FECH,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_FECH,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_FECH,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_FECH,
- },
- {
- .gpio_chip = {
- .label = "FECL",
- .request = mcf_gpio_request,
- .free = mcf_gpio_free,
- .direction_input = mcf_gpio_direction_input,
- .direction_output = mcf_gpio_direction_output,
- .get = mcf_gpio_get_value,
- .set = mcf_gpio_set_value_fast,
- .base = 56,
- .ngpio = 8,
- },
- .pddr = (void __iomem *) MCFGPIO_PDDR_FECL,
- .podr = (void __iomem *) MCFGPIO_PODR_FECL,
- .ppdr = (void __iomem *) MCFGPIO_PPDSDR_FECL,
- .setr = (void __iomem *) MCFGPIO_PPDSDR_FECL,
- .clrr = (void __iomem *) MCFGPIO_PCLRR_FECL,
- },
+ MCFGPS(PIRQ, 0, 8, MCFEPORT_EPDDR, MCFEPORT_EPDR, MCFEPORT_EPPDR),
+ MCFGPF(CS, 9, 3),
+ MCFGPF(FECI2C, 16, 4),
+ MCFGPF(QSPI, 24, 4),
+ MCFGPF(TIMER, 32, 4),
+ MCFGPF(UART, 40, 8),
+ MCFGPF(FECH, 48, 8),
+ MCFGPF(FECL, 56, 8),
};
static int __init mcf_gpio_init(void)
--
1.7.0.4
next prev parent reply other threads:[~2012-04-26 0:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 0:25 [PATCH 00/22] m68knommu: simplify ColdFire GPIO init code gerg
2012-04-26 0:25 ` [PATCH 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization gerg
2012-04-26 7:16 ` Philippe De Muyter
2012-04-26 9:59 ` Greg Ungerer
2012-04-26 0:25 ` [PATCH 02/22] m68knommu: switch to GPIO init macros in ColdFire 5206 init code gerg
2012-04-26 0:25 ` gerg [this message]
2012-04-26 0:25 ` [PATCH 04/22] m68knommu: switch to GPIO init macros in ColdFire 523x " gerg
2012-04-26 0:25 ` [PATCH 05/22] m68knommu: switch to GPIO init macros in ColdFire 5249 " gerg
2012-04-26 0:25 ` [PATCH 06/22] m68knommu: switch to GPIO init macros in ColdFire 5272 " gerg
2012-04-26 0:25 ` [PATCH 07/22] m68knommu: switch to GPIO init macros in ColdFire 527x " gerg
2012-04-26 0:25 ` [PATCH 08/22] m68knommu: switch to GPIO init macros in ColdFire 528x " gerg
2012-04-27 2:49 ` Finn Thain
2012-04-27 6:36 ` Greg Ungerer
2012-04-26 0:25 ` [PATCH 09/22] m68knommu: switch to GPIO init macros in ColdFire 5307 " gerg
2012-04-26 0:25 ` [PATCH 10/22] m68knommu: switch to GPIO init macros in ColdFire 5407 " gerg
2012-04-26 0:25 ` [PATCH 11/22] m68knommu: switch to GPIO init macros in ColdFire 532x " gerg
2012-04-26 0:25 ` [PATCH 12/22] m68knommu: make duplicated ColdFire GPIO init code common for all gerg
2012-04-26 0:25 ` [PATCH 13/22] m68knommu: simplify the ColdFire 5206 GPIO struct setup gerg
2012-04-26 0:25 ` [PATCH 14/22] m68knommu: simplify the ColdFire 520x " gerg
2012-04-26 0:25 ` [PATCH 15/22] m68knommu: simplify the ColdFire 523x " gerg
2012-04-26 0:25 ` [PATCH 16/22] m68knommu: simplify the ColdFire 5249 " gerg
2012-04-26 0:25 ` [PATCH 17/22] m68knommu: simplify the ColdFire 5272 " gerg
2012-04-26 0:25 ` [PATCH 18/22] m68knommu: simplify the ColdFire 527x " gerg
2012-04-26 0:25 ` [PATCH 19/22] m68knommu: simplify the ColdFire 528x " gerg
2012-04-26 0:26 ` [PATCH 20/22] m68knommu: simplify the ColdFire 5307 " gerg
2012-04-26 0:26 ` [PATCH 21/22] m68knommu: simplify the ColdFire 532x " gerg
2012-04-26 0:36 ` mohamed nabil
2012-04-26 0:45 ` Greg Ungerer
2012-04-26 16:14 ` Lennart Sorensen
2012-04-26 20:45 ` burcu sariozlu
2012-04-26 0:26 ` [PATCH 22/22] m68knommu: simplify the ColdFire 5407 " gerg
2012-04-26 7:28 ` [PATCH 00/22] m68knommu: simplify ColdFire GPIO init code Steven King
2012-04-26 10:02 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335399962-10308-4-git-send-email-gerg@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sfking@fdwdc.com \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox