From: Greg Ungerer <gerg@snapgear.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization
Date: Thu, 26 Apr 2012 19:59:23 +1000 [thread overview]
Message-ID: <4F991C7B.2030406@snapgear.com> (raw)
In-Reply-To: <20120426071610.GA31640@frolo.macqel>
Hi Philippe,
On 04/26/2012 05:16 PM, Philippe De Muyter wrote:
> Hi Greg,
>
> On Thu, Apr 26, 2012 at 10:25:41AM +1000, gerg@snapgear.com wrote:
>> From: Greg Ungerer<gerg@uclinux.org>
>>
>> We have very large tables in the ColdFire CPU GPIO setup code that essentially
>> boil down to 2 distinct types of GPIO pin initiaization. Using 2 macros we can
>> reduce these large tables to at most a dozen lines of setup code, and in quite
>> a few cases a single table entry.
>>
>> Introduce these 2 macros into the existing mcfgpio.h header.
> ...
>> +/*
>> + * Define macros to ease the pain of setting up the gpio tables.
>> + */
>> +#define MCFGPS(mlabel, mbase, mngpio, mpddr, mpodr, mppdr) \
> ...
>> +#define MCFGPF(mlabel, mbase, mngpio) \
> ...
>
> Maybe a small comment to explain when to use MCFGPS and when to use MCFGPF ?
Yep, that sounds like a good idea. I'll do that.
Thanks
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
next prev parent reply other threads:[~2012-04-26 9:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 0:25 [PATCH 00/22] m68knommu: simplify ColdFire GPIO init code gerg
2012-04-26 0:25 ` [PATCH 01/22] m68knommu: introduce macros to simplify ColdFire GPIO table initialization gerg
2012-04-26 7:16 ` Philippe De Muyter
2012-04-26 9:59 ` Greg Ungerer [this message]
2012-04-26 0:25 ` [PATCH 02/22] m68knommu: switch to GPIO init macros in ColdFire 5206 init code gerg
2012-04-26 0:25 ` [PATCH 03/22] m68knommu: switch to GPIO init macros in ColdFire 520x " gerg
2012-04-26 0:25 ` [PATCH 04/22] m68knommu: switch to GPIO init macros in ColdFire 523x " gerg
2012-04-26 0:25 ` [PATCH 05/22] m68knommu: switch to GPIO init macros in ColdFire 5249 " gerg
2012-04-26 0:25 ` [PATCH 06/22] m68knommu: switch to GPIO init macros in ColdFire 5272 " gerg
2012-04-26 0:25 ` [PATCH 07/22] m68knommu: switch to GPIO init macros in ColdFire 527x " gerg
2012-04-26 0:25 ` [PATCH 08/22] m68knommu: switch to GPIO init macros in ColdFire 528x " gerg
2012-04-27 2:49 ` Finn Thain
2012-04-27 6:36 ` Greg Ungerer
2012-04-26 0:25 ` [PATCH 09/22] m68knommu: switch to GPIO init macros in ColdFire 5307 " gerg
2012-04-26 0:25 ` [PATCH 10/22] m68knommu: switch to GPIO init macros in ColdFire 5407 " gerg
2012-04-26 0:25 ` [PATCH 11/22] m68knommu: switch to GPIO init macros in ColdFire 532x " gerg
2012-04-26 0:25 ` [PATCH 12/22] m68knommu: make duplicated ColdFire GPIO init code common for all gerg
2012-04-26 0:25 ` [PATCH 13/22] m68knommu: simplify the ColdFire 5206 GPIO struct setup gerg
2012-04-26 0:25 ` [PATCH 14/22] m68knommu: simplify the ColdFire 520x " gerg
2012-04-26 0:25 ` [PATCH 15/22] m68knommu: simplify the ColdFire 523x " gerg
2012-04-26 0:25 ` [PATCH 16/22] m68knommu: simplify the ColdFire 5249 " gerg
2012-04-26 0:25 ` [PATCH 17/22] m68knommu: simplify the ColdFire 5272 " gerg
2012-04-26 0:25 ` [PATCH 18/22] m68knommu: simplify the ColdFire 527x " gerg
2012-04-26 0:25 ` [PATCH 19/22] m68knommu: simplify the ColdFire 528x " gerg
2012-04-26 0:26 ` [PATCH 20/22] m68knommu: simplify the ColdFire 5307 " gerg
2012-04-26 0:26 ` [PATCH 21/22] m68knommu: simplify the ColdFire 532x " gerg
2012-04-26 0:36 ` mohamed nabil
2012-04-26 0:45 ` Greg Ungerer
2012-04-26 16:14 ` Lennart Sorensen
2012-04-26 20:45 ` burcu sariozlu
2012-04-26 0:26 ` [PATCH 22/22] m68knommu: simplify the ColdFire 5407 " gerg
2012-04-26 7:28 ` [PATCH 00/22] m68knommu: simplify ColdFire GPIO init code Steven King
2012-04-26 10:02 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F991C7B.2030406@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=phdm@macqel.be \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox