public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-m68k@vger.kernel.org
Cc: geert@linux-m68k.org, davem@davemloft.net, linux-ide@vger.kernel.org
Subject: [PATCH] Do not register the IDE interrupt handler if host->get_lock is set.
Date: Sat,  1 Feb 2014 13:48:12 +1300	[thread overview]
Message-ID: <1391215693-2880-1-git-send-email-schmitz@debian.org> (raw)

The m68k Atari Falcon IDE driver shares the IDE interrupt with DMA completion,
SCSI and floppy controller. The DMA controller does not provide a way to check
whether it had generated an interrupt, so the shared interrupt has to be
reserved for exclusive use by the respective driver.
To this end, host->get_lock was added to allow both locking the interrupt
and passing the relevant interrupt handler to the machine specific interrupt
code. This feature is used exclusively by the Falcon IDE driver.
Unconditionally registering the IDE interrupt handler in init_irq() when
host->get_lock is set does result in two calls being dispatched to the IDE
handler on each IDE interrupt, and one spurious call on each SCSI, DMA or 
floppy interrupt.

The following patch changes init_irq() to request the IDE interrupt only if
host->get_lock is not set.

Regards,

	Michael Schmitz

             reply	other threads:[~2014-02-01  0:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-01  0:48 Michael Schmitz [this message]
2014-02-01  0:48 ` [PATCH] m68k/atari - ide: do not register interrupt if host->get_lock is set Michael Schmitz
2014-03-04 20:59   ` David Miller
2014-03-06  6:47     ` Michael Schmitz
2014-03-06 17:50       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391215693-2880-1-git-send-email-schmitz@debian.org \
    --to=schmitzmic@gmail.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox