public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: linux-m68k@vger.kernel.org, schmitz@debian.org,
	linux-ide@vger.kernel.org, geert@linux-m68k.org
Subject: Re: [PATCH] m68k/atari - ide: do not register interrupt if host->get_lock is set
Date: Thu, 6 Mar 2014 19:47:06 +1300	[thread overview]
Message-ID: <540db7ba6339cc907a63fb7a615aaa7e@gmail.com> (raw)
In-Reply-To: <20140304.155906.221185723445733090.davem@davemloft.net>

Thanks Dave,

>> On m68k, host->get_lock is used to both lock and register the 
>> interrupt
>> that the IDE host shares with other device drivers. Registering the
>> IDE interrupt handler in ide-probe.c results in duplicating the
>> interrupt registered (once via host->get lock, and also via 
>> init_irq()),
>> and may result in IDE accepting interrupts even when another driver 
>> has
>> locked the interrupt hardware. This opens the whole locking scheme up
>> to races.
>>
>> host->get_lock is set on m68k only, so other drivers' behaviour is not
>> changed.
>>
>> Signed-off-by: Michael Schmitz <schmitz@debian.org>
>
> It's a bit kludgy, but minimal and correct.

Would you have preferred to use a host flag instead?

> Applied, thank you.

Thanks again,

	Michael

  reply	other threads:[~2014-03-06  6:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-01  0:48 [PATCH] Do not register the IDE interrupt handler if host->get_lock is set Michael Schmitz
2014-02-01  0:48 ` [PATCH] m68k/atari - ide: do not register interrupt " Michael Schmitz
2014-03-04 20:59   ` David Miller
2014-03-06  6:47     ` Michael Schmitz [this message]
2014-03-06 17:50       ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-01-28  8:07 [PATCH 0/1] " Michael Schmitz
2014-01-28  8:07 ` [PATCH] " Michael Schmitz
2014-01-30 15:03   ` Geert Uytterhoeven
2014-01-30 19:41     ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540db7ba6339cc907a63fb7a615aaa7e@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schmitz@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox