From: David Miller <davem@davemloft.net>
To: schmitzmic@gmail.com
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org,
linux-ide@vger.kernel.org, schmitz@debian.org
Subject: Re: [PATCH] m68k/atari - ide: do not register interrupt if host->get_lock is set
Date: Tue, 04 Mar 2014 15:59:06 -0500 (EST) [thread overview]
Message-ID: <20140304.155906.221185723445733090.davem@davemloft.net> (raw)
In-Reply-To: <1391215693-2880-2-git-send-email-schmitz@debian.org>
From: Michael Schmitz <schmitzmic@gmail.com>
Date: Sat, 1 Feb 2014 13:48:13 +1300
> On m68k, host->get_lock is used to both lock and register the interrupt
> that the IDE host shares with other device drivers. Registering the
> IDE interrupt handler in ide-probe.c results in duplicating the
> interrupt registered (once via host->get lock, and also via init_irq()),
> and may result in IDE accepting interrupts even when another driver has
> locked the interrupt hardware. This opens the whole locking scheme up
> to races.
>
> host->get_lock is set on m68k only, so other drivers' behaviour is not
> changed.
>
> Signed-off-by: Michael Schmitz <schmitz@debian.org>
It's a bit kludgy, but minimal and correct.
Applied, thank you.
next prev parent reply other threads:[~2014-03-04 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 0:48 [PATCH] Do not register the IDE interrupt handler if host->get_lock is set Michael Schmitz
2014-02-01 0:48 ` [PATCH] m68k/atari - ide: do not register interrupt " Michael Schmitz
2014-03-04 20:59 ` David Miller [this message]
2014-03-06 6:47 ` Michael Schmitz
2014-03-06 17:50 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-01-28 8:07 [PATCH 0/1] " Michael Schmitz
2014-01-28 8:07 ` [PATCH] " Michael Schmitz
2014-01-30 15:03 ` Geert Uytterhoeven
2014-01-30 19:41 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304.155906.221185723445733090.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@debian.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox