* [PATCH] m68knommu: clean up uClinux boot log output
@ 2016-09-09 1:10 Greg Ungerer
2016-09-09 6:21 ` Geert Uytterhoeven
2016-09-09 14:20 ` Andreas Schwab
0 siblings, 2 replies; 6+ messages in thread
From: Greg Ungerer @ 2016-09-09 1:10 UTC (permalink / raw)
To: linux-m68k; +Cc: Greg Ungerer
During the arch setup phase of kernel boot we print out in the boot banner
that we are uClinux configured. The printk currently contains a bunch of
useless newlines and carriage returns - producing wastefull empty lines.
Remove these.
Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
---
arch/m68k/kernel/setup_no.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
index 72d272e..a160695 100644
--- a/arch/m68k/kernel/setup_no.c
+++ b/arch/m68k/kernel/setup_no.c
@@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
process_uboot_commandline(&command_line[0], sizeof(command_line));
#endif /* CONFIG_UBOOT */
- printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
+ printk(KERN_INFO "uClinux with CPU " CPU_NAME "\n");
#ifdef CONFIG_UCDIMM
printk(KERN_INFO "uCdimm by Lineo, Inc. <www.lineo.com>\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] m68knommu: clean up uClinux boot log output
2016-09-09 1:10 [PATCH] m68knommu: clean up uClinux boot log output Greg Ungerer
@ 2016-09-09 6:21 ` Geert Uytterhoeven
2016-09-09 6:47 ` Greg Ungerer
2016-09-09 14:20 ` Andreas Schwab
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-09-09 6:21 UTC (permalink / raw)
To: Greg Ungerer; +Cc: Linux/m68k
On Fri, Sep 9, 2016 at 3:10 AM, Greg Ungerer <gerg@linux-m68k.org> wrote:
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
> process_uboot_commandline(&command_line[0], sizeof(command_line));
> #endif /* CONFIG_UBOOT */
>
> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
> + printk(KERN_INFO "uClinux with CPU " CPU_NAME "\n");
pr_info() while you're at it?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] m68knommu: clean up uClinux boot log output
2016-09-09 6:21 ` Geert Uytterhoeven
@ 2016-09-09 6:47 ` Greg Ungerer
0 siblings, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2016-09-09 6:47 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux/m68k
Hi Geert,
On 09/09/16 16:21, Geert Uytterhoeven wrote:
> On Fri, Sep 9, 2016 at 3:10 AM, Greg Ungerer <gerg@linux-m68k.org> wrote:
>> --- a/arch/m68k/kernel/setup_no.c
>> +++ b/arch/m68k/kernel/setup_no.c
>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>> process_uboot_commandline(&command_line[0], sizeof(command_line));
>> #endif /* CONFIG_UBOOT */
>>
>> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>> + printk(KERN_INFO "uClinux with CPU " CPU_NAME "\n");
>
> pr_info() while you're at it?
If I do that I think I need to do the 12 printk's that follow
that as well :-)
Perhaps I should do that as a separate patch.
Thanks
Greg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68knommu: clean up uClinux boot log output
2016-09-09 1:10 [PATCH] m68knommu: clean up uClinux boot log output Greg Ungerer
2016-09-09 6:21 ` Geert Uytterhoeven
@ 2016-09-09 14:20 ` Andreas Schwab
2016-09-09 14:45 ` Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Schwab @ 2016-09-09 14:20 UTC (permalink / raw)
To: Greg Ungerer; +Cc: linux-m68k
On Sep 09 2016, Greg Ungerer <gerg@linux-m68k.org> wrote:
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index 72d272e..a160695 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
> process_uboot_commandline(&command_line[0], sizeof(command_line));
> #endif /* CONFIG_UBOOT */
>
> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
Do you have any idea what's the significance of ^O here?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] m68knommu: clean up uClinux boot log output
2016-09-09 14:20 ` Andreas Schwab
@ 2016-09-09 14:45 ` Geert Uytterhoeven
2016-09-10 4:54 ` Greg Ungerer
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-09-09 14:45 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Greg Ungerer, Linux/m68k
Hi Andreas,
On Fri, Sep 9, 2016 at 4:20 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Sep 09 2016, Greg Ungerer <gerg@linux-m68k.org> wrote:
>
>> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
>> index 72d272e..a160695 100644
>> --- a/arch/m68k/kernel/setup_no.c
>> +++ b/arch/m68k/kernel/setup_no.c
>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>> process_uboot_commandline(&command_line[0], sizeof(command_line));
>> #endif /* CONFIG_UBOOT */
>>
>> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>
> Do you have any idea what's the significance of ^O here?
You raised my interest, too ;-)
http://mailman.uclinux.org/pipermail/uclinux-dev//2003-March/016122.html
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] m68knommu: clean up uClinux boot log output
2016-09-09 14:45 ` Geert Uytterhoeven
@ 2016-09-10 4:54 ` Greg Ungerer
0 siblings, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2016-09-10 4:54 UTC (permalink / raw)
To: Geert Uytterhoeven, Andreas Schwab; +Cc: Linux/m68k
Hi Geert, Andreas,
On 10/09/16 00:45, Geert Uytterhoeven wrote:
> Hi Andreas,
>
> On Fri, Sep 9, 2016 at 4:20 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> On Sep 09 2016, Greg Ungerer <gerg@linux-m68k.org> wrote:
>>
>>> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
>>> index 72d272e..a160695 100644
>>> --- a/arch/m68k/kernel/setup_no.c
>>> +++ b/arch/m68k/kernel/setup_no.c
>>> @@ -106,7 +106,7 @@ void __init setup_arch(char **cmdline_p)
>>> process_uboot_commandline(&command_line[0], sizeof(command_line));
>>> #endif /* CONFIG_UBOOT */
>>>
>>> - printk(KERN_INFO "\x0F\r\n\nuClinux/" CPU_NAME "\n");
>>
>> Do you have any idea what's the significance of ^O here?
>
> You raised my interest, too ;-)
>
> http://mailman.uclinux.org/pipermail/uclinux-dev//2003-March/016122.html
The problem with the reasoning there is that this is not the
first string printed. This is what the boot console looks like
now:
Linux version 4.8.0-rc5-00014-g5594b01-dirty (gerg@goober) (gcc
version 5.4.0 (GCC) ) #2 Sat Sep 10 14:44:55 AEST 2016
uClinux/COLDFIRE(m520x)
COLDFIRE port done by Greg Ungerer, gerg@snapgear.com
Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne
Built 1 zonelists in Zone order, mobility grouping off. Total
pages: 4080
Kernel command line: root=/dev/mtdblock0
PID hash table entries: 128 (order: -4, 512 bytes)
Dentry cache hash table entries: 4096 (order: 1, 16384 bytes)
....
So you end up with 2 blank lines for no good reason.
And then there is the question of whether CTRL-O is in any way
useful here. I would argue that it is of pretty much no value
these days - if it ever was:
https://en.wikipedia.org/wiki/Shift_Out_and_Shift_In_characters
Regards
Greg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-10 4:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 1:10 [PATCH] m68knommu: clean up uClinux boot log output Greg Ungerer
2016-09-09 6:21 ` Geert Uytterhoeven
2016-09-09 6:47 ` Greg Ungerer
2016-09-09 14:20 ` Andreas Schwab
2016-09-09 14:45 ` Geert Uytterhoeven
2016-09-10 4:54 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox