* [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
@ 2017-01-19 13:34 Gideon Israel Dsouza
0 siblings, 0 replies; 7+ messages in thread
From: Gideon Israel Dsouza @ 2017-01-19 13:34 UTC (permalink / raw)
To: akpm, linux-kernel, gerg, geert, linux-m68k; +Cc: Gideon Israel Dsouza
Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
taken up, to replace gcc specific attributes with macros.
Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
crypto: Replaced gcc specific attributes with macros from compiler.h
The last commit of this task that went through you: 52f5684c8e1ec
kernel: use macros from compiler.h instead of __attribute__((...))
The next patch is for cleaning up the m68k subsystem and it requires
a new macro to wrap __attribute__ ((mode (...)))
Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>
---
include/linux/compiler-gcc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 0444b13..f1b1cfe 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -121,6 +121,7 @@
#define __attribute_const__ __attribute__((__const__))
#define __maybe_unused __attribute__((unused))
#define __always_unused __attribute__((unused))
+#define __mode __attribute__((mode(x)))
/* gcc version specific checks */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
@ 2017-01-24 12:14 Gideon Israel Dsouza
2017-01-25 1:50 ` Joe Perches
[not found] ` <1485309036.12563.46.camel@perches.com>
0 siblings, 2 replies; 7+ messages in thread
From: Gideon Israel Dsouza @ 2017-01-24 12:14 UTC (permalink / raw)
To: akpm, linux-kernel, gerg, geert, linux-m68k; +Cc: Gideon Israel Dsouza
Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
taken up, to replace gcc specific attributes with macros.
Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
crypto: Replaced gcc specific attributes with macros from compiler.h
The last commit of this task that went through you: 52f5684c8e1ec
kernel: use macros from compiler.h instead of __attribute__((...))
The next patch is for cleaning up the m68k subsystem and it requires
a new macro to wrap __attribute__ ((mode (...)))
Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>
---
include/linux/compiler-gcc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 0444b13..f1b1cfe 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -121,6 +121,7 @@
#define __attribute_const__ __attribute__((__const__))
#define __maybe_unused __attribute__((unused))
#define __always_unused __attribute__((unused))
+#define __mode __attribute__((mode(x)))
/* gcc version specific checks */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
2017-01-24 12:14 Gideon Israel Dsouza
@ 2017-01-25 1:50 ` Joe Perches
[not found] ` <1485309036.12563.46.camel@perches.com>
1 sibling, 0 replies; 7+ messages in thread
From: Joe Perches @ 2017-01-25 1:50 UTC (permalink / raw)
To: Gideon Israel Dsouza, akpm, linux-kernel, gerg, geert, linux-m68k
On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
> taken up, to replace gcc specific attributes with macros.
>
> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
> crypto: Replaced gcc specific attributes with macros from compiler.h
>
> The last commit of this task that went through you: 52f5684c8e1ec
> kernel: use macros from compiler.h instead of __attribute__((...))
>
> The next patch is for cleaning up the m68k subsystem and it requires
> a new macro to wrap __attribute__ ((mode (...)))
[]
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
[]
> @@ -121,6 +121,7 @@
> #define __attribute_const__ __attribute__((__const__))
> #define __maybe_unused __attribute__((unused))
> #define __always_unused __attribute__((unused))
> +#define __mode __attribute__((mode(x)))
Huh?
Perhaps you meant
#define __mode(x) __attribute__((mode(x)))
?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
[not found] ` <1485309036.12563.46.camel@perches.com>
@ 2017-01-25 4:50 ` Gideon D'souza
[not found] ` <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>
1 sibling, 0 replies; 7+ messages in thread
From: Gideon D'souza @ 2017-01-25 4:50 UTC (permalink / raw)
To: Joe Perches
Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
Geert Uytterhoeven, linux-m68k
>#define __mode(x) __attribute__((mode(x)))
Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> taken up, to replace gcc specific attributes with macros.
>>
>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> crypto: Replaced gcc specific attributes with macros from compiler.h
>>
>> The last commit of this task that went through you: 52f5684c8e1ec
>> kernel: use macros from compiler.h instead of __attribute__((...))
>>
>> The next patch is for cleaning up the m68k subsystem and it requires
>> a new macro to wrap __attribute__ ((mode (...)))
> []
>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> []
>> @@ -121,6 +121,7 @@
>> #define __attribute_const__ __attribute__((__const__))
>> #define __maybe_unused __attribute__((unused))
>> #define __always_unused __attribute__((unused))
>> +#define __mode __attribute__((mode(x)))
>
> Huh?
>
> Perhaps you meant
>
> #define __mode(x) __attribute__((mode(x)))
>
> ?
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
[not found] ` <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>
@ 2017-01-27 13:34 ` Gideon D'souza
[not found] ` <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>
1 sibling, 0 replies; 7+ messages in thread
From: Gideon D'souza @ 2017-01-27 13:34 UTC (permalink / raw)
To: Joe Perches
Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
Geert Uytterhoeven, linux-m68k
Ok, I noticed this went into Andrew's tree and is now in linux-next,
should I resend it?
On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote:
>>#define __mode(x) __attribute__((mode(x)))
> Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
>
> On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
>> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>>> taken up, to replace gcc specific attributes with macros.
>>>
>>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>>> crypto: Replaced gcc specific attributes with macros from compiler.h
>>>
>>> The last commit of this task that went through you: 52f5684c8e1ec
>>> kernel: use macros from compiler.h instead of __attribute__((...))
>>>
>>> The next patch is for cleaning up the m68k subsystem and it requires
>>> a new macro to wrap __attribute__ ((mode (...)))
>> []
>>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> []
>>> @@ -121,6 +121,7 @@
>>> #define __attribute_const__ __attribute__((__const__))
>>> #define __maybe_unused __attribute__((unused))
>>> #define __always_unused __attribute__((unused))
>>> +#define __mode __attribute__((mode(x)))
>>
>> Huh?
>>
>> Perhaps you meant
>>
>> #define __mode(x) __attribute__((mode(x)))
>>
>> ?
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
[not found] ` <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>
@ 2017-01-27 13:45 ` Joe Perches
[not found] ` <1485524751.12563.124.camel@perches.com>
1 sibling, 0 replies; 7+ messages in thread
From: Joe Perches @ 2017-01-27 13:45 UTC (permalink / raw)
To: Gideon D'souza
Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
Geert Uytterhoeven, linux-m68k
On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote:
> Ok, I noticed this went into Andrew's tree and is now in linux-next,
> should I resend it?
Please don't top post and perhaps Andrew can fix it up instead.
Andrew, you need to change:
#define __mode __attribute__((mode(x)))
to
#define __mode(x) __attribute__((mode(x)))
thanks.
> On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote:
> > > #define __mode(x) __attribute__((mode(x)))
> >
> > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
> >
> > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
> > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
> > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
> > > > taken up, to replace gcc specific attributes with macros.
> > > >
> > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
> > > > crypto: Replaced gcc specific attributes with macros from compiler.h
> > > >
> > > > The last commit of this task that went through you: 52f5684c8e1ec
> > > > kernel: use macros from compiler.h instead of __attribute__((...))
> > > >
> > > > The next patch is for cleaning up the m68k subsystem and it requires
> > > > a new macro to wrap __attribute__ ((mode (...)))
> > >
> > > []
> > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> > >
> > > []
> > > > @@ -121,6 +121,7 @@
> > > > #define __attribute_const__ __attribute__((__const__))
> > > > #define __maybe_unused __attribute__((unused))
> > > > #define __always_unused __attribute__((unused))
> > > > +#define __mode __attribute__((mode(x)))
> > >
> > > Huh?
> > >
> > > Perhaps you meant
> > >
> > > #define __mode(x) __attribute__((mode(x)))
> > >
> > > ?
> > >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
[not found] ` <1485524751.12563.124.camel@perches.com>
@ 2017-01-27 17:20 ` Gideon D'souza
0 siblings, 0 replies; 7+ messages in thread
From: Gideon D'souza @ 2017-01-27 17:20 UTC (permalink / raw)
To: Joe Perches
Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
Geert Uytterhoeven, linux-m68k
>Please don't top post and perhaps Andrew can fix it up instead.
What do you mean when you say "top post" I shouldn't re-send it?
On Fri, Jan 27, 2017 at 7:15 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote:
>> Ok, I noticed this went into Andrew's tree and is now in linux-next,
>> should I resend it?
>
> Please don't top post and perhaps Andrew can fix it up instead.
>
> Andrew, you need to change:
>
> #define __mode __attribute__((mode(x)))
>
> to
>
> #define __mode(x) __attribute__((mode(x)))
>
> thanks.
>
>> On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote:
>> > > #define __mode(x) __attribute__((mode(x)))
>> >
>> > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
>> >
>> > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
>> > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> > > > taken up, to replace gcc specific attributes with macros.
>> > > >
>> > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> > > > crypto: Replaced gcc specific attributes with macros from compiler.h
>> > > >
>> > > > The last commit of this task that went through you: 52f5684c8e1ec
>> > > > kernel: use macros from compiler.h instead of __attribute__((...))
>> > > >
>> > > > The next patch is for cleaning up the m68k subsystem and it requires
>> > > > a new macro to wrap __attribute__ ((mode (...)))
>> > >
>> > > []
>> > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> > >
>> > > []
>> > > > @@ -121,6 +121,7 @@
>> > > > #define __attribute_const__ __attribute__((__const__))
>> > > > #define __maybe_unused __attribute__((unused))
>> > > > #define __always_unused __attribute__((unused))
>> > > > +#define __mode __attribute__((mode(x)))
>> > >
>> > > Huh?
>> > >
>> > > Perhaps you meant
>> > >
>> > > #define __mode(x) __attribute__((mode(x)))
>> > >
>> > > ?
>> > >
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-27 17:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 13:34 [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza
-- strict thread matches above, loose matches on Subject: below --
2017-01-24 12:14 Gideon Israel Dsouza
2017-01-25 1:50 ` Joe Perches
[not found] ` <1485309036.12563.46.camel@perches.com>
2017-01-25 4:50 ` Gideon D'souza
[not found] ` <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>
2017-01-27 13:34 ` Gideon D'souza
[not found] ` <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>
2017-01-27 13:45 ` Joe Perches
[not found] ` <1485524751.12563.124.camel@perches.com>
2017-01-27 17:20 ` Gideon D'souza
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox