[PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute

public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed

* [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
@ 2017-01-24 12:14 Gideon Israel Dsouza
  2017-01-24 12:14 ` [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Gideon Israel Dsouza
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Gideon Israel Dsouza @ 2017-01-24 12:14 UTC (permalink / raw)
  To: akpm, linux-kernel, gerg, geert, linux-m68k; +Cc: Gideon Israel Dsouza

Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
taken up, to replace gcc specific attributes with macros.

Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
crypto: Replaced gcc specific attributes with macros from compiler.h

The last commit of this task that went through you: 52f5684c8e1ec
kernel: use macros from compiler.h instead of __attribute__((...))

The next patch is for cleaning up the m68k subsystem and it requires
a new macro to wrap __attribute__ ((mode (...)))

Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>
---
 include/linux/compiler-gcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 0444b13..f1b1cfe 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -121,6 +121,7 @@
 #define __attribute_const__	__attribute__((__const__))
 #define __maybe_unused		__attribute__((unused))
 #define __always_unused		__attribute__((unused))
+#define __mode                  __attribute__((mode(x)))
 
 /* gcc version specific checks */
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h
  2017-01-24 12:14 [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza
@ 2017-01-24 12:14 ` Gideon Israel Dsouza
       [not found] ` <1485260068-2495-2-git-send-email-gidisrael@gmail.com>
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 12+ messages in thread
From: Gideon Israel Dsouza @ 2017-01-24 12:14 UTC (permalink / raw)
  To: akpm, linux-kernel, gerg, geert, linux-m68k; +Cc: Gideon Israel Dsouza

There is <linux/compiler.h> which provides macros for various gcc specific
constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
instances of gcc specific attributes with the right macros for all files
under /arch/m68k

This patch depends on the previous with changes in
/include/linux/compiler-gcc.h

Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>
---
 arch/m68k/68000/bootlogo-vz.h     | 4 +++-
 arch/m68k/68000/bootlogo.h        | 4 +++-
 arch/m68k/include/asm/MC68328.h   | 3 ++-
 arch/m68k/include/asm/MC68EZ328.h | 3 ++-
 arch/m68k/include/asm/MC68VZ328.h | 2 +-
 arch/m68k/include/asm/natfeat.h   | 3 ++-
 arch/m68k/lib/ashldi3.c           | 8 ++++----
 arch/m68k/lib/ashrdi3.c           | 8 ++++----
 arch/m68k/lib/lshrdi3.c           | 8 ++++----
 arch/m68k/lib/muldi3.c            | 8 ++++----
 10 files changed, 29 insertions(+), 22 deletions(-)

diff --git a/arch/m68k/68000/bootlogo-vz.h b/arch/m68k/68000/bootlogo-vz.h
index b38e2b2..6ff09be 100644
--- a/arch/m68k/68000/bootlogo-vz.h
+++ b/arch/m68k/68000/bootlogo-vz.h
@@ -1,6 +1,8 @@
+#include <linux/compiler.h>
+
 #define splash_width 640
 #define splash_height 480
-unsigned char __attribute__ ((aligned(16))) bootlogo_bits[] = {
+unsigned char __aligned(16) bootlogo_bits[] = {
   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
diff --git a/arch/m68k/68000/bootlogo.h b/arch/m68k/68000/bootlogo.h
index b896c93..c466db3 100644
--- a/arch/m68k/68000/bootlogo.h
+++ b/arch/m68k/68000/bootlogo.h
@@ -1,6 +1,8 @@
+#include <linux/compiler.h>
+
 #define bootlogo_width 160
 #define bootlogo_height 160
-unsigned char __attribute__ ((aligned(16))) bootlogo_bits[] = {
+unsigned char __aligned(16) bootlogo_bits[] = {
   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x55, 0x01, 0x00, 0x00, 0x00,
   0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
   0x00, 0x00, 0x40, 0x55, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
diff --git a/arch/m68k/include/asm/MC68328.h b/arch/m68k/include/asm/MC68328.h
index 1a8080c..b61230e 100644
--- a/arch/m68k/include/asm/MC68328.h
+++ b/arch/m68k/include/asm/MC68328.h
@@ -8,6 +8,7 @@
  * Copyright (C) 1998  Kenneth Albanowski <kjahds@kjahds.com>,
  *
  */
+#include <linux/compiler.h>
 
 #ifndef _MC68328_H_
 #define _MC68328_H_
@@ -993,7 +994,7 @@ typedef volatile struct {
   volatile unsigned short int pad1;
   volatile unsigned short int pad2;
   volatile unsigned short int pad3;
-} __attribute__((packed)) m68328_uart;
+} __packed m68328_uart;
 
 
 /**********
diff --git a/arch/m68k/include/asm/MC68EZ328.h b/arch/m68k/include/asm/MC68EZ328.h
index fedac87..703331e 100644
--- a/arch/m68k/include/asm/MC68EZ328.h
+++ b/arch/m68k/include/asm/MC68EZ328.h
@@ -9,6 +9,7 @@
  *                     The Silver Hammer Group, Ltd.
  *
  */
+#include <linux/compiler.h>
 
 #ifndef _MC68EZ328_H_
 #define _MC68EZ328_H_
@@ -815,7 +816,7 @@ typedef volatile struct {
   volatile unsigned short int nipr;
   volatile unsigned short int pad1;
   volatile unsigned short int pad2;
-} __attribute__((packed)) m68328_uart;
+} __packed m68328_uart;
 
 
 /**********
diff --git a/arch/m68k/include/asm/MC68VZ328.h b/arch/m68k/include/asm/MC68VZ328.h
index 34a51b2..fbaed7d 100644
--- a/arch/m68k/include/asm/MC68VZ328.h
+++ b/arch/m68k/include/asm/MC68VZ328.h
@@ -909,7 +909,7 @@ typedef struct {
   volatile unsigned short int nipr;
   volatile unsigned short int hmark;
   volatile unsigned short int unused;
-} __attribute__((packed)) m68328_uart;
+} __packed m68328_uart;
 
 
 
diff --git a/arch/m68k/include/asm/natfeat.h b/arch/m68k/include/asm/natfeat.h
index a3521b8..1feceb3 100644
--- a/arch/m68k/include/asm/natfeat.h
+++ b/arch/m68k/include/asm/natfeat.h
@@ -6,6 +6,7 @@
  * This software may be used and distributed according to the terms of
  * the GNU General Public License (GPL), incorporated herein by reference.
  */
+#include <linux/compiler.h>
 
 #ifndef _NATFEAT_H
 #define _NATFEAT_H
@@ -17,6 +18,6 @@ void nf_init(void);
 void nf_shutdown(void);
 
 void nfprint(const char *fmt, ...)
-	__attribute__ ((format (printf, 1, 2)));
+	__print(1, 2);
 
 # endif /* _NATFEAT_H */
diff --git a/arch/m68k/lib/ashldi3.c b/arch/m68k/lib/ashldi3.c
index 8dffd36..ac08f81 100644
--- a/arch/m68k/lib/ashldi3.c
+++ b/arch/m68k/lib/ashldi3.c
@@ -18,10 +18,10 @@ GNU General Public License for more details. */
 
 #define BITS_PER_UNIT 8
 
-typedef		 int SItype	__attribute__ ((mode (SI)));
-typedef unsigned int USItype	__attribute__ ((mode (SI)));
-typedef		 int DItype	__attribute__ ((mode (DI)));
-typedef int word_type __attribute__ ((mode (__word__)));
+typedef		 int SItype	__mode(SI);
+typedef unsigned int USItype	__mode(SI);
+typedef		 int DItype	__mode(DI);
+typedef int word_type           __mode(__word__);
 
 struct DIstruct {SItype high, low;};
 
diff --git a/arch/m68k/lib/ashrdi3.c b/arch/m68k/lib/ashrdi3.c
index e6565a3..5837b1d 100644
--- a/arch/m68k/lib/ashrdi3.c
+++ b/arch/m68k/lib/ashrdi3.c
@@ -18,10 +18,10 @@ GNU General Public License for more details. */
 
 #define BITS_PER_UNIT 8
 
-typedef		 int SItype	__attribute__ ((mode (SI)));
-typedef unsigned int USItype	__attribute__ ((mode (SI)));
-typedef		 int DItype	__attribute__ ((mode (DI)));
-typedef int word_type __attribute__ ((mode (__word__)));
+typedef		 int SItype	__mode(SI);
+typedef unsigned int USItype	__mode(SI);
+typedef		 int DItype	__mode(DI);
+typedef int word_type           __mode(__word__);
 
 struct DIstruct {SItype high, low;};
 
diff --git a/arch/m68k/lib/lshrdi3.c b/arch/m68k/lib/lshrdi3.c
index 0397797..7f40566 100644
--- a/arch/m68k/lib/lshrdi3.c
+++ b/arch/m68k/lib/lshrdi3.c
@@ -18,10 +18,10 @@ GNU General Public License for more details. */
 
 #define BITS_PER_UNIT 8
 
-typedef		 int SItype	__attribute__ ((mode (SI)));
-typedef unsigned int USItype	__attribute__ ((mode (SI)));
-typedef		 int DItype	__attribute__ ((mode (DI)));
-typedef int word_type __attribute__ ((mode (__word__)));
+typedef		 int SItype	__mode(SI);
+typedef unsigned int USItype	__mode(SI);
+typedef		 int DItype	__mode(DI);
+typedef int word_type           __mode(__word__);
 
 struct DIstruct {SItype high, low;};
 
diff --git a/arch/m68k/lib/muldi3.c b/arch/m68k/lib/muldi3.c
index 6459af5..3fb05c6 100644
--- a/arch/m68k/lib/muldi3.c
+++ b/arch/m68k/lib/muldi3.c
@@ -65,10 +65,10 @@ GNU General Public License for more details. */
     umul_ppmm (__w.s.high, __w.s.low, u, v);				\
     __w.ll; })
 
-typedef 	 int SItype	__attribute__ ((mode (SI)));
-typedef unsigned int USItype	__attribute__ ((mode (SI)));
-typedef		 int DItype	__attribute__ ((mode (DI)));
-typedef int word_type __attribute__ ((mode (__word__)));
+typedef 	 int SItype	__mode(SI);
+typedef unsigned int USItype	__mode(SI);
+typedef		 int DItype	__mode(DI);
+typedef int word_type           __mode(__word__);
 
 struct DIstruct {SItype high, low;};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

[parent not found: <1485260068-2495-2-git-send-email-gidisrael@gmail.com>]

* Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h
       [not found] ` <1485260068-2495-2-git-send-email-gidisrael@gmail.com>
@ 2017-01-25  1:04   ` Greg Ungerer
  2017-01-25  6:54   ` kbuild test robot
  2017-01-27 16:39   ` Paul Gortmaker
  2 siblings, 0 replies; 12+ messages in thread
From: Greg Ungerer @ 2017-01-25  1:04 UTC (permalink / raw)
  To: Gideon Israel Dsouza, akpm, linux-kernel, geert, linux-m68k

On 24/01/17 22:14, Gideon Israel Dsouza wrote:
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for all files
> under /arch/m68k
> 
> This patch depends on the previous with changes in
> /include/linux/compiler-gcc.h
> 
> Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>

Acked-by: Greg Ungerer <gerg@linux-m68k.org>

Regards
Greg



> ---
>  arch/m68k/68000/bootlogo-vz.h     | 4 +++-
>  arch/m68k/68000/bootlogo.h        | 4 +++-
>  arch/m68k/include/asm/MC68328.h   | 3 ++-
>  arch/m68k/include/asm/MC68EZ328.h | 3 ++-
>  arch/m68k/include/asm/MC68VZ328.h | 2 +-
>  arch/m68k/include/asm/natfeat.h   | 3 ++-
>  arch/m68k/lib/ashldi3.c           | 8 ++++----
>  arch/m68k/lib/ashrdi3.c           | 8 ++++----
>  arch/m68k/lib/lshrdi3.c           | 8 ++++----
>  arch/m68k/lib/muldi3.c            | 8 ++++----
>  10 files changed, 29 insertions(+), 22 deletions(-)
> 
> diff --git a/arch/m68k/68000/bootlogo-vz.h b/arch/m68k/68000/bootlogo-vz.h
> index b38e2b2..6ff09be 100644
> --- a/arch/m68k/68000/bootlogo-vz.h
> +++ b/arch/m68k/68000/bootlogo-vz.h
> @@ -1,6 +1,8 @@
> +#include <linux/compiler.h>
> +
>  #define splash_width 640
>  #define splash_height 480
> -unsigned char __attribute__ ((aligned(16))) bootlogo_bits[] = {
> +unsigned char __aligned(16) bootlogo_bits[] = {
>    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> diff --git a/arch/m68k/68000/bootlogo.h b/arch/m68k/68000/bootlogo.h
> index b896c93..c466db3 100644
> --- a/arch/m68k/68000/bootlogo.h
> +++ b/arch/m68k/68000/bootlogo.h
> @@ -1,6 +1,8 @@
> +#include <linux/compiler.h>
> +
>  #define bootlogo_width 160
>  #define bootlogo_height 160
> -unsigned char __attribute__ ((aligned(16))) bootlogo_bits[] = {
> +unsigned char __aligned(16) bootlogo_bits[] = {
>    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x55, 0x01, 0x00, 0x00, 0x00,
>    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>    0x00, 0x00, 0x40, 0x55, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> diff --git a/arch/m68k/include/asm/MC68328.h b/arch/m68k/include/asm/MC68328.h
> index 1a8080c..b61230e 100644
> --- a/arch/m68k/include/asm/MC68328.h
> +++ b/arch/m68k/include/asm/MC68328.h
> @@ -8,6 +8,7 @@
>   * Copyright (C) 1998  Kenneth Albanowski <kjahds@kjahds.com>,
>   *
>   */
> +#include <linux/compiler.h>
>  
>  #ifndef _MC68328_H_
>  #define _MC68328_H_
> @@ -993,7 +994,7 @@ typedef volatile struct {
>    volatile unsigned short int pad1;
>    volatile unsigned short int pad2;
>    volatile unsigned short int pad3;
> -} __attribute__((packed)) m68328_uart;
> +} __packed m68328_uart;
>  
>  
>  /**********
> diff --git a/arch/m68k/include/asm/MC68EZ328.h b/arch/m68k/include/asm/MC68EZ328.h
> index fedac87..703331e 100644
> --- a/arch/m68k/include/asm/MC68EZ328.h
> +++ b/arch/m68k/include/asm/MC68EZ328.h
> @@ -9,6 +9,7 @@
>   *                     The Silver Hammer Group, Ltd.
>   *
>   */
> +#include <linux/compiler.h>
>  
>  #ifndef _MC68EZ328_H_
>  #define _MC68EZ328_H_
> @@ -815,7 +816,7 @@ typedef volatile struct {
>    volatile unsigned short int nipr;
>    volatile unsigned short int pad1;
>    volatile unsigned short int pad2;
> -} __attribute__((packed)) m68328_uart;
> +} __packed m68328_uart;
>  
>  
>  /**********
> diff --git a/arch/m68k/include/asm/MC68VZ328.h b/arch/m68k/include/asm/MC68VZ328.h
> index 34a51b2..fbaed7d 100644
> --- a/arch/m68k/include/asm/MC68VZ328.h
> +++ b/arch/m68k/include/asm/MC68VZ328.h
> @@ -909,7 +909,7 @@ typedef struct {
>    volatile unsigned short int nipr;
>    volatile unsigned short int hmark;
>    volatile unsigned short int unused;
> -} __attribute__((packed)) m68328_uart;
> +} __packed m68328_uart;
>  
>  
>  
> diff --git a/arch/m68k/include/asm/natfeat.h b/arch/m68k/include/asm/natfeat.h
> index a3521b8..1feceb3 100644
> --- a/arch/m68k/include/asm/natfeat.h
> +++ b/arch/m68k/include/asm/natfeat.h
> @@ -6,6 +6,7 @@
>   * This software may be used and distributed according to the terms of
>   * the GNU General Public License (GPL), incorporated herein by reference.
>   */
> +#include <linux/compiler.h>
>  
>  #ifndef _NATFEAT_H
>  #define _NATFEAT_H
> @@ -17,6 +18,6 @@ void nf_init(void);
>  void nf_shutdown(void);
>  
>  void nfprint(const char *fmt, ...)
> -	__attribute__ ((format (printf, 1, 2)));
> +	__print(1, 2);
>  
>  # endif /* _NATFEAT_H */
> diff --git a/arch/m68k/lib/ashldi3.c b/arch/m68k/lib/ashldi3.c
> index 8dffd36..ac08f81 100644
> --- a/arch/m68k/lib/ashldi3.c
> +++ b/arch/m68k/lib/ashldi3.c
> @@ -18,10 +18,10 @@ GNU General Public License for more details. */
>  
>  #define BITS_PER_UNIT 8
>  
> -typedef		 int SItype	__attribute__ ((mode (SI)));
> -typedef unsigned int USItype	__attribute__ ((mode (SI)));
> -typedef		 int DItype	__attribute__ ((mode (DI)));
> -typedef int word_type __attribute__ ((mode (__word__)));
> +typedef		 int SItype	__mode(SI);
> +typedef unsigned int USItype	__mode(SI);
> +typedef		 int DItype	__mode(DI);
> +typedef int word_type           __mode(__word__);
>  
>  struct DIstruct {SItype high, low;};
>  
> diff --git a/arch/m68k/lib/ashrdi3.c b/arch/m68k/lib/ashrdi3.c
> index e6565a3..5837b1d 100644
> --- a/arch/m68k/lib/ashrdi3.c
> +++ b/arch/m68k/lib/ashrdi3.c
> @@ -18,10 +18,10 @@ GNU General Public License for more details. */
>  
>  #define BITS_PER_UNIT 8
>  
> -typedef		 int SItype	__attribute__ ((mode (SI)));
> -typedef unsigned int USItype	__attribute__ ((mode (SI)));
> -typedef		 int DItype	__attribute__ ((mode (DI)));
> -typedef int word_type __attribute__ ((mode (__word__)));
> +typedef		 int SItype	__mode(SI);
> +typedef unsigned int USItype	__mode(SI);
> +typedef		 int DItype	__mode(DI);
> +typedef int word_type           __mode(__word__);
>  
>  struct DIstruct {SItype high, low;};
>  
> diff --git a/arch/m68k/lib/lshrdi3.c b/arch/m68k/lib/lshrdi3.c
> index 0397797..7f40566 100644
> --- a/arch/m68k/lib/lshrdi3.c
> +++ b/arch/m68k/lib/lshrdi3.c
> @@ -18,10 +18,10 @@ GNU General Public License for more details. */
>  
>  #define BITS_PER_UNIT 8
>  
> -typedef		 int SItype	__attribute__ ((mode (SI)));
> -typedef unsigned int USItype	__attribute__ ((mode (SI)));
> -typedef		 int DItype	__attribute__ ((mode (DI)));
> -typedef int word_type __attribute__ ((mode (__word__)));
> +typedef		 int SItype	__mode(SI);
> +typedef unsigned int USItype	__mode(SI);
> +typedef		 int DItype	__mode(DI);
> +typedef int word_type           __mode(__word__);
>  
>  struct DIstruct {SItype high, low;};
>  
> diff --git a/arch/m68k/lib/muldi3.c b/arch/m68k/lib/muldi3.c
> index 6459af5..3fb05c6 100644
> --- a/arch/m68k/lib/muldi3.c
> +++ b/arch/m68k/lib/muldi3.c
> @@ -65,10 +65,10 @@ GNU General Public License for more details. */
>      umul_ppmm (__w.s.high, __w.s.low, u, v);				\
>      __w.ll; })
>  
> -typedef 	 int SItype	__attribute__ ((mode (SI)));
> -typedef unsigned int USItype	__attribute__ ((mode (SI)));
> -typedef		 int DItype	__attribute__ ((mode (DI)));
> -typedef int word_type __attribute__ ((mode (__word__)));
> +typedef 	 int SItype	__mode(SI);
> +typedef unsigned int USItype	__mode(SI);
> +typedef		 int DItype	__mode(DI);
> +typedef int word_type           __mode(__word__);
>  
>  struct DIstruct {SItype high, low;};
>  
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h
       [not found] ` <1485260068-2495-2-git-send-email-gidisrael@gmail.com>
  2017-01-25  1:04   ` Greg Ungerer
@ 2017-01-25  6:54   ` kbuild test robot
  2017-01-27 16:39   ` Paul Gortmaker
  2 siblings, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2017-01-25  6:54 UTC (permalink / raw)
  Cc: kbuild-all, akpm, linux-kernel, gerg, geert, linux-m68k,
	Gideon Israel Dsouza

[-- Attachment #1: Type: text/plain, Size: 25170 bytes --]

Hi Gideon,

[auto build test ERROR on m68k/for-next]
[also build test ERROR on v4.10-rc5 next-20170124]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Gideon-Israel-Dsouza/compiler-gcc-h-Added-new-macro-for-gcc-attribute/20170125-025425
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All error/warnings (new ones prefixed by >>):

     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   include/linux/moduleparam.h:146:36: error: parameter '__param_str_major_num' is initialized
     param_check_##type(name, &(value));       \
                                       ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   include/linux/moduleparam.h:221:49: error: storage class specified for parameter '__param_major_num'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   include/linux/moduleparam.h:221:16: error: parameter '__param_major_num' is initialized
     static struct kernel_param __moduleparam_const __param_##name \
                   ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   include/linux/moduleparam.h:221:16: warning: '__used__' attribute ignored [-Wattributes]
     static struct kernel_param __moduleparam_const __param_##name \
                   ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   include/linux/moduleparam.h:221:49: error: section attribute not allowed for '__param_major_num'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   include/linux/moduleparam.h:221:49: error: alignment may not be specified for '__param_major_num'
     static struct kernel_param __moduleparam_const __param_##name \
                                                    ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from arch/m68k/emu/nfblock.c:9:
>> include/linux/compiler-gcc.h:183:45: error: storage class specified for parameter '__UNIQUE_ID_major_numtype34'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:183:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^
   include/linux/compiler-gcc.h:183:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   In file included from include/linux/thread_info.h:11:0,
                    from include/asm-generic/preempt.h:4,
                    from ./arch/m68k/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from arch/m68k/emu/nfblock.c:9:
>> include/linux/bug.h:37:45: error: parameter '__UNIQUE_ID_major_numtype34' is initialized
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                                ^
   include/linux/kernel.h:854:3: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
      BUILD_BUG_ON_ZERO((perms) & 2) +     \
      ^
>> include/linux/moduleparam.h:225:6: note: in expansion of macro 'VERIFY_OCTAL_PERMISSIONS'
         VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
         ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
>> include/linux/bug.h:37:45: warning: '__used__' attribute ignored [-Wattributes]
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
                                                ^
   include/linux/kernel.h:854:3: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
      BUILD_BUG_ON_ZERO((perms) & 2) +     \
      ^
>> include/linux/moduleparam.h:225:6: note: in expansion of macro 'VERIFY_OCTAL_PERMISSIONS'
         VERIFY_OCTAL_PERMISSIONS(perm), level, flags, { arg } }
         ^
   include/linux/moduleparam.h:167:2: note: in expansion of macro '__module_param_call'
     __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
     ^
   include/linux/moduleparam.h:147:2: note: in expansion of macro 'module_param_cb'
     module_param_cb(name, &param_ops_##type, &value, perm);     \
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from arch/m68k/emu/nfblock.c:9:
>> include/linux/compiler-gcc.h:183:45: error: section attribute not allowed for '__UNIQUE_ID_major_numtype34'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:183:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^
   include/linux/compiler-gcc.h:183:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
>> include/linux/compiler-gcc.h:183:45: error: alignment may not be specified for '__UNIQUE_ID_major_numtype34'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:183:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^
   include/linux/compiler-gcc.h:183:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^
   include/linux/moduleparam.h:30:3: note: in expansion of macro '__MODULE_INFO'
      __MODULE_INFO(parmtype, name##type, #name ":" _type)
      ^
   include/linux/moduleparam.h:148:2: note: in expansion of macro '__MODULE_PARM_TYPE'
     __MODULE_PARM_TYPE(name, #type)
     ^
   include/linux/moduleparam.h:126:2: note: in expansion of macro 'module_param_named'
     module_param_named(name, name, type, perm)
     ^
   arch/m68k/emu/nfblock.c:51:1: note: in expansion of macro 'module_param'
    module_param(major_num, int, 0);
    ^
   arch/m68k/emu/nfblock.c:53:1: warning: empty declaration
    struct nfhd_device {
    ^
   arch/m68k/emu/nfblock.c:63:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   arch/m68k/emu/nfblock.c:84:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   arch/m68k/emu/nfblock.c:94:45: error: storage class specified for parameter 'nfhd_ops'
    static const struct block_device_operations nfhd_ops = {
                                                ^
   arch/m68k/emu/nfblock.c:94:21: error: parameter 'nfhd_ops' is initialized
    static const struct block_device_operations nfhd_ops = {
                        ^
   arch/m68k/emu/nfblock.c:96:12: error: 'nfhd_getgeo' undeclared (first use in this function)
     .getgeo = nfhd_getgeo,
               ^
   arch/m68k/emu/nfblock.c:96:12: note: each undeclared identifier is reported only once for each function it appears in
   arch/m68k/emu/nfblock.c:100:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   arch/m68k/emu/nfblock.c:156:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   arch/m68k/emu/nfblock.c:180:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
    {
    ^
   In file included from arch/m68k/emu/nfblock.c:9:0:
   include/linux/module.h:131:2: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
     { return initfn; }     \
     ^
   arch/m68k/emu/nfblock.c:193:1: note: in expansion of macro 'module_init'
    module_init(nfhd_init);
    ^
   include/linux/module.h:131:2: warning: 'alias' attribute ignored [-Wattributes]
     { return initfn; }     \
     ^
   arch/m68k/emu/nfblock.c:193:1: note: in expansion of macro 'module_init'
    module_init(nfhd_init);
    ^
   arch/m68k/emu/nfblock.c:193:23: error: expected declaration specifiers before ';' token
    module_init(nfhd_init);
                          ^
   In file included from arch/m68k/emu/nfblock.c:9:0:
   include/linux/module.h:137:2: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
     { return exitfn; }     \
     ^
   arch/m68k/emu/nfblock.c:194:1: note: in expansion of macro 'module_exit'
    module_exit(nfhd_exit);
    ^
   include/linux/module.h:137:2: warning: 'alias' attribute ignored [-Wattributes]
     { return exitfn; }     \
     ^
   arch/m68k/emu/nfblock.c:194:1: note: in expansion of macro 'module_exit'
    module_exit(nfhd_exit);
    ^
   arch/m68k/emu/nfblock.c:194:23: error: expected declaration specifiers before ';' token
    module_exit(nfhd_exit);
                          ^
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from arch/m68k/emu/nfblock.c:9:
>> include/linux/compiler-gcc.h:183:45: error: storage class specified for parameter '__UNIQUE_ID_license37'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:183:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^
   include/linux/compiler-gcc.h:183:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^
   include/linux/module.h:199:34: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
                                     ^
   arch/m68k/emu/nfblock.c:196:1: note: in expansion of macro 'MODULE_LICENSE'
    MODULE_LICENSE("GPL");
    ^
>> arch/m68k/emu/nfblock.c:196:1: error: parameter '__UNIQUE_ID_license37' is initialized
   arch/m68k/emu/nfblock.c:196:1: warning: '__used__' attribute ignored [-Wattributes]
   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/list.h:4,
                    from include/linux/module.h:9,
                    from arch/m68k/emu/nfblock.c:9:
>> include/linux/compiler-gcc.h:183:45: error: section attribute not allowed for '__UNIQUE_ID_license37'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:183:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^
   include/linux/compiler-gcc.h:183:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^
   include/linux/module.h:199:34: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
                                     ^
   arch/m68k/emu/nfblock.c:196:1: note: in expansion of macro 'MODULE_LICENSE'
    MODULE_LICENSE("GPL");
    ^
>> include/linux/compiler-gcc.h:183:45: error: alignment may not be specified for '__UNIQUE_ID_license37'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                                ^
   include/linux/compiler.h:52:23: note: in definition of macro '___PASTE'
    #define ___PASTE(a,b) a##b
                          ^
   include/linux/compiler-gcc.h:183:29: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                ^
   include/linux/compiler.h:53:22: note: in expansion of macro '___PASTE'
    #define __PASTE(a,b) ___PASTE(a,b)
                         ^
   include/linux/compiler-gcc.h:183:37: note: in expansion of macro '__PASTE'
    #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
                                        ^
   include/linux/moduleparam.h:21:19: note: in expansion of macro '__UNIQUE_ID'
    static const char __UNIQUE_ID(name)[]       \
                      ^
   include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO'
    #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
                                   ^
   include/linux/module.h:199:34: note: in expansion of macro 'MODULE_INFO'
    #define MODULE_LICENSE(_license) MODULE_INFO(license, _license)
                                     ^
   arch/m68k/emu/nfblock.c:196:1: note: in expansion of macro 'MODULE_LICENSE'
    MODULE_LICENSE("GPL");
    ^
   In file included from arch/m68k/emu/nfblock.c:21:0:
   arch/m68k/include/asm/natfeat.h:20:6: error: old-style parameter declarations in prototyped function definition
    void nfprint(const char *fmt, ...)
         ^
>> arch/m68k/emu/nfblock.c:196:1: error: expected '{' at end of input
    MODULE_LICENSE("GPL");
    ^
..

vim +/__UNIQUE_ID_major_numtype34 +183 include/linux/compiler-gcc.h

cb984d10 Joe Perches 2015-06-25  167  /* Mark functions as cold. gcc will assume any path leading to a call
cb984d10 Joe Perches 2015-06-25  168   * to them will be unlikely.  This means a lot of manual unlikely()s
cb984d10 Joe Perches 2015-06-25  169   * are unnecessary now for any paths leading to the usual suspects
cb984d10 Joe Perches 2015-06-25  170   * like BUG(), printk(), panic() etc. [but let's keep them for now for
cb984d10 Joe Perches 2015-06-25  171   * older compilers]
cb984d10 Joe Perches 2015-06-25  172   *
cb984d10 Joe Perches 2015-06-25  173   * Early snapshots of gcc 4.3 don't support this and we can't detect this
cb984d10 Joe Perches 2015-06-25  174   * in the preprocessor, but we can live with this because they're unreleased.
cb984d10 Joe Perches 2015-06-25  175   * Maketime probing would be overkill here.
cb984d10 Joe Perches 2015-06-25  176   *
cb984d10 Joe Perches 2015-06-25  177   * gcc also has a __attribute__((__hot__)) to move hot functions into
cb984d10 Joe Perches 2015-06-25  178   * a special section, but I don't see any sense in this right now in
cb984d10 Joe Perches 2015-06-25  179   * the kernel context
cb984d10 Joe Perches 2015-06-25  180   */
cb984d10 Joe Perches 2015-06-25  181  #define __cold			__attribute__((__cold__))
cb984d10 Joe Perches 2015-06-25  182  
cb984d10 Joe Perches 2015-06-25 @183  #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
cb984d10 Joe Perches 2015-06-25  184  
cb984d10 Joe Perches 2015-06-25  185  #ifndef __CHECKER__
cb984d10 Joe Perches 2015-06-25  186  # define __compiletime_warning(message) __attribute__((warning(message)))
cb984d10 Joe Perches 2015-06-25  187  # define __compiletime_error(message) __attribute__((error(message)))
cb984d10 Joe Perches 2015-06-25  188  #endif /* __CHECKER__ */
cb984d10 Joe Perches 2015-06-25  189  #endif /* GCC_VERSION >= 40300 */
cb984d10 Joe Perches 2015-06-25  190  
cb984d10 Joe Perches 2015-06-25  191  #if GCC_VERSION >= 40500

:::::: The code at line 183 was first introduced by commit
:::::: cb984d101b30eb7478d32df56a0023e4603cba7f compiler-gcc: integrate the various compiler-gcc[345].h files

:::::: TO: Joe Perches <joe@perches.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38223 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h
       [not found] ` <1485260068-2495-2-git-send-email-gidisrael@gmail.com>
  2017-01-25  1:04   ` Greg Ungerer
  2017-01-25  6:54   ` kbuild test robot
@ 2017-01-27 16:39   ` Paul Gortmaker
  2017-01-27 17:18     ` Gideon D'souza
  2 siblings, 1 reply; 12+ messages in thread
From: Paul Gortmaker @ 2017-01-27 16:39 UTC (permalink / raw)
  To: Gideon Israel Dsouza
  Cc: Andrew Morton, LKML, gerg, Geert Uytterhoeven, linux-m68k,
	linux-next@vger.kernel.org

On Tue, Jan 24, 2017 at 7:14 AM, Gideon Israel Dsouza
<gidisrael@gmail.com> wrote:
> There is <linux/compiler.h> which provides macros for various gcc specific
> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
> instances of gcc specific attributes with the right macros for all files
> under /arch/m68k
>
> This patch depends on the previous with changes in

> @@ -17,6 +18,6 @@ void nf_init(void);
>  void nf_shutdown(void);
>
>  void nfprint(const char *fmt, ...)
> -       __attribute__ ((format (printf, 1, 2)));
> +       __print(1, 2);
>

You've gone from printf to print here.  This commit is breaking the
linux-next builds on m68k.  I see the kbuild bot tripped over the same
issue and did the same bisect.

http://kisskb.ellerman.id.au/kisskb/buildresult/12916834/

Paul.
--

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h
  2017-01-27 16:39   ` Paul Gortmaker
@ 2017-01-27 17:18     ` Gideon D'souza
  0 siblings, 0 replies; 12+ messages in thread
From: Gideon D'souza @ 2017-01-27 17:18 UTC (permalink / raw)
  To: Paul Gortmaker
  Cc: Andrew Morton, LKML, Greg Ungerer, Geert Uytterhoeven, linux-m68k,
	linux-next@vger.kernel.org

>You've gone from printf to print here.  This commit is breaking the
>linux-next builds on m68k.  I see the kbuild bot tripped over the same
>issue and did the same bisect.

I did do a build before sending, as you may guess I'm not on an m68k machine.

Forgive the newbie please!

I'm re-sending my patch with the correction.

On Fri, Jan 27, 2017 at 10:09 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On Tue, Jan 24, 2017 at 7:14 AM, Gideon Israel Dsouza
> <gidisrael@gmail.com> wrote:
>> There is <linux/compiler.h> which provides macros for various gcc specific
>> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all
>> instances of gcc specific attributes with the right macros for all files
>> under /arch/m68k
>>
>> This patch depends on the previous with changes in
>
>> @@ -17,6 +18,6 @@ void nf_init(void);
>>  void nf_shutdown(void);
>>
>>  void nfprint(const char *fmt, ...)
>> -       __attribute__ ((format (printf, 1, 2)));
>> +       __print(1, 2);
>>
>
> You've gone from printf to print here.  This commit is breaking the
> linux-next builds on m68k.  I see the kbuild bot tripped over the same
> issue and did the same bisect.
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12916834/
>
> Paul.
> --

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
  2017-01-24 12:14 [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza
  2017-01-24 12:14 ` [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Gideon Israel Dsouza
       [not found] ` <1485260068-2495-2-git-send-email-gidisrael@gmail.com>
@ 2017-01-25  1:50 ` Joe Perches
       [not found] ` <1485309036.12563.46.camel@perches.com>
  3 siblings, 0 replies; 12+ messages in thread
From: Joe Perches @ 2017-01-25  1:50 UTC (permalink / raw)
  To: Gideon Israel Dsouza, akpm, linux-kernel, gerg, geert, linux-m68k

On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
> taken up, to replace gcc specific attributes with macros.
> 
> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
> crypto: Replaced gcc specific attributes with macros from compiler.h
> 
> The last commit of this task that went through you: 52f5684c8e1ec
> kernel: use macros from compiler.h instead of __attribute__((...))
> 
> The next patch is for cleaning up the m68k subsystem and it requires
> a new macro to wrap __attribute__ ((mode (...)))
[]
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
[]
> @@ -121,6 +121,7 @@
>  #define __attribute_const__	__attribute__((__const__))
>  #define __maybe_unused		__attribute__((unused))
>  #define __always_unused		__attribute__((unused))
> +#define __mode                  __attribute__((mode(x)))

Huh?

Perhaps you meant

#define __mode(x)	__attribute__((mode(x)))

?

^ permalink raw reply	[flat|nested] 12+ messages in thread

[parent not found: <1485309036.12563.46.camel@perches.com>]

* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
       [not found] ` <1485309036.12563.46.camel@perches.com>
@ 2017-01-25  4:50   ` Gideon D'souza
       [not found]   ` <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>
  1 sibling, 0 replies; 12+ messages in thread
From: Gideon D'souza @ 2017-01-25  4:50 UTC (permalink / raw)
  To: Joe Perches
  Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
	Geert Uytterhoeven, linux-m68k

>#define __mode(x)       __attribute__((mode(x)))
Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.

On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> taken up, to replace gcc specific attributes with macros.
>>
>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> crypto: Replaced gcc specific attributes with macros from compiler.h
>>
>> The last commit of this task that went through you: 52f5684c8e1ec
>> kernel: use macros from compiler.h instead of __attribute__((...))
>>
>> The next patch is for cleaning up the m68k subsystem and it requires
>> a new macro to wrap __attribute__ ((mode (...)))
> []
>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> []
>> @@ -121,6 +121,7 @@
>>  #define __attribute_const__  __attribute__((__const__))
>>  #define __maybe_unused               __attribute__((unused))
>>  #define __always_unused              __attribute__((unused))
>> +#define __mode                  __attribute__((mode(x)))
>
> Huh?
>
> Perhaps you meant
>
> #define __mode(x)       __attribute__((mode(x)))
>
> ?
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

[parent not found: <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>]

* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
       [not found]   ` <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>
@ 2017-01-27 13:34     ` Gideon D'souza
       [not found]     ` <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>
  1 sibling, 0 replies; 12+ messages in thread
From: Gideon D'souza @ 2017-01-27 13:34 UTC (permalink / raw)
  To: Joe Perches
  Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
	Geert Uytterhoeven, linux-m68k

Ok, I noticed this went into Andrew's tree and is now in linux-next,
should I resend it?

On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote:
>>#define __mode(x)       __attribute__((mode(x)))
> Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
>
> On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
>> On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>>> Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>>> taken up, to replace gcc specific attributes with macros.
>>>
>>> Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>>> crypto: Replaced gcc specific attributes with macros from compiler.h
>>>
>>> The last commit of this task that went through you: 52f5684c8e1ec
>>> kernel: use macros from compiler.h instead of __attribute__((...))
>>>
>>> The next patch is for cleaning up the m68k subsystem and it requires
>>> a new macro to wrap __attribute__ ((mode (...)))
>> []
>>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> []
>>> @@ -121,6 +121,7 @@
>>>  #define __attribute_const__  __attribute__((__const__))
>>>  #define __maybe_unused               __attribute__((unused))
>>>  #define __always_unused              __attribute__((unused))
>>> +#define __mode                  __attribute__((mode(x)))
>>
>> Huh?
>>
>> Perhaps you meant
>>
>> #define __mode(x)       __attribute__((mode(x)))
>>
>> ?
>>

^ permalink raw reply	[flat|nested] 12+ messages in thread

[parent not found: <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>]

* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
       [not found]     ` <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>
@ 2017-01-27 13:45       ` Joe Perches
       [not found]       ` <1485524751.12563.124.camel@perches.com>
  1 sibling, 0 replies; 12+ messages in thread
From: Joe Perches @ 2017-01-27 13:45 UTC (permalink / raw)
  To: Gideon D'souza
  Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
	Geert Uytterhoeven, linux-m68k

On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote:
> Ok, I noticed this went into Andrew's tree and is now in linux-next,
> should I resend it?

Please don't top post and perhaps Andrew can fix it up instead.

Andrew, you need to change:

#define __mode		__attribute__((mode(x)))

to

#define __mode(x)	__attribute__((mode(x)))

thanks.

> On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote:
> > > #define __mode(x)       __attribute__((mode(x)))
> > 
> > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
> > 
> > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
> > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
> > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
> > > > taken up, to replace gcc specific attributes with macros.
> > > > 
> > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
> > > > crypto: Replaced gcc specific attributes with macros from compiler.h
> > > > 
> > > > The last commit of this task that went through you: 52f5684c8e1ec
> > > > kernel: use macros from compiler.h instead of __attribute__((...))
> > > > 
> > > > The next patch is for cleaning up the m68k subsystem and it requires
> > > > a new macro to wrap __attribute__ ((mode (...)))
> > > 
> > > []
> > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> > > 
> > > []
> > > > @@ -121,6 +121,7 @@
> > > >  #define __attribute_const__  __attribute__((__const__))
> > > >  #define __maybe_unused               __attribute__((unused))
> > > >  #define __always_unused              __attribute__((unused))
> > > > +#define __mode                  __attribute__((mode(x)))
> > > 
> > > Huh?
> > > 
> > > Perhaps you meant
> > > 
> > > #define __mode(x)       __attribute__((mode(x)))
> > > 
> > > ?
> > > 

^ permalink raw reply	[flat|nested] 12+ messages in thread

[parent not found: <1485524751.12563.124.camel@perches.com>]

* Re: [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
       [not found]       ` <1485524751.12563.124.camel@perches.com>
@ 2017-01-27 17:20         ` Gideon D'souza
  0 siblings, 0 replies; 12+ messages in thread
From: Gideon D'souza @ 2017-01-27 17:20 UTC (permalink / raw)
  To: Joe Perches
  Cc: Andrew Morton, linux-kernel@vger.kernel.org, Greg Ungerer,
	Geert Uytterhoeven, linux-m68k

>Please don't top post and perhaps Andrew can fix it up instead.

What do you mean when you say "top post" I shouldn't re-send it?

On Fri, Jan 27, 2017 at 7:15 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-01-27 at 19:04 +0530, Gideon D'souza wrote:
>> Ok, I noticed this went into Andrew's tree and is now in linux-next,
>> should I resend it?
>
> Please don't top post and perhaps Andrew can fix it up instead.
>
> Andrew, you need to change:
>
> #define __mode          __attribute__((mode(x)))
>
> to
>
> #define __mode(x)       __attribute__((mode(x)))
>
> thanks.
>
>> On Wed, Jan 25, 2017 at 10:20 AM, Gideon D'souza <gidisrael@gmail.com> wrote:
>> > > #define __mode(x)       __attribute__((mode(x)))
>> >
>> > Well that's embarrassing. I so sorry for the trouble guys :( I'll resend this.
>> >
>> > On Wed, Jan 25, 2017 at 7:20 AM, Joe Perches <joe@perches.com> wrote:
>> > > On Tue, 2017-01-24 at 17:44 +0530, Gideon Israel Dsouza wrote:
>> > > > Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
>> > > > taken up, to replace gcc specific attributes with macros.
>> > > >
>> > > > Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
>> > > > crypto: Replaced gcc specific attributes with macros from compiler.h
>> > > >
>> > > > The last commit of this task that went through you: 52f5684c8e1ec
>> > > > kernel: use macros from compiler.h instead of __attribute__((...))
>> > > >
>> > > > The next patch is for cleaning up the m68k subsystem and it requires
>> > > > a new macro to wrap __attribute__ ((mode (...)))
>> > >
>> > > []
>> > > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> > >
>> > > []
>> > > > @@ -121,6 +121,7 @@
>> > > >  #define __attribute_const__  __attribute__((__const__))
>> > > >  #define __maybe_unused               __attribute__((unused))
>> > > >  #define __always_unused              __attribute__((unused))
>> > > > +#define __mode                  __attribute__((mode(x)))
>> > >
>> > > Huh?
>> > >
>> > > Perhaps you meant
>> > >
>> > > #define __mode(x)       __attribute__((mode(x)))
>> > >
>> > > ?
>> > >

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute
@ 2017-01-19 13:34 Gideon Israel Dsouza
  0 siblings, 0 replies; 12+ messages in thread
From: Gideon Israel Dsouza @ 2017-01-19 13:34 UTC (permalink / raw)
  To: akpm, linux-kernel, gerg, geert, linux-m68k; +Cc: Gideon Israel Dsouza

Added __mode(x) into compiler-gcc.h as part of a cleanup task I've
taken up, to replace gcc specific attributes with macros.

Last accepted patch I sent into linux-next for crypto: d8c34b949d8c:
crypto: Replaced gcc specific attributes with macros from compiler.h

The last commit of this task that went through you: 52f5684c8e1ec
kernel: use macros from compiler.h instead of __attribute__((...))

The next patch is for cleaning up the m68k subsystem and it requires
a new macro to wrap __attribute__ ((mode (...)))

Signed-off-by: Gideon Israel Dsouza <gidisrael@gmail.com>
---
 include/linux/compiler-gcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 0444b13..f1b1cfe 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -121,6 +121,7 @@
 #define __attribute_const__	__attribute__((__const__))
 #define __maybe_unused		__attribute__((unused))
 #define __always_unused		__attribute__((unused))
+#define __mode                  __attribute__((mode(x)))
 
 /* gcc version specific checks */
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2017-01-27 17:20 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-24 12:14 [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Gideon Israel Dsouza
2017-01-24 12:14 ` [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h Gideon Israel Dsouza
     [not found] ` <1485260068-2495-2-git-send-email-gidisrael@gmail.com>
2017-01-25  1:04   ` Greg Ungerer
2017-01-25  6:54   ` kbuild test robot
2017-01-27 16:39   ` Paul Gortmaker
2017-01-27 17:18     ` Gideon D'souza
2017-01-25  1:50 ` [PATCH 1/2] compiler-gcc.h: Added new macro for gcc attribute Joe Perches
     [not found] ` <1485309036.12563.46.camel@perches.com>
2017-01-25  4:50   ` Gideon D'souza
     [not found]   ` <CAPNrq4wbhovDcyuNdK84kA1nYtVKcSw42SJGHPsJK68VVuyyyg@mail.gmail.com>
2017-01-27 13:34     ` Gideon D'souza
     [not found]     ` <CAPNrq4zYukoyRYiH6erX2SwFKVrPfOBhCkKD_Z6kKHmrzGqfFw@mail.gmail.com>
2017-01-27 13:45       ` Joe Perches
     [not found]       ` <1485524751.12563.124.camel@perches.com>
2017-01-27 17:20         ` Gideon D'souza
  -- strict thread matches above, loose matches on Subject: below --
2017-01-19 13:34 Gideon Israel Dsouza

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox