From: Finn Thain <fthain@telegraphics.com.au>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH 5/10] ide: move ack_intr() method into 'struct ide_port_ops' (take 2)
Date: Sun, 14 Jun 2009 13:37:35 +1000 [thread overview]
Message-ID: <20090614033735.GB374@telegraphics.com.au> (raw)
In-Reply-To: <20090613161545.GB633@telegraphics.com.au>
On 14/06/09 02:15, Finn Thain wrote:
>
> > +++ ide-2.6/drivers/ide/ide-io.c
> > @@ -789,7 +789,8 @@ irqreturn_t ide_intr (int irq, void *dev
> >
> > spin_lock_irqsave(&hwif->lock, flags);
> >
> > - if (hwif->ack_intr && hwif->ack_intr(hwif) == 0)
> > + if (hwif->port_ops && hwif->port_ops->test_irq &&
> > + hwif->port_ops->test_irq(hwif) == 0)
>
> Wouldn't that be
>
> + if (hwif->port_ops && hwif->port_ops->test_irq(hwif) &&
> + hwif->port_ops->clear_irq(hwif) == 0)
>
> (this was never compiled?)
My bad.
(Note to self: don't try to quickly understand patches at 2am.)
> > case MAC_IDE_BABOON:
> > base = BABOON_BASE;
> > - ack_intr = NULL;
>
> I think you mean:
>
> case MAC_IDE_BABOON:
> base = BABOON_BASE;
> - ack_intr = NULL;
> + macide_port_ops.clear_irq = NULL;
>
> Why is this broken into two patches? Bisecting in between doesn't work.
Same here.
Sorry for the noise.
Finn
prev parent reply other threads:[~2009-06-14 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200702140101.26639.sshtylyov@ru.mvista.com>
2009-06-13 13:31 ` [PATCH 4/10] ide: move IRQ clearing from ack_intr() method to clear_irq() method (take 2) Sergei Shtylyov
2009-06-13 13:31 ` [PATCH 5/10] ide: move ack_intr() method into 'struct ide_port_ops' " Sergei Shtylyov
2009-06-13 16:15 ` Finn Thain
2009-06-14 3:37 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090614033735.GB374@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox