public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
* [PATCH 0/9] m68knommu: use ColdFire DMA timer
@ 2014-05-28  0:49 gerg
  2014-05-28  0:49 ` [PATCH 1/9] m68knommu: add DMA timer base address definitions for ColdFire 53xx gerg
                   ` (9 more replies)
  0 siblings, 10 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

Most of the modern ColdFire family members contain the DMA timer hardware
module. Build the support code for it and use it on those that do. We can
use it as an accurate time source.

I don't have test platforms based on all of these ColdFire types, it would
be really helpful if anyone that has any of these can test these changes.
It build tests fine on all these types, and it works on 520x and 527x
based platforms.

These changes are (neccessarily) on top of my recent patch series titled
"clean up timer code on the ColdFire 53xx".

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m520xsim.h        |    8 ++++++++
 arch/m68k/include/asm/m523xsim.h        |    8 ++++++++
 arch/m68k/include/asm/m527xsim.h        |    8 ++++++++
 arch/m68k/include/asm/m528xsim.h        |    8 ++++++++
 arch/m68k/include/asm/m53xxsim.h        |   10 +++++-----
 arch/m68k/include/asm/m5441xsim.h       |    8 ++++++++
 arch/m68k/platform/coldfire/Makefile    |   10 +++++-----
 arch/m68k/platform/coldfire/dma_timer.c |   24 +++++++++++++-----------
 8 files changed, 63 insertions(+), 21 deletions(-)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/9] m68knommu: add DMA timer base address definitions for ColdFire 53xx
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 2/9] m68knommu: add DMA timer base address definitions for ColdFire 520x gerg
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The Coldfire 532x and 537x CPU families also contain the ColdFire DMA Timer
hardware unit. Add address definitions for it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m53xxsim.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/m68k/include/asm/m53xxsim.h b/arch/m68k/include/asm/m53xxsim.h
index 5497216..cea69b1 100644
--- a/arch/m68k/include/asm/m53xxsim.h
+++ b/arch/m68k/include/asm/m53xxsim.h
@@ -116,12 +116,12 @@
 #define MCFPIT_BASE4		0xFC08C000	/* Base address of TIMER4 */
 
 /*
- *  Timer module.
+ *  DMA Timer module.
  */
-#define MCFTIMER_BASE1		0xFC070000	/* Base address of TIMER1 */
-#define MCFTIMER_BASE2		0xFC074000	/* Base address of TIMER2 */
-#define MCFTIMER_BASE3		0xFC078000	/* Base address of TIMER3 */
-#define MCFTIMER_BASE4		0xFC07C000	/* Base address of TIMER4 */
+#define MCFDTIM_BASE0		0xFC070000	/* Base of DMA TIMER 0 */
+#define MCFDTIM_BASE1		0xFC074000	/* Base of DMA TIMER 1 */
+#define MCFDTIM_BASE2		0xFC078000	/* Base of DMA TIMER 2 */
+#define MCFDTIM_BASE3		0xFC07C000	/* Base of DMA TIMER 3 */
 
 /*********************************************************************
  *
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/9] m68knommu: add DMA timer base address definitions for ColdFire 520x
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
  2014-05-28  0:49 ` [PATCH 1/9] m68knommu: add DMA timer base address definitions for ColdFire 53xx gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 3/9] m68knommu: add DMA timer base address definitions for ColdFire 523x gerg
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The Coldfire 520x CPU family also contains the ColdFire DMA Timer hardware
unit. Add address definitions for it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m520xsim.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/m68k/include/asm/m520xsim.h b/arch/m68k/include/asm/m520xsim.h
index db3f8ee..dbc9584 100644
--- a/arch/m68k/include/asm/m520xsim.h
+++ b/arch/m68k/include/asm/m520xsim.h
@@ -159,6 +159,14 @@
 #define	MCFPIT_BASE2		0xFC084000	/* Base address of TIMER2 */
 
 /*
+ *  DMA Timer module.
+ */
+#define MCFDTIM_BASE0		0xFC070000	/* Base of DMA TIMER 0 */
+#define MCFDTIM_BASE1		0xFC074000	/* Base of DMA TIMER 1 */
+#define MCFDTIM_BASE2		0xFC078000	/* Base of DMA TIMER 2 */
+#define MCFDTIM_BASE3		0xFC07C000	/* Base of DMA TIMER 3 */
+
+/*
  *  UART module.
  */
 #define MCFUART_BASE0		0xFC060000	/* Base address of UART0 */
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 3/9] m68knommu: add DMA timer base address definitions for ColdFire 523x
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
  2014-05-28  0:49 ` [PATCH 1/9] m68knommu: add DMA timer base address definitions for ColdFire 53xx gerg
  2014-05-28  0:49 ` [PATCH 2/9] m68knommu: add DMA timer base address definitions for ColdFire 520x gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 4/9] m68knommu: add DMA timer base address definitions for ColdFire 527x gerg
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The Coldfire 523x CPU family also contains the ColdFire DMA Timer hardware
unit. Add address definitions for it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m523xsim.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/m68k/include/asm/m523xsim.h b/arch/m68k/include/asm/m523xsim.h
index 5e06b4e..2d06b1e 100644
--- a/arch/m68k/include/asm/m523xsim.h
+++ b/arch/m68k/include/asm/m523xsim.h
@@ -164,6 +164,14 @@
 #define	MCFPIT_BASE4		(MCF_IPSBAR + 0x180000)
 
 /*
+ * DMA timer base addresses.
+ */
+#define MCFDTIM_BASE0		(MCF_IPSBAR + 0x000400)
+#define MCFDTIM_BASE1		(MCF_IPSBAR + 0x000440)
+#define MCFDTIM_BASE2		(MCF_IPSBAR + 0x000480)
+#define MCFDTIM_BASE3		(MCF_IPSBAR + 0x0004C0)
+
+/*
  * EPort
  */
 #define MCFEPORT_EPPAR		(MCF_IPSBAR + 0x130000)
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 4/9] m68knommu: add DMA timer base address definitions for ColdFire 527x
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (2 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 3/9] m68knommu: add DMA timer base address definitions for ColdFire 523x gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 5/9] m68knommu: add DMA timer base address definitions for ColdFire 528x gerg
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The Coldfire 527x CPU family also contains the ColdFire DMA Timer hardware
unit. Add address definitions for it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m527xsim.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/m68k/include/asm/m527xsim.h b/arch/m68k/include/asm/m527xsim.h
index 1bebbe7..b1cb7a5 100644
--- a/arch/m68k/include/asm/m527xsim.h
+++ b/arch/m68k/include/asm/m527xsim.h
@@ -333,6 +333,14 @@
 #define	MCFPIT_BASE4		(MCF_IPSBAR + 0x180000)
 
 /*
+ * DMA timer base addresses.
+ */
+#define MCFDTIM_BASE0		(MCF_IPSBAR + 0x000400)
+#define MCFDTIM_BASE1		(MCF_IPSBAR + 0x000440)
+#define MCFDTIM_BASE2		(MCF_IPSBAR + 0x000480)
+#define MCFDTIM_BASE3		(MCF_IPSBAR + 0x0004C0)
+
+/*
  * EPort
  */
 #define MCFEPORT_EPPAR		(MCF_IPSBAR + 0x130000)
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 5/9] m68knommu: add DMA timer base address definitions for ColdFire 528x
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (3 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 4/9] m68knommu: add DMA timer base address definitions for ColdFire 527x gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 6/9] m68knommu: add DMA timer base address definitions for ColdFire 5441x gerg
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The Coldfire 528x CPU family also contains the ColdFire DMA Timer hardware
unit. Add address definitions for it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m528xsim.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/m68k/include/asm/m528xsim.h b/arch/m68k/include/asm/m528xsim.h
index cf68ca0..561b6f5 100644
--- a/arch/m68k/include/asm/m528xsim.h
+++ b/arch/m68k/include/asm/m528xsim.h
@@ -194,6 +194,14 @@
 #define	MCFPIT_BASE4		(MCF_IPSBAR + 0x00180000)
 
 /*
+ * DMA timer base addresses.
+ */
+#define MCFDTIM_BASE0		(MCF_IPSBAR + 0x000400)
+#define MCFDTIM_BASE1		(MCF_IPSBAR + 0x000440)
+#define MCFDTIM_BASE2		(MCF_IPSBAR + 0x000480)
+#define MCFDTIM_BASE3		(MCF_IPSBAR + 0x0004C0)
+
+/*
  * 	Edge Port registers
  */
 #define MCFEPORT_EPPAR		(MCF_IPSBAR + 0x00130000)
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 6/9] m68knommu: add DMA timer base address definitions for ColdFire 5441x
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (4 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 5/9] m68knommu: add DMA timer base address definitions for ColdFire 528x gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 7/9] m68knommu: modify ColdFire dma_timer to use common definitions gerg
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The Coldfire 5441x CPU family also contains the ColdFire DMA Timer hardware
unit. Add address definitions for it.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/include/asm/m5441xsim.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/m68k/include/asm/m5441xsim.h b/arch/m68k/include/asm/m5441xsim.h
index cc798ab..973e817 100644
--- a/arch/m68k/include/asm/m5441xsim.h
+++ b/arch/m68k/include/asm/m5441xsim.h
@@ -102,6 +102,14 @@
 #define MCF_IRQ_PIT1		(MCFINT2_VECBASE + MCFINT2_PIT1)
 
 /*
+ *  DMA Timer module.
+ */
+#define MCFDTIM_BASE0		0xFC070000	/* Base of DMA TIMER 0 */
+#define MCFDTIM_BASE1		0xFC074000	/* Base of DMA TIMER 1 */
+#define MCFDTIM_BASE2		0xFC078000	/* Base of DMA TIMER 2 */
+#define MCFDTIM_BASE3		0xFC07C000	/* Base of DMA TIMER 3 */
+
+/*
  * Power Management
  */
 #define MCFPM_WCR		0xfc040013
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 7/9] m68knommu: modify ColdFire dma_timer to use common definitions
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (5 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 6/9] m68knommu: add DMA timer base address definitions for ColdFire 5441x gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 8/9] m68knommu: enable clock when using dma_timer hardware module gerg
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The ColdFire DMA Timer hardware module is used on a number of the ColdFire
family System on Chips. Modify the dma_timer.c driver address definitions
so that it can be used on any of those devices.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/platform/coldfire/dma_timer.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/arch/m68k/platform/coldfire/dma_timer.c b/arch/m68k/platform/coldfire/dma_timer.c
index 235ad57..9b7b950 100644
--- a/arch/m68k/platform/coldfire/dma_timer.c
+++ b/arch/m68k/platform/coldfire/dma_timer.c
@@ -14,17 +14,12 @@
 #include <asm/mcfpit.h>
 #include <asm/mcfsim.h>
 
-#define DMA_TIMER_0	(0x00)
-#define DMA_TIMER_1	(0x40)
-#define DMA_TIMER_2	(0x80)
-#define DMA_TIMER_3	(0xc0)
-
-#define DTMR0	(MCF_IPSBAR + DMA_TIMER_0 + 0x400)
-#define DTXMR0	(MCF_IPSBAR + DMA_TIMER_0 + 0x402)
-#define DTER0	(MCF_IPSBAR + DMA_TIMER_0 + 0x403)
-#define DTRR0	(MCF_IPSBAR + DMA_TIMER_0 + 0x404)
-#define DTCR0	(MCF_IPSBAR + DMA_TIMER_0 + 0x408)
-#define DTCN0	(MCF_IPSBAR + DMA_TIMER_0 + 0x40c)
+#define DTMR0	(MCFDTIM_BASE0 + 0x0)
+#define DTXMR0	(MCFDTIM_BASE0 + 0x2)
+#define DTER0	(MCFDTIM_BASE0 + 0x3)
+#define DTRR0	(MCFDTIM_BASE0 + 0x4)
+#define DTCR0	(MCFDTIM_BASE0 + 0x8)
+#define DTCN0	(MCFDTIM_BASE0 + 0xc)
 
 #define DMA_FREQ    ((MCF_CLK / 2) / 16)
 
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 8/9] m68knommu: enable clock when using dma_timer hardware module
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (6 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 7/9] m68knommu: modify ColdFire dma_timer to use common definitions gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28  0:49 ` [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it gerg
  2014-05-29 23:22 ` [PATCH 0/9] m68knommu: use ColdFire DMA timer Steven King
  9 siblings, 0 replies; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

Acquire the SoC clock when using the DMA timer hardware module. With the
clock acquired we can enable it and get it ticking. On most ColdFire SoC
hardware the DMA timer clock is not enabled by default.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/platform/coldfire/dma_timer.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/m68k/platform/coldfire/dma_timer.c b/arch/m68k/platform/coldfire/dma_timer.c
index 9b7b950..1f8d967 100644
--- a/arch/m68k/platform/coldfire/dma_timer.c
+++ b/arch/m68k/platform/coldfire/dma_timer.c
@@ -7,6 +7,7 @@
  */
 
 #include <linux/clocksource.h>
+#include <linux/clk.h>
 #include <linux/io.h>
 
 #include <asm/machdep.h>
@@ -44,12 +45,18 @@ static struct clocksource clocksource_cf_dt = {
 
 static int __init  init_cf_dt_clocksource(void)
 {
+	struct clk *clk;
+
 	/*
 	 * We setup DMA timer 0 in free run mode. This incrementing counter is
 	 * used as a highly precious clock source. With MCF_CLOCK = 150 MHz we
 	 * get a ~213 ns resolution and the 32bit register will overflow almost
 	 * every 15 minutes.
 	 */
+	clk = clk_get(NULL, "mcftmr.0");
+	if (clk)
+		clk_enable(clk);
+
 	__raw_writeb(0x00, DTXMR0);
 	__raw_writeb(0x00, DTER0);
 	__raw_writel(0x00000000, DTRR0);
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (7 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 8/9] m68knommu: enable clock when using dma_timer hardware module gerg
@ 2014-05-28  0:49 ` gerg
  2014-05-28 15:59   ` Steven King
  2014-05-29 23:22 ` [PATCH 0/9] m68knommu: use ColdFire DMA timer Steven King
  9 siblings, 1 reply; 14+ messages in thread
From: gerg @ 2014-05-28  0:49 UTC (permalink / raw)
  To: linux-m68k, uclinux-dev; +Cc: Greg Ungerer

From: Greg Ungerer <gerg@uclinux.org>

The DMA timer hardware module is present in all of the 520x, 527x, 528x,
53xx and 5441x families of ColdFire SoC. Use it as clock source on those
parts to give a more accurate clock.

Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
 arch/m68k/platform/coldfire/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/m68k/platform/coldfire/Makefile b/arch/m68k/platform/coldfire/Makefile
index 0818f77..cdd0b03 100644
--- a/arch/m68k/platform/coldfire/Makefile
+++ b/arch/m68k/platform/coldfire/Makefile
@@ -17,18 +17,18 @@ asflags-$(CONFIG_FULLDEBUG) := -DDEBUGGER_COMPATIBLE_CACHE=1
 obj-$(CONFIG_COLDFIRE)	+= cache.o clk.o device.o dma.o entry.o vectors.o
 obj-$(CONFIG_M5206)	+= m5206.o timers.o intc.o reset.o
 obj-$(CONFIG_M5206e)	+= m5206.o timers.o intc.o reset.o
-obj-$(CONFIG_M520x)	+= m520x.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M520x)	+= m520x.o pit.o dma_timer.o intc-simr.o reset.o
 obj-$(CONFIG_M523x)	+= m523x.o pit.o dma_timer.o intc-2.o reset.o
 obj-$(CONFIG_M5249)	+= m5249.o timers.o intc.o intc-5249.o reset.o
 obj-$(CONFIG_M525x)	+= m525x.o timers.o intc.o intc-525x.o reset.o
-obj-$(CONFIG_M527x)	+= m527x.o pit.o intc-2.o reset.o
+obj-$(CONFIG_M527x)	+= m527x.o pit.o dma_timer.o intc-2.o reset.o
 obj-$(CONFIG_M5272)	+= m5272.o intc-5272.o timers.o
-obj-$(CONFIG_M528x)	+= m528x.o pit.o intc-2.o reset.o
+obj-$(CONFIG_M528x)	+= m528x.o pit.o dma_timer.o intc-2.o reset.o
 obj-$(CONFIG_M5307)	+= m5307.o timers.o intc.o reset.o
-obj-$(CONFIG_M53xx)	+= m53xx.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M53xx)	+= m53xx.o pit.o dma_timer.o intc-simr.o reset.o
 obj-$(CONFIG_M5407)	+= m5407.o timers.o intc.o reset.o
 obj-$(CONFIG_M54xx)	+= m54xx.o sltimers.o intc-2.o
-obj-$(CONFIG_M5441x)	+= m5441x.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M5441x)	+= m5441x.o pit.o dma_timer.o intc-simr.o reset.o
 
 obj-$(CONFIG_NETtel)	+= nettel.o
 obj-$(CONFIG_CLEOPATRA)	+= nettel.o
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it
  2014-05-28  0:49 ` [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it gerg
@ 2014-05-28 15:59   ` Steven King
  2014-05-28 23:46     ` Greg Ungerer
  0 siblings, 1 reply; 14+ messages in thread
From: Steven King @ 2014-05-28 15:59 UTC (permalink / raw)
  To: linux-m68k; +Cc: uclinux-dev, gerg

On Tuesday 27 May 2014 5:49:49 pm gerg@uclinux.org wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> The DMA timer hardware module is present in all of the 520x, 527x, 528x,
> 53xx and 5441x families of ColdFire SoC. Use it as clock source on those
> parts to give a more accurate clock.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> ---
>  arch/m68k/platform/coldfire/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/m68k/platform/coldfire/Makefile
> b/arch/m68k/platform/coldfire/Makefile index 0818f77..cdd0b03 100644
> --- a/arch/m68k/platform/coldfire/Makefile
> +++ b/arch/m68k/platform/coldfire/Makefile
> @@ -17,18 +17,18 @@ asflags-$(CONFIG_FULLDEBUG) :=
> -DDEBUGGER_COMPATIBLE_CACHE=1 obj-$(CONFIG_COLDFIRE)	+= cache.o clk.o
> device.o dma.o entry.o vectors.o obj-$(CONFIG_M5206)	+= m5206.o timers.o
> intc.o reset.o
>  obj-$(CONFIG_M5206e)	+= m5206.o timers.o intc.o reset.o
> -obj-$(CONFIG_M520x)	+= m520x.o pit.o intc-simr.o reset.o
> +obj-$(CONFIG_M520x)	+= m520x.o pit.o dma_timer.o intc-simr.o reset.o
>  obj-$(CONFIG_M523x)	+= m523x.o pit.o dma_timer.o intc-2.o reset.o
>  obj-$(CONFIG_M5249)	+= m5249.o timers.o intc.o intc-5249.o reset.o
>  obj-$(CONFIG_M525x)	+= m525x.o timers.o intc.o intc-525x.o reset.o
> -obj-$(CONFIG_M527x)	+= m527x.o pit.o intc-2.o reset.o
> +obj-$(CONFIG_M527x)	+= m527x.o pit.o dma_timer.o intc-2.o reset.o
>  obj-$(CONFIG_M5272)	+= m5272.o intc-5272.o timers.o
> -obj-$(CONFIG_M528x)	+= m528x.o pit.o intc-2.o reset.o
> +obj-$(CONFIG_M528x)	+= m528x.o pit.o dma_timer.o intc-2.o reset.o
>  obj-$(CONFIG_M5307)	+= m5307.o timers.o intc.o reset.o
> -obj-$(CONFIG_M53xx)	+= m53xx.o pit.o intc-simr.o reset.o
> +obj-$(CONFIG_M53xx)	+= m53xx.o pit.o dma_timer.o intc-simr.o reset.o
>  obj-$(CONFIG_M5407)	+= m5407.o timers.o intc.o reset.o
>  obj-$(CONFIG_M54xx)	+= m54xx.o sltimers.o intc-2.o
> -obj-$(CONFIG_M5441x)	+= m5441x.o pit.o intc-simr.o reset.o
> +obj-$(CONFIG_M5441x)	+= m5441x.o pit.o dma_timer.o intc-simr.o reset.o
>
>  obj-$(CONFIG_NETtel)	+= nettel.o
>  obj-$(CONFIG_CLEOPATRA)	+= nettel.o

Hi Greg,

I couldn't get this part to apply.  What tree are you using?
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it
  2014-05-28 15:59   ` Steven King
@ 2014-05-28 23:46     ` Greg Ungerer
  0 siblings, 0 replies; 14+ messages in thread
From: Greg Ungerer @ 2014-05-28 23:46 UTC (permalink / raw)
  To: Steven King; +Cc: linux-m68k, uclinux-dev

Hi Steven,

On 29/05/14 01:59, Steven King wrote:
> On Tuesday 27 May 2014 5:49:49 pm gerg@uclinux.org wrote:
>> From: Greg Ungerer <gerg@uclinux.org>
>>
>> The DMA timer hardware module is present in all of the 520x, 527x, 528x,
>> 53xx and 5441x families of ColdFire SoC. Use it as clock source on those
>> parts to give a more accurate clock.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>> ---
>>  arch/m68k/platform/coldfire/Makefile | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/m68k/platform/coldfire/Makefile
>> b/arch/m68k/platform/coldfire/Makefile index 0818f77..cdd0b03 100644
>> --- a/arch/m68k/platform/coldfire/Makefile
>> +++ b/arch/m68k/platform/coldfire/Makefile
>> @@ -17,18 +17,18 @@ asflags-$(CONFIG_FULLDEBUG) :=
>> -DDEBUGGER_COMPATIBLE_CACHE=1 obj-$(CONFIG_COLDFIRE)	+= cache.o clk.o
>> device.o dma.o entry.o vectors.o obj-$(CONFIG_M5206)	+= m5206.o timers.o
>> intc.o reset.o
>>  obj-$(CONFIG_M5206e)	+= m5206.o timers.o intc.o reset.o
>> -obj-$(CONFIG_M520x)	+= m520x.o pit.o intc-simr.o reset.o
>> +obj-$(CONFIG_M520x)	+= m520x.o pit.o dma_timer.o intc-simr.o reset.o
>>  obj-$(CONFIG_M523x)	+= m523x.o pit.o dma_timer.o intc-2.o reset.o
>>  obj-$(CONFIG_M5249)	+= m5249.o timers.o intc.o intc-5249.o reset.o
>>  obj-$(CONFIG_M525x)	+= m525x.o timers.o intc.o intc-525x.o reset.o
>> -obj-$(CONFIG_M527x)	+= m527x.o pit.o intc-2.o reset.o
>> +obj-$(CONFIG_M527x)	+= m527x.o pit.o dma_timer.o intc-2.o reset.o
>>  obj-$(CONFIG_M5272)	+= m5272.o intc-5272.o timers.o
>> -obj-$(CONFIG_M528x)	+= m528x.o pit.o intc-2.o reset.o
>> +obj-$(CONFIG_M528x)	+= m528x.o pit.o dma_timer.o intc-2.o reset.o
>>  obj-$(CONFIG_M5307)	+= m5307.o timers.o intc.o reset.o
>> -obj-$(CONFIG_M53xx)	+= m53xx.o pit.o intc-simr.o reset.o
>> +obj-$(CONFIG_M53xx)	+= m53xx.o pit.o dma_timer.o intc-simr.o reset.o
>>  obj-$(CONFIG_M5407)	+= m5407.o timers.o intc.o reset.o
>>  obj-$(CONFIG_M54xx)	+= m54xx.o sltimers.o intc-2.o
>> -obj-$(CONFIG_M5441x)	+= m5441x.o pit.o intc-simr.o reset.o
>> +obj-$(CONFIG_M5441x)	+= m5441x.o pit.o dma_timer.o intc-simr.o reset.o
>>
>>  obj-$(CONFIG_NETtel)	+= nettel.o
>>  obj-$(CONFIG_CLEOPATRA)	+= nettel.o
> 
> Hi Greg,
> 
> I couldn't get this part to apply.  What tree are you using?

This was against linux-3.15-rc4

Regards
Greg



_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 0/9] m68knommu: use ColdFire DMA timer
  2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
                   ` (8 preceding siblings ...)
  2014-05-28  0:49 ` [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it gerg
@ 2014-05-29 23:22 ` Steven King
  2014-05-30  0:51   ` Greg Ungerer
  9 siblings, 1 reply; 14+ messages in thread
From: Steven King @ 2014-05-29 23:22 UTC (permalink / raw)
  To: linux-m68k; +Cc: gerg, uclinux-dev

On Tuesday 27 May 2014 5:49:40 pm gerg@uclinux.org wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> Most of the modern ColdFire family members contain the DMA timer hardware
> module. Build the support code for it and use it on those that do. We can
> use it as an accurate time source.
>
> I don't have test platforms based on all of these ColdFire types, it would
> be really helpful if anyone that has any of these can test these changes.
> It build tests fine on all these types, and it works on 520x and 527x
> based platforms.
>
> These changes are (neccessarily) on top of my recent patch series titled
> "clean up timer code on the ColdFire 53xx".
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> ---
>  arch/m68k/include/asm/m520xsim.h        |    8 ++++++++
>  arch/m68k/include/asm/m523xsim.h        |    8 ++++++++
>  arch/m68k/include/asm/m527xsim.h        |    8 ++++++++
>  arch/m68k/include/asm/m528xsim.h        |    8 ++++++++
>  arch/m68k/include/asm/m53xxsim.h        |   10 +++++-----
>  arch/m68k/include/asm/m5441xsim.h       |    8 ++++++++
>  arch/m68k/platform/coldfire/Makefile    |   10 +++++-----
>  arch/m68k/platform/coldfire/dma_timer.c |   24 +++++++++++++-----------
>  8 files changed, 63 insertions(+), 21 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hi Greg,

I was able to to test this on 528x and 5441x and didnt have problems, so you 
can add my Acked-by if you want.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 0/9] m68knommu: use ColdFire DMA timer
  2014-05-29 23:22 ` [PATCH 0/9] m68knommu: use ColdFire DMA timer Steven King
@ 2014-05-30  0:51   ` Greg Ungerer
  0 siblings, 0 replies; 14+ messages in thread
From: Greg Ungerer @ 2014-05-30  0:51 UTC (permalink / raw)
  To: Steven King; +Cc: linux-m68k, uclinux-dev

Hi Steven,

On 30/05/14 09:22, Steven King wrote:
> On Tuesday 27 May 2014 5:49:40 pm gerg@uclinux.org wrote:
>> From: Greg Ungerer <gerg@uclinux.org>
>>
>> Most of the modern ColdFire family members contain the DMA timer hardware
>> module. Build the support code for it and use it on those that do. We can
>> use it as an accurate time source.
>>
>> I don't have test platforms based on all of these ColdFire types, it would
>> be really helpful if anyone that has any of these can test these changes.
>> It build tests fine on all these types, and it works on 520x and 527x
>> based platforms.
>>
>> These changes are (neccessarily) on top of my recent patch series titled
>> "clean up timer code on the ColdFire 53xx".
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>> ---
>>  arch/m68k/include/asm/m520xsim.h        |    8 ++++++++
>>  arch/m68k/include/asm/m523xsim.h        |    8 ++++++++
>>  arch/m68k/include/asm/m527xsim.h        |    8 ++++++++
>>  arch/m68k/include/asm/m528xsim.h        |    8 ++++++++
>>  arch/m68k/include/asm/m53xxsim.h        |   10 +++++-----
>>  arch/m68k/include/asm/m5441xsim.h       |    8 ++++++++
>>  arch/m68k/platform/coldfire/Makefile    |   10 +++++-----
>>  arch/m68k/platform/coldfire/dma_timer.c |   24 +++++++++++++-----------
>>  8 files changed, 63 insertions(+), 21 deletions(-)
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Hi Greg,
> 
> I was able to to test this on 528x and 5441x and didnt have problems, so you 
> can add my Acked-by if you want.

Great, thanks for testing. I will add your acked-by.

The most significant change is for the 532x and 537x, but
I don't have either of those to test with.

Regards
Greg

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2014-05-30  0:51 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-28  0:49 [PATCH 0/9] m68knommu: use ColdFire DMA timer gerg
2014-05-28  0:49 ` [PATCH 1/9] m68knommu: add DMA timer base address definitions for ColdFire 53xx gerg
2014-05-28  0:49 ` [PATCH 2/9] m68knommu: add DMA timer base address definitions for ColdFire 520x gerg
2014-05-28  0:49 ` [PATCH 3/9] m68knommu: add DMA timer base address definitions for ColdFire 523x gerg
2014-05-28  0:49 ` [PATCH 4/9] m68knommu: add DMA timer base address definitions for ColdFire 527x gerg
2014-05-28  0:49 ` [PATCH 5/9] m68knommu: add DMA timer base address definitions for ColdFire 528x gerg
2014-05-28  0:49 ` [PATCH 6/9] m68knommu: add DMA timer base address definitions for ColdFire 5441x gerg
2014-05-28  0:49 ` [PATCH 7/9] m68knommu: modify ColdFire dma_timer to use common definitions gerg
2014-05-28  0:49 ` [PATCH 8/9] m68knommu: enable clock when using dma_timer hardware module gerg
2014-05-28  0:49 ` [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it gerg
2014-05-28 15:59   ` Steven King
2014-05-28 23:46     ` Greg Ungerer
2014-05-29 23:22 ` [PATCH 0/9] m68knommu: use ColdFire DMA timer Steven King
2014-05-30  0:51   ` Greg Ungerer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox