From: "George Spelvin" <linux@horizon.com>
To: geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org
Cc: linux@horizon.com
Subject: [RFC PATCH 2/2] arch/m68k: Add CONFIG_CPU_HAS_NO_MULDIV32
Date: 11 May 2016 06:25:35 -0400 [thread overview]
Message-ID: <20160511102535.5858.qmail@ns.horizon.com> (raw)
Assembly of 32-bit multiply/divide helpers was dependent on
CONFIG_CPU_HAS_NO_MULDIV64, which is not necessary.
Signed-off-by: George Spelvin <linux@horizon.com>
---
This also turns out to be a very useful symbol for some other work
I'm doing to <linux/hash.h>.
arch/m68k/Kconfig.cpu | 11 +++++++++++
arch/m68k/lib/Makefile | 4 ++--
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index 0dfcf12..3fce7bf 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -37,6 +37,7 @@ config M68000
bool "MC68000"
depends on !MMU
select CPU_HAS_NO_BITFIELDS
+ select CPU_HAS_NO_MULDIV32
select CPU_HAS_NO_MULDIV64
select CPU_HAS_NO_UNALIGNED
select GENERIC_CSUM
@@ -391,8 +392,18 @@ config NODES_SHIFT
config CPU_HAS_NO_BITFIELDS
bool
+config CPU_HAS_NO_MULDIV32
+ bool
+ help
+ This option indicates the CPU lacks 32x32->32-bit multiply
+ and divide instructions, and thus requires the GCC helper
+ functions __mulsi3, __divsi3 __modsi3, etc.
+
config CPU_HAS_NO_MULDIV64
bool
+ help
+ This option indicates the CPU lacks "widening" 32x32->64-bit
+ multiply and 64/32->(32,32)-bit divide instructions.
config CPU_HAS_NO_UNALIGNED
bool
diff --git a/arch/m68k/lib/Makefile b/arch/m68k/lib/Makefile
index fcd8eb1..e6553db 100644
--- a/arch/m68k/lib/Makefile
+++ b/arch/m68k/lib/Makefile
@@ -7,8 +7,8 @@ lib-y := ashldi3.o ashrdi3.o lshrdi3.o muldi3.o \
memcpy.o memset.o memmove.o
lib-$(CONFIG_MMU) += uaccess.o
-lib-$(CONFIG_CPU_HAS_NO_MULDIV64) += mulsi3.o divsi3.o udivsi3.o
-lib-$(CONFIG_CPU_HAS_NO_MULDIV64) += modsi3.o umodsi3.o
+lib-$(CONFIG_CPU_HAS_NO_MULDIV32) += mulsi3.o divsi3.o udivsi3.o
+lib-$(CONFIG_CPU_HAS_NO_MULDIV32) += modsi3.o umodsi3.o
ifndef CONFIG_GENERIC_CSUM
lib-y += checksum.o
--
2.8.1
next reply other threads:[~2016-05-11 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 10:25 George Spelvin [this message]
2016-05-12 12:55 ` [RFC PATCH 2/2] arch/m68k: Add CONFIG_CPU_HAS_NO_MULDIV32 Greg Ungerer
2016-05-12 20:31 ` George Spelvin
2016-05-13 1:02 ` Greg Ungerer
2016-05-13 3:28 ` Finn Thain
2016-05-13 2:39 ` George Spelvin
2016-05-13 4:01 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511102535.5858.qmail@ns.horizon.com \
--to=linux@horizon.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox