public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: fthain@telegraphics.com.au, linux@horizon.com
Cc: geert@linux-m68k.org, gerg@linux-m68k.org,
	linux-m68k@lists.linux-m68k.org
Subject: Re: [RFC PATCH 2/2] arch/m68k: Add CONFIG_CPU_HAS_NO_MULDIV32
Date: 12 May 2016 22:39:32 -0400	[thread overview]
Message-ID: <20160513023932.16877.qmail@ns.horizon.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1605131323500.7564@nippy.intranet>

Finn Thain wrote:
> On Fri, 12 May 2016, George Spelvin wrote:
>> +# Old GCC versions fall back to -m5200 compilation, generating these calls
>> +# even though the CPU doesn't actually need it.  See arch/m68k/Makefile.
>
> The comment is vague. Does anyone know which GCC versions do or don't work 
> like this?

Yes, I looked it up in the archived GCC documentation.  My current patch says:

(commit comment)
    Since the compiler version is not known at Kconfig time, this cannot
    be expressed in a CONFIG_ variable, but instead is handled by some
    Makefile hackery.  This only applies to GCC 4.2.4 and earlier, which
    is hopefully almost everyone, but Documentation/Changes says GCC 3.2.

(arch/m68k/lib/Makefile)
+# GCC 4.2.4 and earlier don't know about ColdFire models that support
+# DIV.L and fall back to -m5200, generating these calls even though the
+# CPU doesn't actually need it.  Not needed on GCC 4.3 or later.
+# See the $(call cc-option ...) lines in arch/m68k/Makefile.

  reply	other threads:[~2016-05-13  2:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 10:25 [RFC PATCH 2/2] arch/m68k: Add CONFIG_CPU_HAS_NO_MULDIV32 George Spelvin
2016-05-12 12:55 ` Greg Ungerer
2016-05-12 20:31   ` George Spelvin
2016-05-13  1:02     ` Greg Ungerer
2016-05-13  3:28     ` Finn Thain
2016-05-13  2:39       ` George Spelvin [this message]
2016-05-13  4:01         ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160513023932.16877.qmail@ns.horizon.com \
    --to=linux@horizon.com \
    --cc=fthain@telegraphics.com.au \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox