Status of affs support in the kernel and affstools

Status of affs support in the kernel and affstools

[John Paul Adrian Glaubitz]

Hello!

I was wondering what the current status of the affs driver in the kernel is,
did it receive the fixes that Michael(?) was working on? I vaguely remember
there were some issues with larger filesystems or so and that someone was
working on fixing these issues.

Also, I noticed that Roman Zippel actually created an affstools package [1]
back in the day and I wonder whether anyone has any experience with it. In
particular, I'm wondering what »different mkfs.affs« Artem Bityutskiy is
talking about here [2]. Is there an alternative tool for creating and checking
affs filesystems?

If we package it for Debian, it would be possible to create affs partitions
from debian-installer which would be useful for anyone wanting to install
Debian on an Amiga without a Workbench installation on the harddisk.

Thanks,
Adrian

> [1] https://www.xs4all.nl/~zippel/affstools-0.1a.tar.gz
> [2] https://marc.info/?l=linux-m68k&m=133888043312812&w=2

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: Status of affs support in the kernel and affstools

[Artem Bityutskiy]

On Tue, 2023-06-13 at 08:47 +0200, John Paul Adrian Glaubitz wrote:
> Also, I noticed that Roman Zippel actually created an affstools package [1]
> back in the day and I wonder whether anyone has any experience with it. In
> particular, I'm wondering what »different mkfs.affs« Artem Bityutskiy is
> talking about here [2]. Is there an alternative tool for creating and checking
> affs filesystems?

Hi Adrian,

I apologize, that message was sent 10 years ago and I do not remember details
any longer.

What I do remember is that I was doing some cross-filesystem changes and
struggled to test AFFS. At that time it felt that AFFS was abandoned. But I
remember I managed to create an AFFS partition, mount it in Linux, and test my
changes.

Thanks,
Artem.

Re: Status of affs support in the kernel and affstools

[John Paul Adrian Glaubitz]

Hi Artem!

On Tue, 2023-06-13 at 09:53 +0300, Artem Bityutskiy wrote:
> I apologize, that message was sent 10 years ago and I do not remember details
> any longer.

No worries, thanks for the quick reply!

> What I do remember is that I was doing some cross-filesystem changes and
> struggled to test AFFS. At that time it felt that AFFS was abandoned. But I
> remember I managed to create an AFFS partition, mount it in Linux, and test my
> changes.

I see. I'm just wondering what other mkfs.affs command you might have found that
you were using there. Maybe Geert or anyone else on this list can remember.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: Status of affs support in the kernel and affstools

[Martin Steigerwald]

John Paul Adrian Glaubitz - 13.06.23, 08:47:11 CEST:
> I was wondering what the current status of the affs driver in the
> kernel is, did it receive the fixes that Michael(?) was working on? I
> vaguely remember there were some issues with larger filesystems or so
> and that someone was working on fixing these issues.

Well I just searched for the large size fixing patches discussed on 
linux-m68k mailing list under subject titles "Amiga RDB partition 
support fixes":

While I found a steady stream of fixes for affs, including related to 
Amiga permission bit handling, quite recent fixes, even in 2023, I did 
not found that size fixing patch.

I recalled a discussion where Michael Schmitz talked to Jens Axboe after 
I asked whether the patch got in on 2023-08-21. I thought back then it 
would have went in, but maybe the last question asked by Jens Axboe did 
not get answered?

At least I did not found the patch in git history. Maybe I made a 
mistake during search.

I will reply to the other thread and ask again. Maybe it was just a last 
question / answer round missing. Or maybe someone else can confirm that 
the patch indeed went in.

Best,
-- 
Martin

Re: Status of affs support in the kernel and affstools

[John Paul Adrian Glaubitz]

Hi Stefan!

On Tue, 2023-06-13 at 00:15 -0700, Stefan Reinauer wrote:
> I have found amitools from Christian Vogelgsang to be a good tool
> for creating and manipulating affs.

Looks interesting [1] but it doesn't seem to contain any tool for
creating and checking AFFS filesystems.

Adrian

> [1] https://github.com/cnvogelg/amitools

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: Status of affs support in the kernel and affstools

[John Paul Adrian Glaubitz]

Hi Martin!

On Tue, 2023-06-13 at 09:20 +0200, Martin Steigerwald wrote:
> John Paul Adrian Glaubitz - 13.06.23, 08:47:11 CEST:
> > I was wondering what the current status of the affs driver in the
> > kernel is, did it receive the fixes that Michael(?) was working on? I
> > vaguely remember there were some issues with larger filesystems or so
> > and that someone was working on fixing these issues.
> (...)
> I will reply to the other thread and ask again. Maybe it was just a last 
> question / answer round missing. Or maybe someone else can confirm that 
> the patch indeed went in.

I greatly appreciate that. Thanks a lot for taking care of this!

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: Status of affs support in the kernel and affstools

[Martin Steigerwald]

Hi John, hi Artem, hi Michael.

John Paul Adrian Glaubitz - 13.06.23, 09:22:52 CEST:
> On Tue, 2023-06-13 at 09:20 +0200, Martin Steigerwald wrote:
> > John Paul Adrian Glaubitz - 13.06.23, 08:47:11 CEST:
> > > I was wondering what the current status of the affs driver in the
> > > kernel is, did it receive the fixes that Michael(?) was working
> > > on? I
> > > vaguely remember there were some issues with larger filesystems or
> > > so
> > > and that someone was working on fixing these issues.
> > 
> > (...)
> > I will reply to the other thread and ask again. Maybe it was just a
> > last question / answer round missing. Or maybe someone else can
> > confirm that the patch indeed went in.
> 
> I greatly appreciate that. Thanks a lot for taking care of this!

The Amiga RDB large partition fixes went in now.

Thanks to everyone involved! Special thanks to Michael for going through 
13 iterations!

https://lore.kernel.org/linux-m68k/10e23e7d-d2b0-f540-f0aa-ca83727fa10e@gmail.com/T/#m0eea1b4b33ff8d96ebfe35546bce3a67256ee166

----------  Weitergeleitete Nachricht  ----------

Betreff: Re: [PATCH v13 0/3] Amiga RDB partition support fixes
Datum: Dienstag, 20. Juni 2023, 22:28:34 CEST
Von: Jens Axboe <axboe@kernel.dk>
An: linux-block@vger.kernel.org, Michael Schmitz <schmitzmic@gmail.com>
Kopie: linux-m68k@vger.kernel.org, geert@linux-m68k.org, hch@lst.de, 
martin@lichtvoll.de, fthain@linux-m68k.org



On Wed, 21 Jun 2023 08:17:22 +1200, Michael Schmitz wrote:
> another last version of this patch series, only change
> in this version is in the patch 2 subject (to better
> reflect what it's about), and adding Geert's review
> tag to said patch.
> 
> I hope I've crossed all i's and dotted all t's now...
> 
> [...]

Applied, thanks!

[1/3] block: fix signed int overflow in Amiga partition support
      commit: fc3d092c6bb48d5865fec15ed5b333c12f36288c
[2/3] block: change all __u32 annotations to __be32 in affs_hardblocks.h
      commit: 95a55437dc49fb3342c82e61f5472a71c63d9ed0
[3/3] block: add overflow checks for Amiga partition support
      commit: b6f3f28f604ba3de4724ad82bea6adb1300c0b5f

Best regards,
-- 
Jens Axboe




-------------------------------------------------------------

Thanks,
-- 
Martin