From: Michael Pavone <pavone@retrodev.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-m68k@lists.linux-m68k.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] m68k/mvme16x: Fix timer interrupts
Date: Thu, 18 Mar 2021 00:23:02 -0700 [thread overview]
Message-ID: <598f5719-8cc5-15da-4062-157b1162318a@retrodev.com> (raw)
In-Reply-To: <96914f42-e18-29cc-6c5-28b3a2fb360@telegraphics.com.au>
On 3/17/21 8:05 PM, Finn Thain wrote:
> On Tue, 16 Mar 2021, Mike Pavone wrote:
>
>> Timer interrupts on MVME16x and MVME17x boards are broken as the CEN and
>> COC bits are being inadvertently cleared when clearing the overflow
>> counter. This results in no timer interrupts being delivered after the
>> first. Initialization then hangs in calibrate_delay as the jiffies counter
>> is not updated. OR with current register value to preserve these bits.
>>
>> Fixes: 19999a8b8782 ("m68k: mvme16x: Handle timer counter overflow")
>> Signed-off-by: Michael Pavone <pavone@retrodev.com>
> Sorry about that regression.
>
> Do you think that commit 7529b90d051e ("m68k: mvme147: Handle timer
> counter overflow") has the same problem?
I don't have an MVME147 board to test with, but based on the documentation
it looks like it does. The clear bit is in the same register as the enable
and count enable bits on the original PCCchip.
next prev parent reply other threads:[~2021-03-18 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 4:25 [PATCH] m68k/mvme16x: Fix timer interrupts Mike Pavone
2021-03-18 3:05 ` Finn Thain
2021-03-18 7:23 ` Michael Pavone [this message]
2021-03-19 6:35 ` Finn Thain
2021-03-19 7:07 ` Finn Thain
2021-03-19 19:33 ` Michael Pavone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=598f5719-8cc5-15da-4062-157b1162318a@retrodev.com \
--to=pavone@retrodev.com \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox