From: Michael Pavone <pavone@retrodev.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-m68k@lists.linux-m68k.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] m68k/mvme16x: Fix timer interrupts
Date: Fri, 19 Mar 2021 12:33:55 -0700 [thread overview]
Message-ID: <bc1b0c13-9c9d-617e-3f4b-74c19b010fa7@retrodev.com> (raw)
In-Reply-To: <f7fb45d-47e3-aeed-b85d-b3a36b14d7e@telegraphics.com.au>
On 3/19/21 12:07 AM, Finn Thain wrote:
> Since we know at compile time what bits should be set in PCCTOVR1, we can
> avoid the additional register access. We should do the same in
> mvme16x_sched_init() for clarity. What do you think about this patch?
Makes sense and your patch works fine on my MVME177.
On 3/18/21 11:35 PM, Finn Thain wrote:
> BTW, assuming you did get the kernel running on your hardware, do you know
> if there's any need for the '#warning check me!' that still remains in
> arch/m68k/mvme16x/config.c and arch/m68k/mvme147/config.c?
It's running in the sense that it successfully runs init, but the lack of
a proper tty driver makes it a bit painful to check anything else. I'm
going to take a stab at writing a new one next.
prev parent reply other threads:[~2021-03-19 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 4:25 [PATCH] m68k/mvme16x: Fix timer interrupts Mike Pavone
2021-03-18 3:05 ` Finn Thain
2021-03-18 7:23 ` Michael Pavone
2021-03-19 6:35 ` Finn Thain
2021-03-19 7:07 ` Finn Thain
2021-03-19 19:33 ` Michael Pavone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1b0c13-9c9d-617e-3f4b-74c19b010fa7@retrodev.com \
--to=pavone@retrodev.com \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox