* Re: [PATCH v1] can: flexcan: Drop unused platform driver data [not found] ` <20260528-fluorescent-sage-ladybug-43261b-mkl@pengutronix.de> @ 2026-05-28 13:26 ` Uwe Kleine-König (The Capable Hub) 2026-06-10 17:27 ` Uwe Kleine-König (The Capable Hub) 0 siblings, 1 reply; 2+ messages in thread From: Uwe Kleine-König (The Capable Hub) @ 2026-05-28 13:26 UTC (permalink / raw) To: Marc Kleine-Budde Cc: Vincent Mailhol, linux-can, linux-kernel, Rob Herring, Geert Uytterhoeven, linux-m68k [-- Attachment #1: Type: text/plain, Size: 734 bytes --] Hello Marc, On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote: > On 28.05.2026 11:45:39, Uwe Kleine-König (The Capable Hub) wrote: > > No function in the flexcan driver ever accesses the .driver_data member > > of its .id_table array as device_get_match_data() returns NULL for > > non-of platform devices. So drop that unused assignment. > > > > While touching that array, drop the trailing comma after the terminator > > entry. > > Does this mean that commit 5e6c3454b405 ("net: can: Use > device_get_match_data()") introduced a regression? Yes, I'd claim that this commit introduces a null pointer exception when mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes. Best regards Uwe [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] can: flexcan: Drop unused platform driver data 2026-05-28 13:26 ` [PATCH v1] can: flexcan: Drop unused platform driver data Uwe Kleine-König (The Capable Hub) @ 2026-06-10 17:27 ` Uwe Kleine-König (The Capable Hub) 0 siblings, 0 replies; 2+ messages in thread From: Uwe Kleine-König (The Capable Hub) @ 2026-06-10 17:27 UTC (permalink / raw) To: Marc Kleine-Budde Cc: Vincent Mailhol, linux-can, linux-kernel, Rob Herring, Geert Uytterhoeven, linux-m68k [-- Attachment #1: Type: text/plain, Size: 1003 bytes --] Hey Marc, On Thu, May 28, 2026 at 03:26:29PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote: > > On 28.05.2026 11:45:39, Uwe Kleine-König (The Capable Hub) wrote: > > > No function in the flexcan driver ever accesses the .driver_data member > > > of its .id_table array as device_get_match_data() returns NULL for > > > non-of platform devices. So drop that unused assignment. > > > > > > While touching that array, drop the trailing comma after the terminator > > > entry. > > > > Does this mean that commit 5e6c3454b405 ("net: can: Use > > device_get_match_data()") introduced a regression? > > Yes, I'd claim that this commit introduces a null pointer exception when > mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes. I wonder what your plan is here. Should I send a v2 that also drops the unused variable that I missed in my v1, or do you want this NPE addressed first? Best regards Uwe [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-10 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260528094540.1867783-2-u.kleine-koenig@baylibre.com>
[not found] ` <20260528-fluorescent-sage-ladybug-43261b-mkl@pengutronix.de>
2026-05-28 13:26 ` [PATCH v1] can: flexcan: Drop unused platform driver data Uwe Kleine-König (The Capable Hub)
2026-06-10 17:27 ` Uwe Kleine-König (The Capable Hub)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox