Re: [PATCH v1] can: flexcan: Drop unused platform driver data

Re: [PATCH v1] can: flexcan: Drop unused platform driver data

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

Hello Marc,

On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote:
> On 28.05.2026 11:45:39, Uwe Kleine-König (The Capable Hub) wrote:
> > No function in the flexcan driver ever accesses the .driver_data member
> > of its .id_table array as device_get_match_data() returns NULL for
> > non-of platform devices. So drop that unused assignment.
> >
> > While touching that array, drop the trailing comma after the terminator
> > entry.
> 
> Does this mean that commit 5e6c3454b405 ("net: can: Use
> device_get_match_data()") introduced a regression?

Yes, I'd claim that this commit introduces a null pointer exception when
mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1] can: flexcan: Drop unused platform driver data

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Hey Marc,

On Thu, May 28, 2026 at 03:26:29PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> On Thu, May 28, 2026 at 01:00:15PM +0200, Marc Kleine-Budde wrote:
> > On 28.05.2026 11:45:39, Uwe Kleine-König (The Capable Hub) wrote:
> > > No function in the flexcan driver ever accesses the .driver_data member
> > > of its .id_table array as device_get_match_data() returns NULL for
> > > non-of platform devices. So drop that unused assignment.
> > >
> > > While touching that array, drop the trailing comma after the terminator
> > > entry.
> > 
> > Does this mean that commit 5e6c3454b405 ("net: can: Use
> > device_get_match_data()") introduced a regression?
> 
> Yes, I'd claim that this commit introduces a null pointer exception when
> mcf_flexcan0 (defined in arch/m68k/coldfire/device.c) probes.

I wonder what your plan is here. Should I send a v2 that also drops the
unused variable that I missed in my v1, or do you want this NPE
addressed first?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]