[PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)

Linux Manual Pages development
 help / color / mirror / Atom feed

* [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)
@ 2026-05-01 14:57 Tomasz Kramkowski
  2026-05-03 21:14 ` Alejandro Colomar
  0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Kramkowski @ 2026-05-01 14:57 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: linux-man, Tomasz Kramkowski

Change the duplicate references to refer to all of the different
variants of the TC{GET,SET{S,S2,W}{,W,F}} constants.

This looks to be a bug which was introduced during a restructuring.

Signed-off-by: Tomasz Kramkowski <tomasz@kramkow.ski>
---
 man/man2/ioctl_tty.2 | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/man/man2/ioctl_tty.2 b/man/man2/ioctl_tty.2
index 1d6e279c0..cb2776867 100644
--- a/man/man2/ioctl_tty.2
+++ b/man/man2/ioctl_tty.2
@@ -42,21 +42,21 @@ whenever possible.
 .TQ
 .BR TCSETSF (2const)
 .TP
-.BR TCGETS (2const)
+.BR TCGETS2 (2const)
 .TQ
-.BR TCSETS (2const)
+.BR TCSETS2 (2const)
 .TQ
-.BR TCSETSW (2const)
+.BR TCSETSW2 (2const)
 .TQ
-.BR TCSETSF (2const)
+.BR TCSETSF2 (2const)
 .TP
-.BR TCGETS (2const)
+.BR TCGETA (2const)
 .TQ
-.BR TCSETS (2const)
+.BR TCSETA (2const)
 .TQ
-.BR TCSETSW (2const)
+.BR TCSETAW (2const)
 .TQ
-.BR TCSETSF (2const)
+.BR TCSETAF (2const)
 .SS Locking the termios structure
 .TP
 .BR TIOCGLCKTRMIOS (2const)
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)
  2026-05-01 14:57 [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const) Tomasz Kramkowski
@ 2026-05-03 21:14 ` Alejandro Colomar
  2026-05-18 11:21   ` Tomasz Kramkowski
  0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Colomar @ 2026-05-03 21:14 UTC (permalink / raw)
  To: Tomasz Kramkowski; +Cc: linux-man

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

Hi Tomasz,

On 2026-05-01T15:57:01+0100, Tomasz Kramkowski wrote:
> Change the duplicate references to refer to all of the different
> variants of the TC{GET,SET{S,S2,W}{,W,F}} constants.
> 
> This looks to be a bug which was introduced during a restructuring.

Would you mind adding a Fixes:' tag for that bug?  It would help for
reviewing.

See <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
and <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>.


Have a lovely night!
Alex

> 
> Signed-off-by: Tomasz Kramkowski <tomasz@kramkow.ski>
> ---
>  man/man2/ioctl_tty.2 | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/man/man2/ioctl_tty.2 b/man/man2/ioctl_tty.2
> index 1d6e279c0..cb2776867 100644
> --- a/man/man2/ioctl_tty.2
> +++ b/man/man2/ioctl_tty.2
> @@ -42,21 +42,21 @@ whenever possible.
>  .TQ
>  .BR TCSETSF (2const)
>  .TP
> -.BR TCGETS (2const)
> +.BR TCGETS2 (2const)
>  .TQ
> -.BR TCSETS (2const)
> +.BR TCSETS2 (2const)
>  .TQ
> -.BR TCSETSW (2const)
> +.BR TCSETSW2 (2const)
>  .TQ
> -.BR TCSETSF (2const)
> +.BR TCSETSF2 (2const)
>  .TP
> -.BR TCGETS (2const)
> +.BR TCGETA (2const)
>  .TQ
> -.BR TCSETS (2const)
> +.BR TCSETA (2const)
>  .TQ
> -.BR TCSETSW (2const)
> +.BR TCSETAW (2const)
>  .TQ
> -.BR TCSETSF (2const)
> +.BR TCSETAF (2const)
>  .SS Locking the termios structure
>  .TP
>  .BR TIOCGLCKTRMIOS (2const)
> -- 
> 2.51.0
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)
  2026-05-03 21:14 ` Alejandro Colomar
@ 2026-05-18 11:21   ` Tomasz Kramkowski
  2026-05-18 22:24     ` Alejandro Colomar
  0 siblings, 1 reply; 4+ messages in thread
From: Tomasz Kramkowski @ 2026-05-18 11:21 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: linux-man

Hey Alex,

On Sun May 3, 2026 at 10:14 PM BST, Alejandro Colomar wrote:
> Hi Tomasz,
>
> On 2026-05-01T15:57:01+0100, Tomasz Kramkowski wrote:
>> Change the duplicate references to refer to all of the different
>> variants of the TC{GET,SET{S,S2,W}{,W,F}} constants.
>> 
>> This looks to be a bug which was introduced during a restructuring.
>
> Would you mind adding a Fixes:' tag for that bug?  It would help for
> reviewing.
>
> See <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
> and <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>.

Fixes: e59976296 (2024-06-13; "ioctl_tty.2, TC[SG]ET*.2const: Split TC[SG]ET* from ioctl_tty(2)")

I hope this is sufficient, but if not, let me know and I will re-send
the patch with the tag.

Thanks,

Tomasz

> Have a lovely night!
> Alex
>
>> 
>> Signed-off-by: Tomasz Kramkowski <tomasz@kramkow.ski>
>> ---
>>  man/man2/ioctl_tty.2 | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>> 
>> diff --git a/man/man2/ioctl_tty.2 b/man/man2/ioctl_tty.2
>> index 1d6e279c0..cb2776867 100644
>> --- a/man/man2/ioctl_tty.2
>> +++ b/man/man2/ioctl_tty.2
>> @@ -42,21 +42,21 @@ whenever possible.
>>  .TQ
>>  .BR TCSETSF (2const)
>>  .TP
>> -.BR TCGETS (2const)
>> +.BR TCGETS2 (2const)
>>  .TQ
>> -.BR TCSETS (2const)
>> +.BR TCSETS2 (2const)
>>  .TQ
>> -.BR TCSETSW (2const)
>> +.BR TCSETSW2 (2const)
>>  .TQ
>> -.BR TCSETSF (2const)
>> +.BR TCSETSF2 (2const)
>>  .TP
>> -.BR TCGETS (2const)
>> +.BR TCGETA (2const)
>>  .TQ
>> -.BR TCSETS (2const)
>> +.BR TCSETA (2const)
>>  .TQ
>> -.BR TCSETSW (2const)
>> +.BR TCSETAW (2const)
>>  .TQ
>> -.BR TCSETSF (2const)
>> +.BR TCSETAF (2const)
>>  .SS Locking the termios structure
>>  .TP
>>  .BR TIOCGLCKTRMIOS (2const)
>> -- 
>> 2.51.0
>> 

-- 
Tomasz (Tom) Kramkowski

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const)
  2026-05-18 11:21   ` Tomasz Kramkowski
@ 2026-05-18 22:24     ` Alejandro Colomar
  0 siblings, 0 replies; 4+ messages in thread
From: Alejandro Colomar @ 2026-05-18 22:24 UTC (permalink / raw)
  To: Tomasz Kramkowski; +Cc: linux-man

[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]

Hey Tomasz,

On 2026-05-18T12:21:50+0100, Tomasz Kramkowski wrote:
> Hey Alex,
> 
> On Sun May 3, 2026 at 10:14 PM BST, Alejandro Colomar wrote:
> > Hi Tomasz,
> >
> > On 2026-05-01T15:57:01+0100, Tomasz Kramkowski wrote:
> >> Change the duplicate references to refer to all of the different
> >> variants of the TC{GET,SET{S,S2,W}{,W,F}} constants.

I think the first W should actually be an A.

> >> 
> >> This looks to be a bug which was introduced during a restructuring.
> >
> > Would you mind adding a Fixes:' tag for that bug?  It would help for
> > reviewing.
> >
> > See <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/patches/trailer#n16>
> > and <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/CONTRIBUTING.d/git#n46>.
> 
> Fixes: e59976296 (2024-06-13; "ioctl_tty.2, TC[SG]ET*.2const: Split TC[SG]ET* from ioctl_tty(2)")

Hmmm, it seems I pasted the blocks with the intention to edit, and then
forgot to actually edit.  Thanks!

> 
> I hope this is sufficient, but if not, let me know and I will re-send
> the patch with the tag.

This is enough.  I've applied the patch.


Have a lovely night!
Alex

> 
> Thanks,
> 
> Tomasz
> 
> > Have a lovely night!
> > Alex
> >
> >> 
> >> Signed-off-by: Tomasz Kramkowski <tomasz@kramkow.ski>
> >> ---
> >>  man/man2/ioctl_tty.2 | 16 ++++++++--------
> >>  1 file changed, 8 insertions(+), 8 deletions(-)
> >> 
> >> diff --git a/man/man2/ioctl_tty.2 b/man/man2/ioctl_tty.2
> >> index 1d6e279c0..cb2776867 100644
> >> --- a/man/man2/ioctl_tty.2
> >> +++ b/man/man2/ioctl_tty.2
> >> @@ -42,21 +42,21 @@ whenever possible.
> >>  .TQ
> >>  .BR TCSETSF (2const)
> >>  .TP
> >> -.BR TCGETS (2const)
> >> +.BR TCGETS2 (2const)
> >>  .TQ
> >> -.BR TCSETS (2const)
> >> +.BR TCSETS2 (2const)
> >>  .TQ
> >> -.BR TCSETSW (2const)
> >> +.BR TCSETSW2 (2const)
> >>  .TQ
> >> -.BR TCSETSF (2const)
> >> +.BR TCSETSF2 (2const)
> >>  .TP
> >> -.BR TCGETS (2const)
> >> +.BR TCGETA (2const)
> >>  .TQ
> >> -.BR TCSETS (2const)
> >> +.BR TCSETA (2const)
> >>  .TQ
> >> -.BR TCSETSW (2const)
> >> +.BR TCSETAW (2const)
> >>  .TQ
> >> -.BR TCSETSF (2const)
> >> +.BR TCSETAF (2const)
> >>  .SS Locking the termios structure
> >>  .TP
> >>  .BR TIOCGLCKTRMIOS (2const)
> >> -- 
> >> 2.51.0
> >> 
> 
> -- 
> Tomasz (Tom) Kramkowski
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-18 22:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 14:57 [PATCH] man/man2/ioctl_tty.2: Fix references to TCSETS(2const) Tomasz Kramkowski
2026-05-03 21:14 ` Alejandro Colomar
2026-05-18 11:21   ` Tomasz Kramkowski
2026-05-18 22:24     ` Alejandro Colomar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox