* [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API
@ 2017-08-14 11:00 Cihangir Akturk
2017-08-14 17:57 ` Steve Longerbeam
0 siblings, 1 reply; 3+ messages in thread
From: Cihangir Akturk @ 2017-08-14 11:00 UTC (permalink / raw)
To: slongerbeam
Cc: p.zabel, mchehab, gregkh, linux-media, devel, linux-kernel,
Cihangir Akturk
This driver uses various v4l2_subdev_get_try_*() functions provided by
V4L2 sub-device userspace API. Current configuration of Kconfig file
allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
breaks the build of driver.
Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
---
drivers/staging/media/imx/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
index 7eff50b..d8c3890 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers/staging/media/imx/Kconfig
@@ -1,6 +1,7 @@
config VIDEO_IMX_MEDIA
tristate "i.MX5/6 V4L2 media core driver"
- depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
+ depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
+ ARCH_MXC && IMX_IPUV3_CORE
select V4L2_FWNODE
---help---
Say yes here to enable support for video4linux media controller
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API
2017-08-14 11:00 [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API Cihangir Akturk
@ 2017-08-14 17:57 ` Steve Longerbeam
2017-08-14 20:15 ` Cihangir Akturk
0 siblings, 1 reply; 3+ messages in thread
From: Steve Longerbeam @ 2017-08-14 17:57 UTC (permalink / raw)
To: Cihangir Akturk
Cc: p.zabel, mchehab, gregkh, linux-media, devel, linux-kernel
Hi Akturk, this has already been fixed, see
4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").
Steve
On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> This driver uses various v4l2_subdev_get_try_*() functions provided by
> V4L2 sub-device userspace API. Current configuration of Kconfig file
> allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> breaks the build of driver.
>
> Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
> drivers/staging/media/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 7eff50b..d8c3890 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -1,6 +1,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> + ARCH_MXC && IMX_IPUV3_CORE
> select V4L2_FWNODE
> ---help---
> Say yes here to enable support for video4linux media controller
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API
2017-08-14 17:57 ` Steve Longerbeam
@ 2017-08-14 20:15 ` Cihangir Akturk
0 siblings, 0 replies; 3+ messages in thread
From: Cihangir Akturk @ 2017-08-14 20:15 UTC (permalink / raw)
To: Steve Longerbeam
Cc: p.zabel, mchehab, gregkh, linux-media, devel, linux-kernel
On Mon, Aug 14, 2017 at 10:57:46AM -0700, Steve Longerbeam wrote:
> Hi Akturk, this has already been fixed, see
Sorry. Apparently, I missed to update my tree, somehow.
>
> 4560cb4a0c ("media: imx: add VIDEO_V4L2_SUBDEV_API dependency").
>
> Steve
>
> On 08/14/2017 04:00 AM, Cihangir Akturk wrote:
> > This driver uses various v4l2_subdev_get_try_*() functions provided by
> > V4L2 sub-device userspace API. Current configuration of Kconfig file
> > allows us to enable VIDEO_IMX_MEDIA without enabling this API. This
> > breaks the build of driver.
> >
> > Depend on VIDEO_V4L2_SUBDEV_API to fix this issue.
> >
> > Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> > ---
> > drivers/staging/media/imx/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> > index 7eff50b..d8c3890 100644
> > --- a/drivers/staging/media/imx/Kconfig
> > +++ b/drivers/staging/media/imx/Kconfig
> > @@ -1,6 +1,7 @@
> > config VIDEO_IMX_MEDIA
> > tristate "i.MX5/6 V4L2 media core driver"
> > - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && ARCH_MXC && IMX_IPUV3_CORE
> > + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && \
> > + ARCH_MXC && IMX_IPUV3_CORE
> > select V4L2_FWNODE
> > ---help---
> > Say yes here to enable support for video4linux media controller
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-14 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-14 11:00 [PATCH] [media] media: imx: depends on V4L2 sub-device userspace API Cihangir Akturk
2017-08-14 17:57 ` Steve Longerbeam
2017-08-14 20:15 ` Cihangir Akturk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox