* [PATCH] media: coda: add missing h.264 levels
@ 2018-06-28 11:01 Philipp Zabel
2018-07-19 10:32 ` Philipp Zabel
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2018-06-28 11:01 UTC (permalink / raw)
To: linux-media; +Cc: kernel
This enables reordering support for h.264 main profile level 4.2,
5.0, and 5.1 streams. Even though we likely can't play back such
streams at full speed, we should still recognize them correctly.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/platform/coda/coda-h264.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
index 0e27412e01f5..07b4c706504f 100644
--- a/drivers/media/platform/coda/coda-h264.c
+++ b/drivers/media/platform/coda/coda-h264.c
@@ -108,6 +108,9 @@ int coda_h264_level(int level_idc)
case 32: return V4L2_MPEG_VIDEO_H264_LEVEL_3_2;
case 40: return V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
case 41: return V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
+ case 42: return V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
+ case 50: return V4L2_MPEG_VIDEO_H264_LEVEL_5_0;
+ case 51: return V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
default: return -EINVAL;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] media: coda: add missing h.264 levels
2018-06-28 11:01 [PATCH] media: coda: add missing h.264 levels Philipp Zabel
@ 2018-07-19 10:32 ` Philipp Zabel
2018-07-19 10:39 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2018-07-19 10:32 UTC (permalink / raw)
To: linux-media, Hans Verkuil; +Cc: kernel
Hi,
On Thu, 2018-06-28 at 13:01 +0200, Philipp Zabel wrote:
> This enables reordering support for h.264 main profile level 4.2,
> 5.0, and 5.1 streams. Even though we likely can't play back such
> streams at full speed, we should still recognize them correctly.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/media/platform/coda/coda-h264.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
> index 0e27412e01f5..07b4c706504f 100644
> --- a/drivers/media/platform/coda/coda-h264.c
> +++ b/drivers/media/platform/coda/coda-h264.c
> @@ -108,6 +108,9 @@ int coda_h264_level(int level_idc)
> case 32: return V4L2_MPEG_VIDEO_H264_LEVEL_3_2;
> case 40: return V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
> case 41: return V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
> + case 42: return V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
> + case 50: return V4L2_MPEG_VIDEO_H264_LEVEL_5_0;
> + case 51: return V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
> default: return -EINVAL;
> }
> }
I've seen that some newer coda patches have been accepted already,
maybe this fell through the cracks?
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: coda: add missing h.264 levels
2018-07-19 10:32 ` Philipp Zabel
@ 2018-07-19 10:39 ` Hans Verkuil
2018-07-19 10:50 ` Philipp Zabel
0 siblings, 1 reply; 5+ messages in thread
From: Hans Verkuil @ 2018-07-19 10:39 UTC (permalink / raw)
To: Philipp Zabel, linux-media; +Cc: kernel
On 07/19/18 12:32, Philipp Zabel wrote:
> Hi,
>
> On Thu, 2018-06-28 at 13:01 +0200, Philipp Zabel wrote:
>> This enables reordering support for h.264 main profile level 4.2,
>> 5.0, and 5.1 streams. Even though we likely can't play back such
>> streams at full speed, we should still recognize them correctly.
>>
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>> drivers/media/platform/coda/coda-h264.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
>> index 0e27412e01f5..07b4c706504f 100644
>> --- a/drivers/media/platform/coda/coda-h264.c
>> +++ b/drivers/media/platform/coda/coda-h264.c
>> @@ -108,6 +108,9 @@ int coda_h264_level(int level_idc)
>> case 32: return V4L2_MPEG_VIDEO_H264_LEVEL_3_2;
>> case 40: return V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
>> case 41: return V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
>> + case 42: return V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
>> + case 50: return V4L2_MPEG_VIDEO_H264_LEVEL_5_0;
>> + case 51: return V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
>> default: return -EINVAL;
>> }
>> }
>
> I've seen that some newer coda patches have been accepted already,
> maybe this fell through the cracks?
No, this was part of a pull request of mine posted July 6th which hasn't
been merged yet (Mauro is traveling with poor internet connectivity). I
think he's back next week, so hopefully we'll see these pull request merged.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: coda: add missing h.264 levels
2018-07-19 10:39 ` Hans Verkuil
@ 2018-07-19 10:50 ` Philipp Zabel
2018-07-19 11:10 ` Hans Verkuil
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2018-07-19 10:50 UTC (permalink / raw)
To: Hans Verkuil, linux-media; +Cc: kernel
On Thu, 2018-07-19 at 12:39 +0200, Hans Verkuil wrote:
> On 07/19/18 12:32, Philipp Zabel wrote:
> > Hi,
> >
> > On Thu, 2018-06-28 at 13:01 +0200, Philipp Zabel wrote:
> > > This enables reordering support for h.264 main profile level 4.2,
> > > 5.0, and 5.1 streams. Even though we likely can't play back such
> > > streams at full speed, we should still recognize them correctly.
> > >
> > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > ---
> > > drivers/media/platform/coda/coda-h264.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
> > > index 0e27412e01f5..07b4c706504f 100644
> > > --- a/drivers/media/platform/coda/coda-h264.c
> > > +++ b/drivers/media/platform/coda/coda-h264.c
> > > @@ -108,6 +108,9 @@ int coda_h264_level(int level_idc)
> > > case 32: return V4L2_MPEG_VIDEO_H264_LEVEL_3_2;
> > > case 40: return V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
> > > case 41: return V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
> > > + case 42: return V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
> > > + case 50: return V4L2_MPEG_VIDEO_H264_LEVEL_5_0;
> > > + case 51: return V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
> > > default: return -EINVAL;
> > > }
> > > }
> >
> > I've seen that some newer coda patches have been accepted already,
> > maybe this fell through the cracks?
>
> No, this was part of a pull request of mine posted July 6th which hasn't
> been merged yet (Mauro is traveling with poor internet connectivity). I
> think he's back next week, so hopefully we'll see these pull request merged.
Oh, I have to keep a closer look on the pull requests.
I only checked patchwork. Thank you!
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: coda: add missing h.264 levels
2018-07-19 10:50 ` Philipp Zabel
@ 2018-07-19 11:10 ` Hans Verkuil
0 siblings, 0 replies; 5+ messages in thread
From: Hans Verkuil @ 2018-07-19 11:10 UTC (permalink / raw)
To: Philipp Zabel, linux-media; +Cc: kernel
On 07/19/18 12:50, Philipp Zabel wrote:
> On Thu, 2018-07-19 at 12:39 +0200, Hans Verkuil wrote:
>> On 07/19/18 12:32, Philipp Zabel wrote:
>>> Hi,
>>>
>>> On Thu, 2018-06-28 at 13:01 +0200, Philipp Zabel wrote:
>>>> This enables reordering support for h.264 main profile level 4.2,
>>>> 5.0, and 5.1 streams. Even though we likely can't play back such
>>>> streams at full speed, we should still recognize them correctly.
>>>>
>>>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>>>> ---
>>>> drivers/media/platform/coda/coda-h264.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
>>>> index 0e27412e01f5..07b4c706504f 100644
>>>> --- a/drivers/media/platform/coda/coda-h264.c
>>>> +++ b/drivers/media/platform/coda/coda-h264.c
>>>> @@ -108,6 +108,9 @@ int coda_h264_level(int level_idc)
>>>> case 32: return V4L2_MPEG_VIDEO_H264_LEVEL_3_2;
>>>> case 40: return V4L2_MPEG_VIDEO_H264_LEVEL_4_0;
>>>> case 41: return V4L2_MPEG_VIDEO_H264_LEVEL_4_1;
>>>> + case 42: return V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
>>>> + case 50: return V4L2_MPEG_VIDEO_H264_LEVEL_5_0;
>>>> + case 51: return V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
>>>> default: return -EINVAL;
>>>> }
>>>> }
>>>
>>> I've seen that some newer coda patches have been accepted already,
>>> maybe this fell through the cracks?
>>
>> No, this was part of a pull request of mine posted July 6th which hasn't
>> been merged yet (Mauro is traveling with poor internet connectivity). I
>> think he's back next week, so hopefully we'll see these pull request merged.
>
> Oh, I have to keep a closer look on the pull requests.
> I only checked patchwork. Thank you!
The patch status is "Under Review". I use that state to indicate that I made
a pull request that is waiting for Mauro for the final review before he accepts
it.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-19 11:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-28 11:01 [PATCH] media: coda: add missing h.264 levels Philipp Zabel
2018-07-19 10:32 ` Philipp Zabel
2018-07-19 10:39 ` Hans Verkuil
2018-07-19 10:50 ` Philipp Zabel
2018-07-19 11:10 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox